Updating SPEAr Support

Quoted 13 lines

arch/arm/mach-spear3xx/spear300.c void __init spear300_init(void) · line 471

Quoted 13 lines

arch/arm/mach-spear3xx/spear300.c +8 -3

-void spear300_pmx_init(void)
-{
-	spear_pmx_init(&pmx_driver, SPEAR300_SOC_CONFIG_BASE,
+	/* pmx initialization */
+	pmx_driver.base = ioremap(SPEAR300_SOC_CONFIG_BASE,
 			SPEAR300_SOC_CONFIG_SIZE);
+	if (pmx_driver.base) {
+		ret = pmx_register(&pmx_driver);
+		if (ret)
+			printk(KERN_ERR "padmux: registeration failed. err no"
+					": %d\n", ret);
+		iounmap(pmx_driver.base);

why unmap it?

Quoted 14 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 13 lines

arch/arm/mach-spear3xx/spear300.c void __init spear300_init(void) · line 471

Quoted 13 lines

arch/arm/mach-spear3xx/spear300.c +8 -3

-void spear300_pmx_init(void)
-{
-	spear_pmx_init(&pmx_driver, SPEAR300_SOC_CONFIG_BASE,
+	/* pmx initialization */
+	pmx_driver.base = ioremap(SPEAR300_SOC_CONFIG_BASE,
 			SPEAR300_SOC_CONFIG_SIZE);
+	if (pmx_driver.base) {
+		ret = pmx_register(&pmx_driver);
+		if (ret)
+			printk(KERN_ERR "padmux: registeration failed. err no"
+					": %d\n", ret);
+		iounmap(pmx_driver.base);

why unmap it?

pmx_register will actually enable all selected devices and configure padmux. After this we will never change device configuration again. So don't need this mapping.

Quoted 16 lines · viresh kumar

Quoted 14 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 13 lines

arch/arm/mach-spear3xx/spear300.c void __init spear300_init(void) · line 471

Quoted 13 lines

arch/arm/mach-spear3xx/spear300.c +8 -3

-void spear300_pmx_init(void)
-{
-	spear_pmx_init(&pmx_driver, SPEAR300_SOC_CONFIG_BASE,
+	/* pmx initialization */
+	pmx_driver.base = ioremap(SPEAR300_SOC_CONFIG_BASE,
 			SPEAR300_SOC_CONFIG_SIZE);
+	if (pmx_driver.base) {
+		ret = pmx_register(&pmx_driver);
+		if (ret)
+			printk(KERN_ERR "padmux: registeration failed. err no"
+					": %d\n", ret);
+		iounmap(pmx_driver.base);

why unmap it?

Quoted 3 lines

pmx_register will actually enable all selected devices and configure padmux. After this we will never change device configuration again. So don't need this mapping.

so put a comment in the code

arch/arm/mach-spear3xx/spear3xx.c +5 -0

+}
+
+struct sys_timer spear3xx_timer = {
+	.init = spear3xx_timer_init,
+};

arch/arm/mach-spear6xx/include/mach/generic.h +2 -1

index 16205a5..e5967ed 100644
@@ -31,9 +31,10 @@
 /* Add spear6xx family device structure declarations here */
 extern struct amba_device gpio_device[];
 extern struct amba_device uart_device[];
-extern struct sys_timer spear_sys_timer;
+extern struct sys_timer spear6xx_timer;
 
 /* Add spear6xx family function declarations here */
+void __init spear_setup_timer(void);
 void __init spear6xx_map_io(void);
 void __init spear6xx_init_irq(void);
 void __init spear6xx_init(void);

arch/arm/mach-spear6xx/spear600_evb.c +0 -0

index daff8d0..bdd5b76 100644

arch/arm/mach-spear6xx/spear600_evb.c +1 -1

 MACHINE_START(SPEAR600, "ST-SPEAR600-EVB")
 	.boot_params	=	0x00000100,
 	.map_io		=	spear6xx_map_io,
 	.init_irq	=	spear6xx_init_irq,
-	.timer		=	&spear_sys_timer,
+	.timer		=	&spear6xx_timer,
 	.init_machine	=	spear600_evb_init,
 MACHINE_END

arch/arm/mach-spear6xx/spear6xx.c +9 -0

index baf6bcc..88a82ca 100644
@@ -155,3 +155,12 @@ void __init spear6xx_map_io(void)
 	/* This will initialize clock framework */
 	clk_init();
 }
+
+static void __init spear6xx_timer_init(void)
+{
+	spear_setup_timer();
+}
+
+struct sys_timer spear6xx_timer = {
+	.init = spear6xx_timer_init,
+};

arch/arm/plat-spear/time.c +0 -0

index ab21165..850d0cf 100644

arch/arm/plat-spear/time.c +4 -4

+
 static void clockevent_set_mode(enum clock_event_mode mode,
 				struct clock_event_device *clk_event_dev);
 static int clockevent_next_event(unsigned long evt,

@@ -215,7 +222,8 @@ static void __init spear_clockevent_init(void)
 
 void __init spear_setup_timer(void)
 {
-	struct clk *pll3_clk;
+	struct clk *clk;
+	int ret;
 
 	if (!request_mem_region(SPEAR_GPT0_BASE, SZ_1K, "gpt0")) {
 		pr_err("%s:cannot get IO addr\n", __func__);

@@ -234,26 +242,32 @@ void __init spear_setup_timer(void)
 		goto err_iomap;
 	}
 
-	pll3_clk = clk_get(NULL, "pll3_48m_clk");
-	if (!pll3_clk) {
-		pr_err("%s:couldn't get PLL3 as parent for gpt\n", __func__);
+	/* get the parent clock */

arch/arm/mach-spear3xx/spear3xx.c struct pmx_dev pmx_plgpio_45_46_49_50 = { · line 530

Quoted 5 lines

arch/arm/mach-spear3xx/spear3xx.c +3 -1

-#endif
+static void __init spear3xx_timer_init(void)
+{
+	spear_setup_timer();

why not call it directly?

Quoted 29 lines

arch/arm/mach-spear3xx/spear3xx.c +5 -0

+}
+
+struct sys_timer spear3xx_timer = {
+	.init = spear3xx_timer_init,
+};

arch/arm/mach-spear6xx/include/mach/generic.h +2 -1

index 16205a5..e5967ed 100644
@@ -31,9 +31,10 @@
 /* Add spear6xx family device structure declarations here */
 extern struct amba_device gpio_device[];
 extern struct amba_device uart_device[];
-extern struct sys_timer spear_sys_timer;
+extern struct sys_timer spear6xx_timer;
 
 /* Add spear6xx family function declarations here */
+void __init spear_setup_timer(void);
 void __init spear6xx_map_io(void);
 void __init spear6xx_init_irq(void);
 void __init spear6xx_init(void);

arch/arm/mach-spear6xx/spear600_evb.c +0 -0

index daff8d0..bdd5b76 100644
@@ -42,10 +42,11 @@ static void __init spear600_evb_init(void)
 		amba_device_register(amba_devs[i], &iomem_resource);
 }
 

arch/arm/mach-spear6xx/spear600_evb.c static void __init spear600_evb_init(void) · line 45

Quoted 1 line

arch/arm/mach-spear6xx/spear600_evb.c +1 -0

+

please remove

Quoted 33 lines

arch/arm/mach-spear6xx/spear600_evb.c +1 -1

 MACHINE_START(SPEAR600, "ST-SPEAR600-EVB")
 	.boot_params	=	0x00000100,
 	.map_io		=	spear6xx_map_io,
 	.init_irq	=	spear6xx_init_irq,
-	.timer		=	&spear_sys_timer,
+	.timer		=	&spear6xx_timer,
 	.init_machine	=	spear600_evb_init,
 MACHINE_END

arch/arm/mach-spear6xx/spear6xx.c +9 -0

index baf6bcc..88a82ca 100644
@@ -155,3 +155,12 @@ void __init spear6xx_map_io(void)
 	/* This will initialize clock framework */
 	clk_init();
 }
+
+static void __init spear6xx_timer_init(void)
+{
+	spear_setup_timer();
+}
+
+struct sys_timer spear6xx_timer = {
+	.init = spear6xx_timer_init,
+};

arch/arm/plat-spear/time.c +0 -0

index ab21165..850d0cf 100644
@@ -66,6 +66,13 @@
 static __iomem void *gpt_base;
 static struct clk *gpt_clk;
 

arch/arm/plat-spear/time.c line 74

Quoted 6 lines

arch/arm/plat-spear/time.c +6 -0

+/* following defines the parent clock to be used */
+#ifdef CONFIG_ARCH_SPEAR13XX
+static char pclk_name[] = "osc1_24m_clk";
+#else
+static char pclk_name[] = "pll3_48m_clk";
+#endif

why 2 name?

it will be better to use clkdev and create an alias

btw how about move the timer to drivers/clocksource?

Quoted 30 lines

arch/arm/plat-spear/time.c +9 -4

+
 static void clockevent_set_mode(enum clock_event_mode mode,
 				struct clock_event_device *clk_event_dev);
 static int clockevent_next_event(unsigned long evt,

@@ -215,7 +222,8 @@ static void __init spear_clockevent_init(void)
 
 void __init spear_setup_timer(void)
 {
-	struct clk *pll3_clk;
+	struct clk *clk;
+	int ret;
 
 	if (!request_mem_region(SPEAR_GPT0_BASE, SZ_1K, "gpt0")) {
 		pr_err("%s:cannot get IO addr\n", __func__);

@@ -234,26 +242,32 @@ void __init spear_setup_timer(void)
 		goto err_iomap;
 	}
 
-	pll3_clk = clk_get(NULL, "pll3_48m_clk");
-	if (!pll3_clk) {
-		pr_err("%s:couldn't get PLL3 as parent for gpt\n", __func__);
+	/* get the parent clock */
+	clk = clk_get(NULL, pclk_name);
+
+	if (!clk) {
+		pr_err("%s:couldn't get %s as parent for gpt\n",
+				__func__, pclk_name);
 		goto err_iomap;
 	}
 

arch/arm/plat-spear/time.c void __init spear_setup_timer(void) · line 254

Quoted 2 lines

arch/arm/plat-spear/time.c +1 -1

-	clk_set_parent(gpt_clk, pll3_clk);
+	clk_set_parent(gpt_clk, clk);

??
why not do this in the clock file?

Dear Jean,

Quoted 1 line · Jean-Christophe PLAGNIOL-VILLARD

Quoted 1 line

Quoted 5 lines

arch/arm/mach-spear3xx/spear3xx.c struct pmx_dev pmx_plgpio_45_46_49_50 = { · line 530

Quoted 4 lines

arch/arm/mach-spear3xx/spear3xx.c +3 -1

-#endif
+static void __init spear3xx_timer_init(void)
+{
+	spear_setup_timer();

why not call it directly?

A single level of abstraction was provided so that if archs (spear3xx/6xx/13xx) required to do something extra.

Quoted 7 lines

arch/arm/plat-spear/time.c line 74

Quoted 6 lines

arch/arm/plat-spear/time.c +6 -0

+/* following defines the parent clock to be used */
+#ifdef CONFIG_ARCH_SPEAR13XX
+static char pclk_name[] = "osc1_24m_clk";
+#else
+static char pclk_name[] = "pll3_48m_clk";
+#endif

why 2 name?

spear13xx has different parent clock for gpt than spear3xx/6xx.

Quoted 2 lines

it will be better to use clkdev and create an alias

This is specifically to chose parent clock, which can be different in different architectures. clkdev corresponding to parent clock is already defined. We use name here to get the clock.

Quoted 1 line

btw how about move the timer to drivers/clocksource?

I don't know whether this is the right place. Every body else has placed timer code in his respective mach/plat directory.

Quoted 30 lines

Quoted 30 lines

arch/arm/plat-spear/time.c +9 -4

+
 static void clockevent_set_mode(enum clock_event_mode mode,
 				struct clock_event_device *clk_event_dev);
 static int clockevent_next_event(unsigned long evt,

@@ -215,7 +222,8 @@ static void __init spear_clockevent_init(void)
 
 void __init spear_setup_timer(void)
 {
-	struct clk *pll3_clk;
+	struct clk *clk;
+	int ret;
 
 	if (!request_mem_region(SPEAR_GPT0_BASE, SZ_1K, "gpt0")) {
 		pr_err("%s:cannot get IO addr\n", __func__);

@@ -234,26 +242,32 @@ void __init spear_setup_timer(void)
 		goto err_iomap;
 	}
 
-	pll3_clk = clk_get(NULL, "pll3_48m_clk");
-	if (!pll3_clk) {
-		pr_err("%s:couldn't get PLL3 as parent for gpt\n", __func__);
+	/* get the parent clock */
+	clk = clk_get(NULL, pclk_name);
+
+	if (!clk) {
+		pr_err("%s:couldn't get %s as parent for gpt\n",
+				__func__, pclk_name);
 		goto err_iomap;
 	}
 

Quoted 4 lines

arch/arm/plat-spear/time.c void __init spear_setup_timer(void) · line 254

Quoted 2 lines

arch/arm/plat-spear/time.c +1 -1

-	clk_set_parent(gpt_clk, pll3_clk);
+	clk_set_parent(gpt_clk, clk);

??
why not do this in the clock file?

The functional clock of the timer very much depends on the parent clock it selects. This is a part of the timer itself, hence it is kept here.

Quoted 10 lines · Shiraz Hashim

Dear Jean,

Quoted 6 lines · Jean-Christophe PLAGNIOL-VILLARD

arch/arm/mach-spear3xx/spear3xx.c struct pmx_dev pmx_plgpio_45_46_49_50 = { · line 530

Quoted 5 lines

arch/arm/mach-spear3xx/spear3xx.c +3 -1

-#endif
+static void __init spear3xx_timer_init(void)
+{
+	spear_setup_timer();

why not call it directly?

Quoted 2 lines

A single level of abstraction was provided so that if archs (spear3xx/6xx/13xx) required to do something extra.

it does not seems to be needed at all so for now call it directly is enough

Quoted 8 lines

Quoted 7 lines

arch/arm/plat-spear/time.c line 74

Quoted 6 lines

arch/arm/plat-spear/time.c +6 -0

+/* following defines the parent clock to be used */
+#ifdef CONFIG_ARCH_SPEAR13XX
+static char pclk_name[] = "osc1_24m_clk";
+#else
+static char pclk_name[] = "pll3_48m_clk";
+#endif

why 2 name?

Quoted 1 line

spear13xx has different parent clock for gpt than spear3xx/6xx.

so use a generic name which will be an alias specify on the soc clock so here no need to do the ifdef specially if you want to support both of them in the same kernel

Quoted 42 lines

Quoted 2 lines

it will be better to use clkdev and create an alias

This is specifically to chose parent clock, which can be different in different architectures. clkdev corresponding to parent clock is already defined. We use name here to get the clock.

Quoted 1 line

btw how about move the timer to drivers/clocksource?

I don't know whether this is the right place. Every body else has placed timer code in his respective mach/plat directory.

Quoted 30 lines

Quoted 30 lines

arch/arm/plat-spear/time.c +9 -4

+
 static void clockevent_set_mode(enum clock_event_mode mode,
 				struct clock_event_device *clk_event_dev);
 static int clockevent_next_event(unsigned long evt,

@@ -215,7 +222,8 @@ static void __init spear_clockevent_init(void)
 
 void __init spear_setup_timer(void)
 {
-	struct clk *pll3_clk;
+	struct clk *clk;
+	int ret;
 
 	if (!request_mem_region(SPEAR_GPT0_BASE, SZ_1K, "gpt0")) {
 		pr_err("%s:cannot get IO addr\n", __func__);

@@ -234,26 +242,32 @@ void __init spear_setup_timer(void)
 		goto err_iomap;
 	}
 
-	pll3_clk = clk_get(NULL, "pll3_48m_clk");
-	if (!pll3_clk) {
-		pr_err("%s:couldn't get PLL3 as parent for gpt\n", __func__);
+	/* get the parent clock */
+	clk = clk_get(NULL, pclk_name);
+
+	if (!clk) {
+		pr_err("%s:couldn't get %s as parent for gpt\n",
+				__func__, pclk_name);
 		goto err_iomap;
 	}
 

Quoted 4 lines

Quoted 4 lines

arch/arm/plat-spear/time.c void __init spear_setup_timer(void) · line 254

Quoted 2 lines

arch/arm/plat-spear/time.c +1 -1

-	clk_set_parent(gpt_clk, pll3_clk);
+	clk_set_parent(gpt_clk, clk);

??
why not do this in the clock file?

Quoted 3 lines

The functional clock of the timer very much depends on the parent clock it selects. This is a part of the timer itself, hence it is kept here.

it's seems to be more soc depends than timer

Dear Jean,

Quoted 14 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 12 lines · Shiraz Hashim

Dear Jean,

Quoted 6 lines · Jean-Christophe PLAGNIOL-VILLARD

arch/arm/mach-spear3xx/spear3xx.c struct pmx_dev pmx_plgpio_45_46_49_50 = { · line 530

Quoted 5 lines

arch/arm/mach-spear3xx/spear3xx.c +3 -1

-#endif
+static void __init spear3xx_timer_init(void)
+{
+	spear_setup_timer();

why not call it directly?

A single level of abstraction was provided so that if archs (spear3xx/6xx/13xx) required to do something extra.

Quoted 2 lines

it does not seems to be needed at all so for now call it directly is enough

OK. So, I think what could be better is to set the parent clock of the gpt in the arch specific function like spear3xx_timer_init. This would also remove this part from the timer code.

Dear Jean,

Quoted 1 line · Jean-Christophe PLAGNIOL-VILLARD

Quoted 1 line

Quoted 5 lines

arch/arm/mach-spear3xx/spear3xx.c struct pmx_dev pmx_plgpio_45_46_49_50 = { · line 530

Quoted 4 lines

arch/arm/mach-spear3xx/spear3xx.c +3 -1

-#endif
+static void __init spear3xx_timer_init(void)
+{
+	spear_setup_timer();

why not call it directly?

A single level of abstraction was provided so that if archs (spear3xx/6xx/13xx) required to do something extra.

arch/arm/mach-spear13xx/include/mach/system.h new file +22 -0

new file mode 100644
index 0000000..6ce0819
@@ -0,0 +1,43 @@
+/*
+ * arch/arm/mach-spear13xx/include/mach/system.h
+ *
+ * spear13xx Machine family specific architecture functions
+ *
+ * Copyright (C) 2010 ST Microelectronics
+ * Shiraz Hashim <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#ifndef __MACH_SYSTEM_H
+#define __MACH_SYSTEM_H
+
+#include <linux/io.h>
+#include <mach/hardware.h>
+#include <mach/misc_regs.h>
+
+static inline void arch_idle(void)
+{

arch/arm/mach-spear13xx/include/mach/generic.h line 21

Quoted 8 lines · Viresh KUMAR

arch/arm/mach-spear13xx/include/mach/generic.h new file +8 -0

+#ifndef __MACH_GENERIC_H
+#define __MACH_GENERIC_H
+
+#include <asm/mach/time.h>
+#include <asm/mach/map.h>
+#include <linux/init.h>
+#include <linux/platform_device.h>
+#include <linux/amba/bus.h>

linux/ before asm/ please.

Quoted 5 lines

arch/arm/mach-spear13xx/include/mach/hardware.h new file +5 -0

+#ifndef __MACH_HARDWARE_H
+#define __MACH_HARDWARE_H
+
+#include <mach/spear.h>
+

arch/arm/mach-spear13xx/include/mach/hardware.h line 23

Quoted 5 lines

arch/arm/mach-spear13xx/include/mach/hardware.h new file +5 -0

+/* Vitual to physical translation of statically mapped space */
+#define IO_ADDRESS(x)		(x | 0xF0000000)
+
+/* typesafe io address */
+#define __io_address(n)		__io(IO_ADDRESS(n))

Wrong use of __io(). __io() is just a macro for asm/io.h to make use of, and in any case should be defined in your mach/io.h file.

Quoted 33 lines

arch/arm/mach-spear13xx/include/mach/system.h new file +27 -0

new file mode 100644
index 0000000..6ce0819
@@ -0,0 +1,43 @@
+/*
+ * arch/arm/mach-spear13xx/include/mach/system.h
+ *
+ * spear13xx Machine family specific architecture functions
+ *
+ * Copyright (C) 2010 ST Microelectronics
+ * Shiraz Hashim <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#ifndef __MACH_SYSTEM_H
+#define __MACH_SYSTEM_H
+
+#include <linux/io.h>
+#include <mach/hardware.h>
+#include <mach/misc_regs.h>
+
+static inline void arch_idle(void)
+{
+	/*
+	 * This should do all the clock switching
+	 * and wait for interrupt tricks
+	 */
+	cpu_do_idle();

arch/arm/mach-spear13xx/include/mach/system.h line 32

Quoted 5 lines

arch/arm/mach-spear13xx/include/mach/system.h new file +5 -0

+}
+
+static inline void arch_reset(char mode, const char *cmd)
+{
+	pr_info("Going to reboot...\n");

The kernel already prints a message for reboot, so this is superfluous. .

arch/arm/mach-spear13xx/platsmp.c new file +18 -0

new file mode 100644
index 0000000..8b75d1b
@@ -0,0 +1,203 @@
+/*
+ * arch/arm/mach-spear13xx/platsmp.c
+ *
+ * based upon linux/arch/arm/mach-realview/platsmp.c
+ *
+ * Copyright (C) 2010 ST Microelectronics Ltd.
+ * Shiraz Hashim <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <asm/cacheflush.h>
+#include <asm/hardware/gic.h>
+#include <asm/localtimer.h>
+#include <asm/mach-types.h>
+#include <asm/smp_scu.h>

arch/arm/mach-spear13xx/platsmp.c new file +62 -0

+
+/*
+ * control for which core is the next to come out of the secondary
+ * boot "holding pen"
+ */
+volatile int __cpuinitdata pen_release = -1;
+static DEFINE_SPINLOCK(boot_lock);
+
+static void __iomem *scu_base_addr(void)
+{
+	return __io_address(SPEAR13XX_SCU_BASE);
+}
+
+static inline unsigned int get_core_count(void)
+{
+	void __iomem *scu_base = scu_base_addr();
+
+	if (scu_base)
+		return scu_get_core_count(scu_base);
+	return 1;
+}
+
+void __cpuinit platform_secondary_init(unsigned int cpu)
+{
+	trace_hardirqs_off();
+
+	/*
+	 * if any interrupts are already enabled for the primary
+	 * core (e.g. timer irq), then they will not have been enabled
+	 * for us: do so
+	 */
+	gic_cpu_init(0, __io_address(SPEAR13XX_GIC_CPU_BASE));
+
+	/*
+	 * let the primary processor know we're out of the
+	 * pen, then head off into the C entry point
+	 */
+	pen_release = -1;
+	smp_wmb();
+
+	/*
+	 * Synchronise with the boot thread.
+	 */
+	spin_lock(&boot_lock);
+	spin_unlock(&boot_lock);
+}
+
+int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)
+{
+	unsigned long timeout;
+
+	/*
+	 * set synchronisation state between this boot processor
+	 * and the secondary one
+	 */
+	spin_lock(&boot_lock);
+
+	/*
+	 * The secondary processor is waiting to be released from
+	 * the holding pen - release it, then wait for it to flag
+	 * that it has been released by resetting pen_release.
+	 *

arch/arm/mach-spear13xx/platsmp.c new file +25 -0

+	pen_release = cpu;
+	flush_cache_all();
+
+	timeout = jiffies + (1 * HZ);
+	while (time_before(jiffies, timeout)) {
+		smp_rmb();
+		if (pen_release == -1)
+			break;
+
+		udelay(10);
+	}
+
+	/*
+	 * now the secondary core is starting up let it run its
+	 * calibrations, then wait for it to finish
+	 */
+	spin_unlock(&boot_lock);
+
+	return pen_release != -1 ? -ENOSYS : 0;
+}
+
+static void __init poke_milo(void)
+{
+	/* nobody is to be released from the pen yet */
+	pen_release = -1;

arch/arm/mach-spear13xx/platsmp.c new file +68 -0

+}
+
+/*
+ * Initialise the CPU possible map early - this describes the CPUs
+ * which may be present or become present in the system.
+ */
+void __init smp_init_cpus(void)
+{
+	unsigned int i, ncores = get_core_count();
+
+	for (i = 0; i < ncores; i++)
+		set_cpu_possible(i, true);
+}
+
+void __init smp_prepare_cpus(unsigned int max_cpus)
+{
+	unsigned int ncores = get_core_count();
+	unsigned int cpu = smp_processor_id();
+	int i;
+
+	/* sanity check */
+	if (ncores == 0) {
+		pr_err("Realview: strange CM count of 0? Default to 1\n");
+
+		ncores = 1;
+	}
+
+	if (ncores > num_possible_cpus()) {
+		ncores = num_possible_cpus();
+		pr_err(
+		       "spear13xx: no. of cores (%d) greater than configured "
+		       "maximum of %d - clipping\n",
+		       ncores, ncores);
+	}
+
+	smp_store_cpu_info(cpu);
+
+	/*
+	 * are we trying to boot more cores than exist?
+	 */
+	if (max_cpus > ncores)
+		max_cpus = ncores;
+
+	/*
+	 * Initialise the present map, which describes the set of CPUs
+	 * actually populated at the present time.
+	 */
+	for (i = 0; i < max_cpus; i++)
+		set_cpu_present(i, true);
+
+	/*
+	 * Initialise the SCU if there are more than one CPU and let
+	 * them know where to start. Note that, on modern versions of
+	 * MILO, the "poke" doesn't actually do anything until each
+	 * individual core is sent a soft interrupt to get it out of
+	 * WFI
+	 */
+	if (max_cpus > 1) {
+		/*
+		 * Enable the local timer or broadcast device for the
+		 * boot CPU, but only if we have more than one CPU.
+		 */
+		percpu_timer_setup();
+
+		scu_enable(scu_base_addr());
+		poke_milo();
+	}
+}

arch/arm/mach-spear13xx/spear1300.c new file +23 -0

new file mode 100644
index 0000000..c1b82f1
@@ -0,0 +1,23 @@
+/*
+ * arch/arm/mach-spear13xx/spear1300.c
+ *
+ * SPEAr1300 machine source file
+ *
+ * Copyright (C) 2010 ST Microelectronics
+ * Shiraz Hashim <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <mach/generic.h>
+#include <mach/spear.h>
+
+/* Add spear1300 specific devices here */
+
+void __init spear1300_init(void)
+{
+	/* call spear13xx family common init function */
+	spear13xx_init();
+}

arch/arm/mach-spear13xx/spear1300_evb.c new file +48 -0

new file mode 100644
index 0000000..d72c8a8
@@ -0,0 +1,48 @@
+/*
+ * arch/arm/mach-spear13xx/spear1300_evb.c
+ *
+ * SPEAr1300 evaluation board source file
+ *
+ * Copyright (C) 2010 ST Microelectronics
+ * Shiraz Hashim <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/types.h>
+#include <asm/mach/arch.h>
+#include <asm/mach-types.h>
+#include <mach/generic.h>
+#include <mach/spear.h>
+
+static struct amba_device *amba_devs[] __initdata = {
+	&uart_device,
+};
+
+static struct platform_device *plat_devs[] __initdata = {
+};
+
+static void __init spear1300_evb_init(void)
+{
+	unsigned int i;
+
+	/* call spear1300 machine init function */
+	spear1300_init();
+
+	/* Add Platform Devices */
+	platform_add_devices(plat_devs, ARRAY_SIZE(plat_devs));
+
+	/* Add Amba Devices */
+	for (i = 0; i < ARRAY_SIZE(amba_devs); i++)
+		amba_device_register(amba_devs[i], &iomem_resource);
+}
+
+MACHINE_START(SPEAR1300, "ST-SPEAR1300-EVB")
+	.boot_params	=	0x00000100,
+	.map_io		=	spear13xx_map_io,
+	.init_irq	=	spear13xx_init_irq,
+	.timer		=	&spear13xx_timer,
+	.init_machine	=	spear1300_evb_init,
+MACHINE_END

arch/arm/mach-spear13xx/spear13xx.c new file +14 -0

new file mode 100644
index 0000000..d11e300
@@ -0,0 +1,98 @@
+/*
+ * arch/arm/mach-spear13xx/spear13xx.c
+ *
+ * SPEAr13XX machines common source file
+ *
+ * Copyright (C) 2010 ST Microelectronics
+ * Shiraz Hashim <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/types.h>

arch/arm/mach-spear13xx/spear13xx.c new file +74 -0

+
+/* Add spear13xx machines common devices here */
+/* uart device registeration */
+struct amba_device uart_device = {
+	.dev = {
+		.init_name = "uart",
+	},
+	.res = {
+		.start = SPEAR13XX_UART_BASE,
+		.end = SPEAR13XX_UART_BASE + SZ_4K - 1,
+		.flags = IORESOURCE_MEM,
+	},
+	.irq = {IRQ_UART, NO_IRQ},
+};
+
+/* Do spear13xx familiy common initialization part here */
+void __init spear13xx_init(void)
+{
+	/* nothing to do for now */
+}
+
+/* This will initialize vic */
+void __init spear13xx_init_irq(void)
+{
+	gic_dist_init(0, __io_address(SPEAR13XX_GIC_DIST_BASE), 29);
+	gic_cpu_init(0, __io_address(SPEAR13XX_GIC_CPU_BASE));
+}
+
+/* Following will create static virtual/physical mappings */
+struct map_desc spear13xx_io_desc[] __initdata = {
+	{
+		.virtual	= IO_ADDRESS(SPEAR13XX_UART_BASE),
+		.pfn		= __phys_to_pfn(SPEAR13XX_UART_BASE),
+		.length		= SZ_4K,
+		.type		= MT_DEVICE
+	}, {
+		.virtual	= IO_ADDRESS(SPEAR13XX_A9SM_PERIP_BASE),
+		.pfn		= __phys_to_pfn(SPEAR13XX_A9SM_PERIP_BASE),
+		.length		= SZ_8K,
+		.type		= MT_DEVICE
+	}, {
+		.virtual	= IO_ADDRESS(SPEAR13XX_MISC_BASE),
+		.pfn		= __phys_to_pfn(SPEAR13XX_MISC_BASE),
+		.length		= SZ_8K,
+		.type		= MT_DEVICE
+	}, {
+		.virtual	= IO_ADDRESS(SPEAR13XX_SYSRAM0_BASE),
+		.pfn		= __phys_to_pfn(SPEAR13XX_SYSRAM0_BASE),
+		.length		= SZ_32K,
+		.type		= MT_DEVICE
+	},
+};
+
+/* This will create static memory mapping for selected devices */
+void __init spear13xx_map_io(void)
+{
+	iotable_init(spear13xx_io_desc, ARRAY_SIZE(spear13xx_io_desc));
+
+	/* This will initialize clock framework */
+	clk_init();
+}
+
+static void __init spear13xx_timer_init(void)
+{
+#ifdef CONFIG_LOCAL_TIMERS
+	/* Setup the local timer base */
+	twd_base = __io_address(SPEAR13XX_LOCAL_TMR_BASE);
+#endif
+	spear_setup_timer();
+}
+
+struct sys_timer spear13xx_timer = {
+	.init = spear13xx_timer_init,
+};

Signature · 7 lines

1.7.2.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Quoted 28 lines · Viresh KUMAR

arch/arm/mach-spear13xx/platsmp.c new file +22 -0

new file mode 100644
index 0000000..8b75d1b
@@ -0,0 +1,203 @@
+/*
+ * arch/arm/mach-spear13xx/platsmp.c
+ *
+ * based upon linux/arch/arm/mach-realview/platsmp.c
+ *
+ * Copyright (C) 2010 ST Microelectronics Ltd.
+ * Shiraz Hashim <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <asm/cacheflush.h>
+#include <asm/hardware/gic.h>
+#include <asm/localtimer.h>
+#include <asm/mach-types.h>
+#include <asm/smp_scu.h>
+#include <asm/unified.h>
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/errno.h>

arch/arm/mach-spear13xx/platsmp.c line 28

Quoted 6 lines

arch/arm/mach-spear13xx/platsmp.c new file +6 -0

+#include <linux/init.h>
+#include <linux/io.h>
+#include <linux/jiffies.h>
+#include <linux/smp.h>
+#include <mach/generic.h>
+#include <mach/hardware.h>

linux/ before asm/ before mach/ please.

Quoted 67 lines

arch/arm/mach-spear13xx/platsmp.c new file +67 -0

+
+/*
+ * control for which core is the next to come out of the secondary
+ * boot "holding pen"
+ */
+volatile int __cpuinitdata pen_release = -1;
+static DEFINE_SPINLOCK(boot_lock);
+
+static void __iomem *scu_base_addr(void)
+{
+     return __io_address(SPEAR13XX_SCU_BASE);
+}
+
+static inline unsigned int get_core_count(void)
+{
+     void __iomem *scu_base = scu_base_addr();
+
+     if (scu_base)
+             return scu_get_core_count(scu_base);
+     return 1;
+}
+
+void __cpuinit platform_secondary_init(unsigned int cpu)
+{
+     trace_hardirqs_off();
+
+     /*
+      * if any interrupts are already enabled for the primary
+      * core (e.g. timer irq), then they will not have been enabled
+      * for us: do so
+      */
+     gic_cpu_init(0, __io_address(SPEAR13XX_GIC_CPU_BASE));
+
+     /*
+      * let the primary processor know we're out of the
+      * pen, then head off into the C entry point
+      */
+     pen_release = -1;
+     smp_wmb();
+
+     /*
+      * Synchronise with the boot thread.
+      */
+     spin_lock(&boot_lock);
+     spin_unlock(&boot_lock);
+}
+
+int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)
+{
+     unsigned long timeout;
+
+     /*
+      * set synchronisation state between this boot processor
+      * and the secondary one
+      */
+     spin_lock(&boot_lock);
+
+     /*
+      * The secondary processor is waiting to be released from
+      * the holding pen - release it, then wait for it to flag
+      * that it has been released by resetting pen_release.
+      *
+      * Note that "pen_release" is the hardware CPU ID, whereas
+      * "cpu" is Linux's internal ID.
+      */
+
+     /*

arch/arm/mach-spear13xx/platsmp.c line 100

Quoted 5 lines

arch/arm/mach-spear13xx/platsmp.c new file +5 -0

+      * Note: Following is important otherwise cpu2 doesn't come up
+      * as secondary_data must be flushed before pen_release also
+      */
+
+     flush_cache_all();

You don't need this. secondary_data is already taken care of as of a few kernel releases ago.

Quoted 31 lines

arch/arm/mach-spear13xx/platsmp.c new file +31 -0

+     pen_release = cpu;
+     flush_cache_all();
+
+     timeout = jiffies + (1 * HZ);
+     while (time_before(jiffies, timeout)) {
+             smp_rmb();
+             if (pen_release == -1)
+                     break;
+
+             udelay(10);
+     }
+
+     /*
+      * now the secondary core is starting up let it run its
+      * calibrations, then wait for it to finish
+      */
+     spin_unlock(&boot_lock);
+
+     return pen_release != -1 ? -ENOSYS : 0;
+}
+
+static void __init poke_milo(void)
+{
+     /* nobody is to be released from the pen yet */
+     pen_release = -1;
+
+     /*
+      * Write the address of secondary startup into the system-wide
+      * location (presently it is in SRAM). The BootMonitor waits
+      * for this register to become non-zero.
+      */

arch/arm/mach-spear13xx/platsmp.c line 135

Quoted 4 lines

arch/arm/mach-spear13xx/platsmp.c new file +4 -0

+     __raw_writel(BSYM(virt_to_phys(spear13xx_secondary_startup)),
+                     __io_address(SPEAR13XX_SYS_LOCATION));
+
+     mb();

Please get rid of this function. You don't have milo, and milo is pretty much dead anyway. Please read the Versatile Express SMP code and base your version off that (cleaned up) version instead.

Quoted 175 lines

arch/arm/mach-spear13xx/platsmp.c new file +68 -0

+}
+
+/*
+ * Initialise the CPU possible map early - this describes the CPUs
+ * which may be present or become present in the system.
+ */
+void __init smp_init_cpus(void)
+{
+     unsigned int i, ncores = get_core_count();
+
+     for (i = 0; i < ncores; i++)
+             set_cpu_possible(i, true);
+}
+
+void __init smp_prepare_cpus(unsigned int max_cpus)
+{
+     unsigned int ncores = get_core_count();
+     unsigned int cpu = smp_processor_id();
+     int i;
+
+     /* sanity check */
+     if (ncores == 0) {
+             pr_err("Realview: strange CM count of 0? Default to 1\n");
+
+             ncores = 1;
+     }
+
+     if (ncores > num_possible_cpus()) {
+             ncores = num_possible_cpus();
+             pr_err(
+                    "spear13xx: no. of cores (%d) greater than configured "
+                    "maximum of %d - clipping\n",
+                    ncores, ncores);
+     }
+
+     smp_store_cpu_info(cpu);
+
+     /*
+      * are we trying to boot more cores than exist?
+      */
+     if (max_cpus > ncores)
+             max_cpus = ncores;
+
+     /*
+      * Initialise the present map, which describes the set of CPUs
+      * actually populated at the present time.
+      */
+     for (i = 0; i < max_cpus; i++)
+             set_cpu_present(i, true);
+
+     /*
+      * Initialise the SCU if there are more than one CPU and let
+      * them know where to start. Note that, on modern versions of
+      * MILO, the "poke" doesn't actually do anything until each
+      * individual core is sent a soft interrupt to get it out of
+      * WFI
+      */
+     if (max_cpus > 1) {
+             /*
+              * Enable the local timer or broadcast device for the
+              * boot CPU, but only if we have more than one CPU.
+              */
+             percpu_timer_setup();
+
+             scu_enable(scu_base_addr());
+             poke_milo();
+     }
+}

arch/arm/mach-spear13xx/spear1300.c new file +23 -0

new file mode 100644
index 0000000..c1b82f1
@@ -0,0 +1,23 @@
+/*
+ * arch/arm/mach-spear13xx/spear1300.c
+ *
+ * SPEAr1300 machine source file
+ *
+ * Copyright (C) 2010 ST Microelectronics
+ * Shiraz Hashim <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <mach/generic.h>
+#include <mach/spear.h>
+
+/* Add spear1300 specific devices here */
+
+void __init spear1300_init(void)
+{
+     /* call spear13xx family common init function */
+     spear13xx_init();
+}

arch/arm/mach-spear13xx/spear1300_evb.c new file +48 -0

new file mode 100644
index 0000000..d72c8a8
@@ -0,0 +1,48 @@
+/*
+ * arch/arm/mach-spear13xx/spear1300_evb.c
+ *
+ * SPEAr1300 evaluation board source file
+ *
+ * Copyright (C) 2010 ST Microelectronics
+ * Shiraz Hashim <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/types.h>
+#include <asm/mach/arch.h>
+#include <asm/mach-types.h>
+#include <mach/generic.h>
+#include <mach/spear.h>
+
+static struct amba_device *amba_devs[] __initdata = {
+     &uart_device,
+};
+
+static struct platform_device *plat_devs[] __initdata = {
+};
+
+static void __init spear1300_evb_init(void)
+{
+     unsigned int i;
+
+     /* call spear1300 machine init function */
+     spear1300_init();
+
+     /* Add Platform Devices */
+     platform_add_devices(plat_devs, ARRAY_SIZE(plat_devs));
+
+     /* Add Amba Devices */
+     for (i = 0; i < ARRAY_SIZE(amba_devs); i++)
+             amba_device_register(amba_devs[i], &iomem_resource);
+}
+
+MACHINE_START(SPEAR1300, "ST-SPEAR1300-EVB")
+     .boot_params    =       0x00000100,
+     .map_io         =       spear13xx_map_io,
+     .init_irq       =       spear13xx_init_irq,
+     .timer          =       &spear13xx_timer,
+     .init_machine   =       spear1300_evb_init,
+MACHINE_END

arch/arm/mach-spear13xx/spear13xx.c new file +18 -0

new file mode 100644
index 0000000..d11e300
@@ -0,0 +1,98 @@
+/*
+ * arch/arm/mach-spear13xx/spear13xx.c
+ *
+ * SPEAr13XX machines common source file
+ *
+ * Copyright (C) 2010 ST Microelectronics
+ * Shiraz Hashim <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/types.h>
+#include <linux/ptrace.h>
+#include <linux/io.h>
+#include <asm/hardware/gic.h>
+#include <asm/irq.h>

arch/arm/mach-spear13xx/spear13xx.c line 24

Quoted 6 lines

arch/arm/mach-spear13xx/spear13xx.c new file +6 -0

+#include <asm/localtimer.h>
+#include <asm/mach/arch.h>
+#include <asm/smp_twd.h>
+#include <mach/irqs.h>
+#include <mach/generic.h>
+#include <mach/hardware.h>

So do you need all these includes?

Quoted 68 lines

arch/arm/mach-spear13xx/spear13xx.c new file +68 -0

+
+/* Add spear13xx machines common devices here */
+/* uart device registeration */
+struct amba_device uart_device = {
+     .dev = {
+             .init_name = "uart",
+     },
+     .res = {
+             .start = SPEAR13XX_UART_BASE,
+             .end = SPEAR13XX_UART_BASE + SZ_4K - 1,
+             .flags = IORESOURCE_MEM,
+     },
+     .irq = {IRQ_UART, NO_IRQ},
+};
+
+/* Do spear13xx familiy common initialization part here */
+void __init spear13xx_init(void)
+{
+     /* nothing to do for now */
+}
+
+/* This will initialize vic */
+void __init spear13xx_init_irq(void)
+{
+     gic_dist_init(0, __io_address(SPEAR13XX_GIC_DIST_BASE), 29);
+     gic_cpu_init(0, __io_address(SPEAR13XX_GIC_CPU_BASE));
+}
+
+/* Following will create static virtual/physical mappings */
+struct map_desc spear13xx_io_desc[] __initdata = {
+     {
+             .virtual        = IO_ADDRESS(SPEAR13XX_UART_BASE),
+             .pfn            = __phys_to_pfn(SPEAR13XX_UART_BASE),
+             .length         = SZ_4K,
+             .type           = MT_DEVICE
+     }, {
+             .virtual        = IO_ADDRESS(SPEAR13XX_A9SM_PERIP_BASE),
+             .pfn            = __phys_to_pfn(SPEAR13XX_A9SM_PERIP_BASE),
+             .length         = SZ_8K,
+             .type           = MT_DEVICE
+     }, {
+             .virtual        = IO_ADDRESS(SPEAR13XX_MISC_BASE),
+             .pfn            = __phys_to_pfn(SPEAR13XX_MISC_BASE),
+             .length         = SZ_8K,
+             .type           = MT_DEVICE
+     }, {
+             .virtual        = IO_ADDRESS(SPEAR13XX_SYSRAM0_BASE),
+             .pfn            = __phys_to_pfn(SPEAR13XX_SYSRAM0_BASE),
+             .length         = SZ_32K,
+             .type           = MT_DEVICE
+     },
+};
+
+/* This will create static memory mapping for selected devices */
+void __init spear13xx_map_io(void)
+{
+     iotable_init(spear13xx_io_desc, ARRAY_SIZE(spear13xx_io_desc));
+
+     /* This will initialize clock framework */
+     clk_init();
+}
+
+static void __init spear13xx_timer_init(void)
+{
+#ifdef CONFIG_LOCAL_TIMERS
+     /* Setup the local timer base */
+     twd_base = __io_address(SPEAR13XX_LOCAL_TMR_BASE);
+#endif

Quoted 8 lines

arch/arm/mach-spear13xx/spear13xx.c new file +6 -1

+     spear_setup_timer();
+}
+
+struct sys_timer spear13xx_timer = {
+     .init = spear13xx_timer_init,
+};
--

1.7.2.2

From: Shiraz Hashim <[email protected]>

Signed-off-by Shiraz Hashim <[email protected]>

Signed-off-by Viresh Kumar <[email protected]>

---
 arch/arm/Kconfig  |   12 ++++++++----
 arch/arm/Makefile |    1 +
 2 files changed, 9 insertions(+), 4 deletions(-)

arch/arm/Kconfig +0 -0

index 9295110..950c045 100644

Quoted 1 line · Viresh KUMAR

Quoted 1 line

From: Shiraz Hashim <[email protected]>

missing patch descriptin

Quoted 8 lines

Quoted 8 lines

Signed-off-by Shiraz Hashim <[email protected]>

Signed-off-by Viresh Kumar <[email protected]>

---
 arch/arm/Kconfig  |   12 ++++++++----
 arch/arm/Makefile |    1 +
 2 files changed, 9 insertions(+), 4 deletions(-)

Quoted 11 lines

arch/arm/Kconfig config SMP · line 1148

Quoted 11 lines

arch/arm/Kconfig +2 -1

index 9295110..950c045 100644
@@ -1144,11 +1144,13 @@ config SMP
 	bool "Symmetric Multi-Processing (EXPERIMENTAL)"
 	depends on EXPERIMENTAL && (REALVIEW_EB_ARM11MP || REALVIEW_EB_A9MP ||\
 		 MACH_REALVIEW_PB11MP || MACH_REALVIEW_PBX || ARCH_OMAP4 ||\
-		 ARCH_S5PV310 || ARCH_TEGRA || ARCH_U8500 || ARCH_VEXPRESS_CA9X4)
+		 ARCH_S5PV310 || ARCH_SPEAR13XX || ARCH_TEGRA || ARCH_U8500 ||\
+		 ARCH_VEXPRESS_CA9X4)

can we get rid of such long list by introducing a HAVE somthing etc....

Quoted 11 lines

arch/arm/Kconfig +0 -0

arch/arm/Kconfig config SMP · line 1148

Quoted 10 lines

index 9295110..950c045 100644

arch/arm/Kconfig +2 -1

@@ -1144,11 +1144,13 @@ config SMP
 	bool "Symmetric Multi-Processing (EXPERIMENTAL)"
 	depends on EXPERIMENTAL && (REALVIEW_EB_ARM11MP || REALVIEW_EB_A9MP ||\
 		 MACH_REALVIEW_PB11MP || MACH_REALVIEW_PBX || ARCH_OMAP4 ||\
-		 ARCH_S5PV310 || ARCH_TEGRA || ARCH_U8500 || ARCH_VEXPRESS_CA9X4)
+		 ARCH_S5PV310 || ARCH_SPEAR13XX || ARCH_TEGRA || ARCH_U8500 ||\
+		 ARCH_VEXPRESS_CA9X4)

can we get rid of such long list by introducing a HAVE somthing etc....

Quoted 13 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 11 lines

arch/arm/Kconfig +0 -0

arch/arm/Kconfig config SMP · line 1148

Quoted 10 lines

index 9295110..950c045 100644

arch/arm/Kconfig +2 -1

@@ -1144,11 +1144,13 @@ config SMP
 	bool "Symmetric Multi-Processing (EXPERIMENTAL)"
 	depends on EXPERIMENTAL && (REALVIEW_EB_ARM11MP || REALVIEW_EB_A9MP ||\
 		 MACH_REALVIEW_PB11MP || MACH_REALVIEW_PBX || ARCH_OMAP4 ||\
-		 ARCH_S5PV310 || ARCH_TEGRA || ARCH_U8500 || ARCH_VEXPRESS_CA9X4)
+		 ARCH_S5PV310 || ARCH_SPEAR13XX || ARCH_TEGRA || ARCH_U8500 ||\
+		 ARCH_VEXPRESS_CA9X4)

can we get rid of such long list by introducing a HAVE somthing etc....

I tried to do this, but have some doubts. With this change architectures can not disable features selected using select statement. So, if i want image without SMP for SPEAr13xx now, i can't do it.

Please correct me if this is not the right way of doing it.

regards,
viresh.
--------------------------------------

[PATCH] arch/arm/Kconfig: removing arch/machine dependencies from SMP, LOCAL_TIMERS, HAVE_ARM_SCU AND HAVE_ARM_TWD

Individual architectures/machines should select SMP, LOCAL_TIMERS, HAVE_ARM_SCU AND HAVE_ARM_TWD from there config options

From: Shiraz Hashim <[email protected]>

Quoted 1 line · Viresh KUMAR

From: Shiraz Hashim <[email protected]>

This defconfig is too large and verbose to go anywhere near mainline, even temporarily. You need to talk to Uwe about how to shrink it down.