i915: revert some checks added by commit 32aad86f
Subsystems (2)
PATCH 1/1 i915: revert some checks added by commit 32aad86f
This fixes blur-like screen corruption on the following card:
VGA compatible controller [0300]: Intel Corporation 82G33/G31 Express Integrated Graphics Controller [8086:29c2] (rev 10)
intel_sdvo_mode_set() should not return prematurely just because some features are not supported.
https://bugzilla.kernel.org/show_bug.cgi?id=17151
Signed-off-by Pavel Roskin <[email protected]>
Reported-by Jonathan Corbet <[email protected]>
Reviewed-by Chris Wilson <[email protected]>
--- drivers/gpu/drm/i915/intel_sdvo.c | 13 +++++-------- 1 files changed, 5 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/intel_sdvo.c +5 -8
@@ -1108,10 +1108,9 @@ static void intel_sdvo_mode_set(struct drm_encoder *encoder, in_out.in0 = intel_sdvo->attached_output; in_out.in1 =0 ; -if (!intel_sdvo_set_value (intel_sdvo, -SDVO_CMD_SET_IN_OUT_MAP , - &in_out,sizeof (in_out))) -return ; +intel_sdvo_set_value (intel_sdvo, +SDVO_CMD_SET_IN_OUT_MAP , + &in_out,sizeof (in_out));if (intel_sdvo->is_hdmi) {if (!intel_sdvo_set_avi_infoframe (intel_sdvo, mode))
@@ -1137,8 +1136,7 @@ static void intel_sdvo_mode_set(struct drm_encoder *encoder, intel_sdvo->attached_output))return ; -if (!intel_sdvo_set_output_timing (intel_sdvo, &input_dtd)) -return ; +intel_sdvo_set_output_timing (intel_sdvo, &input_dtd); }/* Set the input timing to the screen. Assume always input 0. */
@@ -1165,8 +1163,7 @@ static void intel_sdvo_mode_set(struct drm_encoder *encoder, intel_sdvo_set_input_timing(encoder, &input_dtd); }#else -if (!intel_sdvo_set_input_timing (intel_sdvo, &input_dtd)) -return ; +intel_sdvo_set_input_timing (intel_sdvo, &input_dtd);#endif sdvo_pixel_multiply =intel_sdvo_get_pixel_multiplier (mode);
Quoted 4 lines · On Thu, 02 Sep 2010 14:46:34 -0400 Pavel Roskin <[email protected]> wrote:
This fixes blur-like screen corruption on the following card:
VGA compatible controller [0300]: Intel Corporation 82G33/G31 Express Integrated Graphics Controller [8086:29c2] (rev 10)
Now that I'm back on the same continent as my desktop system, I can verify that it fixes things there too. That makes me happy - thanks!
jon