Skip to contentSkip to conversation

avoid warning when COMPACTION is selected

PATCH In review Andrea Arcangeli 3 participants 4 messages Sep 3, 2010 – Sep 6, 2010

Subsystems (2)
Memory management MM core
lore
Share & tools
lore

Andrea Arcangeli

author
#0 lore raw

PATCH 1/1 avoid warning when COMPACTION is selected

From: Andrea Arcangeli <[email protected]>

COMPACTION enables MIGRATION, but MIGRATION spawns a warning if numa or memhotplug aren't selected. However MIGRATION doesn't depend on them. I guess it's just trying to be strict doing a double check on who's enabling it, but it doesn't know that compaction also enables MIGRATION.

Signed-off-by Andrea Arcangeli <[email protected]>

---

mm/Kconfig +1 -1
@@ -189,7 +189,7 @@ config COMPACTION
 config MIGRATION
 	bool "Page migration"
 	def_bool y
-	depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE
+	depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION
 	help
 	  Allows the migration of the physical location of pages of processes
 	  while the virtual addresses are not changed. This is useful in

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

maintainer
#1 lore raw
Quoted 15 lines · On Fri, 3 Sep 2010 17:38:26 +0200 Andrea Arcangeli <[email protected]> wrote:

From: Andrea Arcangeli <[email protected]>

COMPACTION enables MIGRATION, but MIGRATION spawns a warning if numa or memhotplug aren't selected. However MIGRATION doesn't depend on them. I guess it's just trying to be strict doing a double check on who's enabling it, but it doesn't know that compaction also enables MIGRATION.

Signed-off-by Andrea Arcangeli <[email protected]>

---

mm/Kconfig config COMPACTION · line 195

Quoted 8 lines
mm/Kconfig +1 -1
@@ -189,7 +189,7 @@ config COMPACTION
 config MIGRATION
 	bool "Page migration"
 	def_bool y
-	depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE
+	depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION
 	help
 	  Allows the migration of the physical location of pages of processes
 	  while the virtual addresses are not changed. This is useful in

Could you please send along a copy of the warning? It's unclear whether it's a compiler warning or a Kconfig warning or a runtime warning or what.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

author
#2 lore raw
Quoted 1 line · Andrew Morton

Could you please send along a copy of the warning? It's unclear

Sure.

Quoted 2 lines

whether it's a compiler warning or a Kconfig warning or a runtime warning or what.

Kconfig warning.

scripts/kconfig/conf --oldconfig arch/x86/Kconfig
warning: (COMPACTION && EXPERIMENTAL && HUGETLB_PAGE && MMU) selects MIGRATION which has unmet direct dependencies (NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE)
warning: (COMPACTION && EXPERIMENTAL && HUGETLB_PAGE && MMU) selects MIGRATION which has unmet direct dependencies (NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE) #

# configuration written to .config
#

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Acked-by on v1 1/1
#3 lore raw
In reply to Andrea Arcangeli
Quoted 9 lines · Andrea Arcangeli

From: Andrea Arcangeli <[email protected]>

COMPACTION enables MIGRATION, but MIGRATION spawns a warning if numa or memhotplug aren't selected. However MIGRATION doesn't depend on them. I guess it's just trying to be strict doing a double check on who's enabling it, but it doesn't know that compaction also enables MIGRATION.

Signed-off-by Andrea Arcangeli <[email protected]>
Acked-by Mel Gorman <[email protected]>

This was the way an earlier version of compaction had Kconfig. I'm not sure at what point the "|| COMPACTION" got dropped.

Quoted 15 lines

---

mm/Kconfig +1 -1
@@ -189,7 +189,7 @@ config COMPACTION
 config MIGRATION
 	bool "Page migration"
 	def_bool y
-	depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE
+	depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION
 	help
 	  Allows the migration of the physical location of pages of processes
 	  while the virtual addresses are not changed. This is useful in
Signature · 9 lines
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>