isdn: cleanup: make buffer smaller

PATCH Applied Dan Carpenter 2 participants 2 messages Sep 4, 2010 – Sep 7, 2010

Subsystems (3)

Networking Network drivers Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-09-04 18:33 UTC #0 lore raw

PATCH 1/1 isdn: cleanup: make buffer smaller

This showed up in my audit because we use strcpy() to copy "ds" into a 32 character buffer inside the isdn_tty_dial() function. But it turns out that we only ever use the first 32 characters so it's OK. I have changed the declaration to make the static checkers happy.

Signed-off-by Dan Carpenter <[email protected]>

drivers/isdn/i4l/isdn_tty.c +2 -2

index 51dc60d..f013ee1 100644
@@ -3515,7 +3515,7 @@ isdn_tty_parse_at(modem_info * info)
 {
 	atemu *m = &info->emu;
 	char *p;
-	char ds[40];
+	char ds[ISDN_MSNLEN];
 
 #ifdef ISDN_DEBUG_AT
 	printk(KERN_DEBUG "AT: '%s'\n", m->mdmcmd);

@@ -3594,7 +3594,7 @@ isdn_tty_parse_at(modem_info * info)
 						break;
 					case '3':
                                                 p++;
-                                                sprintf(ds, "\r\n%d", info->emu.charge);
+                                                snprintf(ds, sizeof(ds), "\r\n%d", info->emu.charge);
                                                 isdn_tty_at_cout(ds, info);
                                                 break;
 					default:;

David Miller

maintainer Applied

2010-09-07 01:30 UTC #1 lore raw

From: Dan Carpenter <[email protected]>
Date: Sat, 4 Sep 2010 20:33:03 +0200

Quoted 6 lines

This showed up in my audit because we use strcpy() to copy "ds" into a 32 character buffer inside the isdn_tty_dial() function. But it turns out that we only ever use the first 32 characters so it's OK. I have changed the declaration to make the static checkers happy.
Signed-off-by Dan Carpenter <[email protected]>

Applied.