Skip to contentSkip to conversation

ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

PATCH New Marek Vasut 3 participants 12 messages Sep 3, 2010 – Sep 5, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

In case the pxa3xx-u2d driver isn't used, probing of ohci-pxa27x will cause an ugly kernel crash (NULL pointer dereference in pxa3xx_u2d_start_hc(), because struct u2d is NULL and clk_enable() call will crash the kernel, trying to access it).

---
 arch/arm/mach-pxa/pxa3xx-ulpi.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/arm/mach-pxa/pxa3xx-ulpi.c +8 -0
index e57439e..ce7168b 100644
@@ -252,6 +252,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 {
 	int err = 0;
 
+	/* In case the PXA3xx ULPI isn't used, do nothing. */
+	if (!u2d)
+		return 0;
+
 	clk_enable(u2d->clk);
 
 	if (cpu_is_pxa310()) {
@@ -264,6 +268,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 
 void pxa3xx_u2d_stop_hc(struct usb_bus *host)
 {
+	/* In case the PXA3xx ULPI isn't used, do nothing. */
+	if (!u2d)
+		return;
+
 	if (cpu_is_pxa310())
 		pxa310_stop_otg_hc();
 
Signature · 1 line
1.7.1
Applied
#1 lore raw

PATCH 1/1 ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

Quoted 6 lines · Marek Vasut

In case the pxa3xx-u2d driver isn't used, probing of ohci-pxa27x will cause an ugly kernel crash (NULL pointer dereference in pxa3xx_u2d_start_hc(), because struct u2d is NULL and clk_enable() call will crash the kernel, trying to access it).

Applied to 'devel'.

Quoted 34 lines

---
?arch/arm/mach-pxa/pxa3xx-ulpi.c | ? ?8 ++++++++
?1 files changed, 8 insertions(+), 0 deletions(-)

arch/arm/mach-pxa/pxa3xx-ulpi.c +8 -1
index e57439e..ce7168b 100644
@@ -252,6 +252,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 ?{
 ? ? ? ?int err = 0;
 
+ ? ? ? /* In case the PXA3xx ULPI isn't used, do nothing. */
+ ? ? ? if (!u2d)
+ ? ? ? ? ? ? ? return 0;
+
 ? ? ? ?clk_enable(u2d->clk);
 
 ? ? ? ?if (cpu_is_pxa310()) {
@@ -264,6 +268,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 
 ?void pxa3xx_u2d_stop_hc(struct usb_bus *host)
 ?{
+ ? ? ? /* In case the PXA3xx ULPI isn't used, do nothing. */
+ ? ? ? if (!u2d)
+ ? ? ? ? ? ? ? return;
+
 ? ? ? ?if (cpu_is_pxa310())
 ? ? ? ? ? ? ? ?pxa310_stop_otg_hc();
 
--

1.7.1

#2 lore raw

PATCH 1/1 ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

In reply to Marek Vasut
Quoted 4 lines · Marek Vasut

In case the pxa3xx-u2d driver isn't used, probing of ohci-pxa27x will cause an ugly kernel crash (NULL pointer dereference in pxa3xx_u2d_start_hc(), because struct u2d is NULL and clk_enable() call will crash the kernel, trying to access it).

ohci code checks for pxa3xx cpu and only then runs start/stop hc. pxa3xx_ulpi.c is compiled if CONFIG_PXA3xx is selected.
The device <-> driver binding should not be a problem, so the pxa3xx_u2d_probe() will run.
The only case, I see, when struct u2d does not exist is failure of the probe function. If this is the case, we are having an abnormal execution and if your patch is dealing with this issue, shouldn't you comment it as such?

Quoted 31 lines
---
 arch/arm/mach-pxa/pxa3xx-ulpi.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/arm/mach-pxa/pxa3xx-ulpi.c +8 -0
index e57439e..ce7168b 100644
@@ -252,6 +252,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 {
 	int err = 0;
 
+	/* In case the PXA3xx ULPI isn't used, do nothing. */
+	if (!u2d)
+		return 0;
+
 	clk_enable(u2d->clk);
 
 	if (cpu_is_pxa310()) {
@@ -264,6 +268,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 
 void pxa3xx_u2d_stop_hc(struct usb_bus *host)
 {
+	/* In case the PXA3xx ULPI isn't used, do nothing. */
+	if (!u2d)
+		return;
+
 	if (cpu_is_pxa310())
 		pxa310_stop_otg_hc();
 
Signature · 2 lines
Regards,
Igor.
#3 lore raw

PATCH 1/1 ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

Dne Ne 5. z??? 2010 09:54:31 Igor Grinberg napsal(a):

Quoted 7 lines · Marek Vasut
Quoted 4 lines

In case the pxa3xx-u2d driver isn't used, probing of ohci-pxa27x will cause an ugly kernel crash (NULL pointer dereference in pxa3xx_u2d_start_hc(), because struct u2d is NULL and clk_enable() call will crash the kernel, trying to access it).

ohci code checks for pxa3xx cpu and only then runs start/stop hc.

Exactly ... and in case "struct pxa3xx_u2d_ulpi *u2d" is NULL, clk_enable will crash the kernel.

Quoted 7 lines

pxa3xx_ulpi.c is compiled if CONFIG_PXA3xx is selected.
The device <-> driver binding should not be a problem, so the pxa3xx_u2d_probe() will run.
The only case, I see, when struct u2d does not exist is failure of the probe function. If this is the case, we are having an abnormal execution and if your patch is dealing with this issue, shouldn't you comment it as such?

Not at all ... if the pxa3xx-u2d driver isn't loaded at all, the function (start/stop hc) is still called, but struct pxa3xx_u2d_ulpi *u2d is NULL. In this case, if you call clk_enable(u2d->clk), you crash the kernel (because u2d is NULL).

Good night, I'll be back in 8 hrs or so :)

Quoted 39 lines
Quoted 39 lines

---

 arch/arm/mach-pxa/pxa3xx-ulpi.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-pxa/pxa3xx-ulpi.c index e57439e..ce7168b 100644

arch/arm/mach-pxa/pxa3xx-ulpi.c +4 -0
@@ -252,6 +252,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 
 {
 
 	int err = 0;
 
+	/* In case the PXA3xx ULPI isn't used, do nothing. */
+	if (!u2d)
+		return 0;
+
 
arch/arm/mach-pxa/pxa3xx-ulpi.c +4 -0
 	clk_enable(u2d->clk);
 
 	if (cpu_is_pxa310()) {
@@ -264,6 +268,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 
 void pxa3xx_u2d_stop_hc(struct usb_bus *host)
 {
 
+	/* In case the PXA3xx ULPI isn't used, do nothing. */
+	if (!u2d)
+		return;
+
 
 	if (cpu_is_pxa310())

pxa310_stop_otg_hc();

#4 lore raw

PATCH 1/1 ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

Quoted 17 lines · Marek Vasut

Dne Ne 5. z??? 2010 09:54:31 Igor Grinberg napsal(a):

Quoted 6 lines · Marek Vasut
Quoted 4 lines

In case the pxa3xx-u2d driver isn't used, probing of ohci-pxa27x will cause an ugly kernel crash (NULL pointer dereference in pxa3xx_u2d_start_hc(), because struct u2d is NULL and clk_enable() call will crash the kernel, trying to access it).

ohci code checks for pxa3xx cpu and only then runs start/stop hc.

Exactly ... and in case "struct pxa3xx_u2d_ulpi *u2d" is NULL, clk_enable will crash the kernel.

Quoted 7 lines

pxa3xx_ulpi.c is compiled if CONFIG_PXA3xx is selected.
The device <-> driver binding should not be a problem, so the pxa3xx_u2d_probe() will run.
The only case, I see, when struct u2d does not exist is failure of the probe function. If this is the case, we are having an abnormal execution and if your patch is dealing with this issue, shouldn't you comment it as such?

Quoted 4 lines

Not at all ... if the pxa3xx-u2d driver isn't loaded at all, the function (start/stop hc) is still called, but struct pxa3xx_u2d_ulpi *u2d is NULL. In this case, if you call clk_enable(u2d->clk), you crash the kernel (because u2d is NULL).

How, can it happen, that "pxa3xx-u2d driver isn't loaded at all"? This can happen only if you rip out the device registration or hack a Makefile. I don't see any other way... is there?

Quoted 40 lines

Good night, I'll be back in 8 hrs or so :)

Quoted 38 lines
Quoted 38 lines

---

 arch/arm/mach-pxa/pxa3xx-ulpi.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-pxa/pxa3xx-ulpi.c index e57439e..ce7168b 100644

arch/arm/mach-pxa/pxa3xx-ulpi.c +4 -0
@@ -252,6 +252,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 
 {
 
 	int err = 0;
 
+	/* In case the PXA3xx ULPI isn't used, do nothing. */
+	if (!u2d)
+		return 0;
+
 
arch/arm/mach-pxa/pxa3xx-ulpi.c +4 -0
 	clk_enable(u2d->clk);
 
 	if (cpu_is_pxa310()) {
@@ -264,6 +268,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 
 void pxa3xx_u2d_stop_hc(struct usb_bus *host)
 {
 
+	/* In case the PXA3xx ULPI isn't used, do nothing. */
+	if (!u2d)
+		return;
+
 
 	if (cpu_is_pxa310())

pxa310_stop_otg_hc();

Signature · 2 lines
Regards,
Igor.
#5 lore raw

PATCH 1/1 ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

Dne Ne 5. z??? 2010 10:16:48 Igor Grinberg napsal(a):

Quoted 21 lines · Marek Vasut
Quoted 20 lines

Dne Ne 5. z??? 2010 09:54:31 Igor Grinberg napsal(a):

Quoted 7 lines · Marek Vasut
Quoted 4 lines

In case the pxa3xx-u2d driver isn't used, probing of ohci-pxa27x will cause an ugly kernel crash (NULL pointer dereference in pxa3xx_u2d_start_hc(), because struct u2d is NULL and clk_enable() call will crash the kernel, trying to access it).

ohci code checks for pxa3xx cpu and only then runs start/stop hc.

Exactly ... and in case "struct pxa3xx_u2d_ulpi *u2d" is NULL, clk_enable will crash the kernel.

Quoted 7 lines

pxa3xx_ulpi.c is compiled if CONFIG_PXA3xx is selected.
The device <-> driver binding should not be a problem, so the pxa3xx_u2d_probe() will run.
The only case, I see, when struct u2d does not exist is failure of the probe function. If this is the case, we are having an abnormal execution and if your patch is dealing with this issue, shouldn't you comment it as such?

Quoted 8 lines
Quoted 4 lines

Not at all ... if the pxa3xx-u2d driver isn't loaded at all, the function (start/stop hc) is still called, but struct pxa3xx_u2d_ulpi *u2d is NULL. In this case, if you call clk_enable(u2d->clk), you crash the kernel (because u2d is NULL).

How, can it happen, that "pxa3xx-u2d driver isn't loaded at all"? This can happen only if you rip out the device registration or hack a Makefile. I don't see any other way... is there?

If you don't call pxa3xx_set_u2d_info() ?

Quoted 41 lines
Quoted 41 lines

Good night, I'll be back in 8 hrs or so :)

Quoted 38 lines
Quoted 38 lines

---

 arch/arm/mach-pxa/pxa3xx-ulpi.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-pxa/pxa3xx-ulpi.c index e57439e..ce7168b 100644

arch/arm/mach-pxa/pxa3xx-ulpi.c +4 -0
@@ -252,6 +252,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 
 {
 
 	int err = 0;
 
+	/* In case the PXA3xx ULPI isn't used, do nothing. */
+	if (!u2d)
+		return 0;
+
 
arch/arm/mach-pxa/pxa3xx-ulpi.c +4 -0
 	clk_enable(u2d->clk);
 
 	if (cpu_is_pxa310()) {
@@ -264,6 +268,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 
 void pxa3xx_u2d_stop_hc(struct usb_bus *host)
 {
 
+	/* In case the PXA3xx ULPI isn't used, do nothing. */
+	if (!u2d)
+		return;
+
 
 	if (cpu_is_pxa310())

pxa310_stop_otg_hc();

#6 lore raw

PATCH 1/1 ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

Quoted 19 lines · Marek Vasut

Dne Ne 5. z??? 2010 10:16:48 Igor Grinberg napsal(a):

Quoted 18 lines · Marek Vasut
Quoted 17 lines

Dne Ne 5. z??? 2010 09:54:31 Igor Grinberg napsal(a):

Quoted 6 lines · Marek Vasut
Quoted 4 lines

In case the pxa3xx-u2d driver isn't used, probing of ohci-pxa27x will cause an ugly kernel crash (NULL pointer dereference in pxa3xx_u2d_start_hc(), because struct u2d is NULL and clk_enable() call will crash the kernel, trying to access it).

ohci code checks for pxa3xx cpu and only then runs start/stop hc.

Exactly ... and in case "struct pxa3xx_u2d_ulpi *u2d" is NULL, clk_enable will crash the kernel.

Quoted 7 lines

pxa3xx_ulpi.c is compiled if CONFIG_PXA3xx is selected.
The device <-> driver binding should not be a problem, so the pxa3xx_u2d_probe() will run.
The only case, I see, when struct u2d does not exist is failure of the probe function. If this is the case, we are having an abnormal execution and if your patch is dealing with this issue, shouldn't you comment it as such?

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines

Not at all ... if the pxa3xx-u2d driver isn't loaded at all, the function (start/stop hc) is still called, but struct pxa3xx_u2d_ulpi *u2d is NULL. In this case, if you call clk_enable(u2d->clk), you crash the kernel (because u2d is NULL).

How, can it happen, that "pxa3xx-u2d driver isn't loaded at all"? This can happen only if you rip out the device registration or hack a Makefile. I don't see any other way... is there?

If you don't call pxa3xx_set_u2d_info() ?

Oh... right.
I've added it this way, so boards can control u2d existence and forgot it is there... Buggy me... :(

Thanks.

Quoted 1 line
Quoted 1 line
Quoted 1 line

Good night, I'll be back in 8 hrs or so :)

Good night indeed :)

Quoted 38 lines
Quoted 38 lines
Quoted 38 lines
Quoted 38 lines
Quoted 38 lines

---

 arch/arm/mach-pxa/pxa3xx-ulpi.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-pxa/pxa3xx-ulpi.c index e57439e..ce7168b 100644

arch/arm/mach-pxa/pxa3xx-ulpi.c +4 -0
@@ -252,6 +252,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 
 {
 
 	int err = 0;
 
+	/* In case the PXA3xx ULPI isn't used, do nothing. */
+	if (!u2d)
+		return 0;
+
 
arch/arm/mach-pxa/pxa3xx-ulpi.c +4 -0
 	clk_enable(u2d->clk);
 
 	if (cpu_is_pxa310()) {
@@ -264,6 +268,10 @@ int pxa3xx_u2d_start_hc(struct usb_bus *host)
 
 void pxa3xx_u2d_stop_hc(struct usb_bus *host)
 {
 
+	/* In case the PXA3xx ULPI isn't used, do nothing. */
+	if (!u2d)
+		return;
+
 
 	if (cpu_is_pxa310())

pxa310_stop_otg_hc();

Signature · 2 lines
Regards,
Igor.
#7 lore raw

PATCH 1/1 ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

Quoted 24 lines · Igor Grinberg
Quoted 23 lines · Marek Vasut

Dne Ne 5. z??? 2010 10:16:48 Igor Grinberg napsal(a):

Quoted 22 lines
Quoted 21 lines · Marek Vasut

Dne Ne 5. z??? 2010 09:54:31 Igor Grinberg napsal(a):

Quoted 6 lines
Quoted 4 lines · Marek Vasut

In case the pxa3xx-u2d driver isn't used, probing of ohci-pxa27x will cause an ugly kernel crash (NULL pointer dereference in pxa3xx_u2d_start_hc(), because struct u2d is NULL and clk_enable() call will crash the kernel, trying to access it).

ohci code checks for pxa3xx cpu and only then runs start/stop hc.

Exactly ... and in case "struct pxa3xx_u2d_ulpi *u2d" is NULL, clk_enable will crash the kernel.

Quoted 7 lines

pxa3xx_ulpi.c is compiled if CONFIG_PXA3xx is selected.
The device <-> driver binding should not be a problem, so the pxa3xx_u2d_probe() will run.
The only case, I see, when struct u2d does not exist is failure of the probe function. If this is the case, we are having an abnormal execution and if your patch is dealing with this issue, shouldn't you comment it as such?

Not at all ... if the pxa3xx-u2d driver isn't loaded at all, the function (start/stop hc) is still called, but struct pxa3xx_u2d_ulpi *u2d is NULL. In this case, if you call clk_enable(u2d->clk), you crash the kernel (because u2d is NULL).

Quoted 9 lines
Quoted 4 lines
Quoted 3 lines

How, can it happen, that "pxa3xx-u2d driver isn't loaded at all"? This can happen only if you rip out the device registration or hack a Makefile. I don't see any other way... is there?

If you don't call pxa3xx_set_u2d_info() ?

Oh... right.
I've added it this way, so boards can control u2d existence and forgot it is there... Buggy me... :(

Igor,

So do you this as a proper fix, or there is better way out?

#8 lore raw

PATCH 1/1 ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

Quoted 28 lines · Eric Miao
Quoted 27 lines · Igor Grinberg
Quoted 26 lines · Marek Vasut

Dne Ne 5. z??? 2010 10:16:48 Igor Grinberg napsal(a):

Quoted 25 lines · Marek Vasut
Quoted 17 lines

Dne Ne 5. z??? 2010 09:54:31 Igor Grinberg napsal(a):

Quoted 6 lines · Marek Vasut
Quoted 4 lines

In case the pxa3xx-u2d driver isn't used, probing of ohci-pxa27x will cause an ugly kernel crash (NULL pointer dereference in pxa3xx_u2d_start_hc(), because struct u2d is NULL and clk_enable() call will crash the kernel, trying to access it).

ohci code checks for pxa3xx cpu and only then runs start/stop hc.

Exactly ... and in case "struct pxa3xx_u2d_ulpi *u2d" is NULL, clk_enable will crash the kernel.

Quoted 7 lines

pxa3xx_ulpi.c is compiled if CONFIG_PXA3xx is selected.
The device <-> driver binding should not be a problem, so the pxa3xx_u2d_probe() will run.
The only case, I see, when struct u2d does not exist is failure of the probe function. If this is the case, we are having an abnormal execution and if your patch is dealing with this issue, shouldn't you comment it as such?

Quoted 4 lines

Not at all ... if the pxa3xx-u2d driver isn't loaded at all, the function (start/stop hc) is still called, but struct pxa3xx_u2d_ulpi *u2d is NULL. In this case, if you call clk_enable(u2d->clk), you crash the kernel (because u2d is NULL).

How, can it happen, that "pxa3xx-u2d driver isn't loaded at all"? This can happen only if you rip out the device registration or hack a Makefile. I don't see any other way... is there?

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

If you don't call pxa3xx_set_u2d_info() ?

Oh... right.
I've added it this way, so boards can control u2d existence and forgot it is there... Buggy me... :(

Igor,

So do you this as a proper fix, or there is better way out?

If we want to keep it the most straight-forward way so it is fine.

Another possible ways would be:

1) create a new flag, lets say PORT2_USE_U2DC in pxaohci_platform_data. This is a relatively clean way of making ohci aware of
u2d existence at runtime and eliminates the calls to functions of non-existing (not loaded) driver...

2) use something like:

struct u2d_hc_ops {
    int (*start_hc)(...);
    void (*stop_hc)(...);
}

in board init code register the ops structure via the pxa_ohci platform data.

This way adds some more pollution to the pxa_ohci glue with code relevant only to pxa3xx, achieving the same as the 1st way, but also can be useful for u2dc otg/peripheral driver (if it will come some day...).

I'm fine with both (Marek's patch or my proposal), so tell me what looks better to you.

Signature · 2 lines
Regards,
Igor.
#9 lore raw

PATCH 1/1 ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

Quoted 53 lines · Igor Grinberg
Quoted 28 lines · Eric Miao
Quoted 27 lines · Igor Grinberg
Quoted 26 lines · Marek Vasut

Dne Ne 5. z??? 2010 10:16:48 Igor Grinberg napsal(a):

Quoted 25 lines
Quoted 17 lines · Marek Vasut

Dne Ne 5. z??? 2010 09:54:31 Igor Grinberg napsal(a):

Quoted 6 lines
Quoted 4 lines · Marek Vasut

In case the pxa3xx-u2d driver isn't used, probing of ohci-pxa27x will cause an ugly kernel crash (NULL pointer dereference in pxa3xx_u2d_start_hc(), because struct u2d is NULL and clk_enable() call will crash the kernel, trying to access it).

ohci code checks for pxa3xx cpu and only then runs start/stop hc.

Exactly ... and in case "struct pxa3xx_u2d_ulpi *u2d" is NULL, clk_enable will crash the kernel.

Quoted 7 lines

pxa3xx_ulpi.c is compiled if CONFIG_PXA3xx is selected.
The device <-> driver binding should not be a problem, so the pxa3xx_u2d_probe() will run.
The only case, I see, when struct u2d does not exist is failure of the probe function. If this is the case, we are having an abnormal execution and if your patch is dealing with this issue, shouldn't you comment it as such?

Quoted 4 lines

Not at all ... if the pxa3xx-u2d driver isn't loaded at all, the function (start/stop hc) is still called, but struct pxa3xx_u2d_ulpi *u2d is NULL. In this case, if you call clk_enable(u2d->clk), you crash the kernel (because u2d is NULL).

How, can it happen, that "pxa3xx-u2d driver isn't loaded at all"? This can happen only if you rip out the device registration or hack a Makefile. I don't see any other way... is there?

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

If you don't call pxa3xx_set_u2d_info() ?

Oh... right.
I've added it this way, so boards can control u2d existence and forgot it is there... Buggy me... :(

Igor,

So do you this as a proper fix, or there is better way out?

If we want to keep it the most straight-forward way so it is fine.

Another possible ways would be:

1) create a new flag, lets say PORT2_USE_U2DC in pxaohci_platform_data. This is a relatively clean way of making ohci aware of
u2d existence at runtime and eliminates the calls to functions of non-existing (not loaded) driver...

2) use something like:
struct u2d_hc_ops {
? ?int (*start_hc)(...);
? ?void (*stop_hc)(...);
}

Quoted 9 lines

in board init code register the ops structure via the pxa_ohci platform data.

This way adds some more pollution to the pxa_ohci glue with code relevant only to pxa3xx, achieving the same as the 1st way, but also can be useful for u2dc otg/peripheral driver (if it will come some day...).

I'm fine with both (Marek's patch or my proposal), so tell me what looks better to you.

That sounds to be a cleaner way, but may require more changes. What if we get this patch into -rc phase as is first, and get a cleaner patch for -next?

Quoted 5 lines

--
Regards,
Igor.

#10 lore raw

PATCH 1/1 ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

Quoted 27 lines · Eric Miao
Quoted 26 lines · Igor Grinberg
Quoted 4 lines · Eric Miao

On Sun, Sep 5, 2010 at 4:35 PM, Igor Grinberg <[email protected]> wrote:
Igor,

So do you this as a proper fix, or there is better way out?

If we want to keep it the most straight-forward way so it is fine.

Another possible ways would be:

1) create a new flag, lets say PORT2_USE_U2DC in pxaohci_platform_data. This is a relatively clean way of making ohci aware of
u2d existence at runtime and eliminates the calls to functions of non-existing (not loaded) driver...

2) use something like:

struct u2d_hc_ops {
   int (*start_hc)(...);
   void (*stop_hc)(...);
}

in board init code register the ops structure via the pxa_ohci platform data.

This way adds some more pollution to the pxa_ohci glue with code relevant only to pxa3xx, achieving the same as the 1st way, but also can be useful for u2dc otg/peripheral driver (if it will come some day...).

Quoted 6 lines
Quoted 3 lines

I'm fine with both (Marek's patch or my proposal), so tell me what looks better to you.

That sounds to be a cleaner way, but may require more changes. What if we get this patch into -rc phase as is first, and get a cleaner patch for -next?

Fine with me.

Signature · 2 lines
Regards,
Igor.
#11 lore raw

PATCH 1/1 ARM: pxa: Fix pxa3xx-u2d crash when ULPI not used

Dne Ne 5. z??? 2010 16:31:53 Igor Grinberg napsal(a):

Quoted 2 lines · Eric Miao
Quoted 1 line

On Sun, Sep 5, 2010 at 9:46 PM, Igor Grinberg <[email protected]>

Quoted 31 lines · wrote:
Quoted 31 lines
Quoted 31 lines · Eric Miao
Quoted 4 lines

On Sun, Sep 5, 2010 at 4:35 PM, Igor Grinberg <[email protected]>
wrote: Igor,

So do you this as a proper fix, or there is better way out?

If we want to keep it the most straight-forward way so it is fine.

Another possible ways would be:

1) create a new flag, lets say PORT2_USE_U2DC in pxaohci_platform_data. This is a relatively clean way of making ohci aware of
u2d existence at runtime and eliminates the calls to functions of non-existing (not loaded) driver...

2) use something like:
struct u2d_hc_ops {

   int (*start_hc)(...);
   void (*stop_hc)(...);

}

in board init code register the ops structure via the pxa_ohci platform data.

This way adds some more pollution to the pxa_ohci glue with code relevant only to pxa3xx, achieving the same as the 1st way, but also can be useful for u2dc otg/peripheral driver (if it will come some day...).

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

I'm fine with both (Marek's patch or my proposal), so tell me what looks better to you.

That sounds to be a cleaner way, but may require more changes. What if we get this patch into -rc phase as is first, and get a cleaner patch for -next?

Fine with me.

Morning (even if it's 9pm here).

I'd be for solution #2 as well. I might eventually look into it, but now it's really impossible for me. Just two more weeks until I'll be able to activelly participate on kernel development again.

Cheers