Skip to contentSkip to conversation

ath5k calibration error

PATCH In review Fabio Rossi 2 participants 4 messages Sep 6, 2010 – Sep 9, 2010 Atheros ATH5K wireless driver

lore
Share & tools
lore
#0 lore raw

In the patch 9e04a7eb1fdf37bc8bc0d0f59e5fb737926f0152 there has been a change in the possible return values from ath5k_hw_rf511x_iq_calibrate().

Sometimes I get -1 (before that commit the return value was always 0) because i_coffd:0, q_coffd:0 and the following error message is produced:

ath5k phy0: calibration of channel 8 failed

Of course I'm running on channel 8.

Is this condition normal or something is weird? I have the following card:

3Com Corporation AR5212 802.11abg NIC (3CRDAG675) (rev 01)

Thanks,
Fabio

#1 lore raw
Quoted 8 lines · On Tue September 7 2010 08:10:11 Fabio Rossi wrote:

In the patch 9e04a7eb1fdf37bc8bc0d0f59e5fb737926f0152 there has been a change in the possible return values from ath5k_hw_rf511x_iq_calibrate().

Sometimes I get -1 (before that commit the return value was always 0) because i_coffd:0, q_coffd:0 and the following error message is produced:

ath5k phy0: calibration of channel 8 failed

Quoted 8 lines

Of course I'm running on channel 8.

Is this condition normal or something is weird? I have the following card:

3Com Corporation AR5212 802.11abg NIC (3CRDAG675) (rev 01)

Thanks,
Fabio

hmm, i guess i was wrong to introduce the -1 return value here, since this is not really an error condition...

sorry,
bruno

#2 lore raw

PATCH 1/1 ath5k: avoid unneeded calibration error messages

Don't generate calibration errors messages when not needed.

---

(quoted diff) +0 -0

b/drivers/net/wireless/ath/ath5k/phy.c
index 984ba92..4932bf2 100644

drivers/net/wireless/ath/ath5k/phy.c +1 -1
@@ -1377,7 +1377,7 @@ ath5k_hw_rf511x_iq_calibrate(struct ath5k_hw *ah)
 
        /* protect against divide by 0 and loss of sign bits */
        if (i_coffd == 0 || q_coffd < 2)
-               return -1;
+               return 0;
 
        i_coff = (-iq_corr) / i_coffd;
        i_coff = clamp(i_coff, -32, 31); /* signed 6 bit */
Acked-by on v1 1/1
#3 lore raw

Re: [PATCH] ath5k: avoid unneeded calibration error messages

Quoted 10 lines · On Thu September 9 2010 05:37:41 Fabio Rossi wrote:

Don't generate calibration errors messages when not needed.

---

drivers/net/wireless/ath/ath5k/phy.c +0 -0
index 984ba92..4932bf2 100644

drivers/net/wireless/ath/ath5k/phy.c ath5k_hw_rf511x_iq_calibrate(struct ath5k_hw *ah) · line 1383

Quoted 8 lines
drivers/net/wireless/ath/ath5k/phy.c +1 -1
@@ -1377,7 +1377,7 @@ ath5k_hw_rf511x_iq_calibrate(struct ath5k_hw *ah)
 
        /* protect against divide by 0 and loss of sign bits */
        if (i_coffd == 0 || q_coffd < 2)
-               return -1;
+               return 0;
 
        i_coff = (-iq_corr) / i_coffd;
        i_coff = clamp(i_coff, -32, 31); /* signed 6 bit */