Remove incorrect do_vfs_lock message
Subsystems (2)
PATCH 1/1 Remove incorrect do_vfs_lock message
The do_vfs_lock function on fs/nfs/file.c is only called if NLM is not being used, via the -onolock mount option. Therefore it cannot really be "out of sync with lock manager" when the local locking function called returns an error, as there will be no corresponding call to the NLM. For details, simply check the if/else on do_setlk and do_unlk on fs/nfs/file.c.
fs/nfs/file.c +0 -4
@@ -723,10 +723,6 @@ static int do_vfs_lock(struct file *file, struct file_lock *fl)default :BUG (); } -if (res <0 ) -dprintk (KERN_WARNING "%s: VFS is out of sync with lock manager" -" - error %d!\n" , - __func__, res);return res; }
Please keep me copied as I don't subscribe to the list.
Regards,
Fábio Olivé
Signature · 2 lines
TcheLinux.org, OeSC-Livre.org, Chapecó, SC ex sed lex awk yacc, e pluribus unix, amem
A message that is not in the archive (sent off-list or not yet received): [email protected]
Looks right to me.
fs/nfs/file.c static int do_vfs_lock(struct file *file, struct=
Quoted 13 lines · Fabio Olive Leite
The
do_vfs_lockfunction onfs/nfs/file.cis only called if NLM is not being used, via the -onolock mount option. Therefore it cannot really be "out of sync with lock manager" when the local locking function called returns an error, as there will be no corresponding call to the NLM. For details, simply check the if/else ondo_setlkanddo_unlkonfs/nfs/file.c.
=20Signed-off-by Fabio Olive Leite <[email protected]>=20
fs/nfs/file.c +0
-0@@ -723,10 +723,6 @@ static int do_vfs_lock(struct file *file, struct=
file_lock *fl)
Quoted 12 lines
fs/nfs/file.c +0
-4default :BUG (); } -if (res <0 ) -dprintk (KERN_WARNING "%s: VFS is out of sync with lock manager" -" - error %d!\n" , - __func__, res);return res; }=20
=20
Please keep me copied as I don't subscribe to the list.
Quoted 8 lines
=20
Regards,
F=C3=A1bio Oliv=C3=A9
--=20
TcheLinux.org, OeSC-Livre.org, Chapec=C3=B3, SC
ex sed lex awk yacc, e pluribus unix, amem
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" =
in
Quoted 2 lines
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jeff Layton
Reviewed-byfs/nfs/file.c static int do_vfs_lock(struct file *file, struct=
Quoted 13 lines · On Tue, 7 Sep 2010 02:56:01 -0300 =46abio Olive Leite <[email protected]> wrote:
The
do_vfs_lockfunction onfs/nfs/file.cis only called if NLM is not being used, via the -onolock mount option. Therefore it cannot really be "out of sync with lock manager" when the local locking function called returns an error, as there will be no corresponding call to the NLM. For details, simply check the if/else ondo_setlkanddo_unlkonfs/nfs/file.c.
=20Signed-off-by Fabio Olive Leite <[email protected]>=20
fs/nfs/file.c +0
-0@@ -723,10 +723,6 @@ static int do_vfs_lock(struct file *file, struct=
file_lock *fl)
Quoted 9 lines
fs/nfs/file.c +0
-4default :BUG (); } -if (res <0 ) -dprintk (KERN_WARNING "%s: VFS is out of sync with lock manager" -" - error %d!\n" , - __func__, res);return res; }
Quoted 6 lines
=20
=20
Please keep me copied as I don't subscribe to the list. =20
Regards,
F=E1bio Oliv=E9
A message that is not in the archive (sent off-list or not yet received): 20100907133854.1936b695-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org
Quoted 16 lines · Jeff Layton
On Tue, 7 Sep 2010 02:56:01 -0300
Fabio Olive Leite <[email protected]> wrote:
=20fs/nfs/file.c static int do_vfs_lock(struct file *file, stru=
Quoted 13 lines
The
do_vfs_lockfunction onfs/nfs/file.cis only called if NLM is not being used, via the -onolock mount option. Therefore it cannot really be "out of sync with lock manager" when the local locking function called returns an error, as there will be no corresponding call to the NLM. For details, simply check the if/else ondo_setlkanddo_unlkonfs/nfs/file.c.
=20Signed-off-by Fabio Olive Leite <[email protected]>=20
fs/nfs/file.c +0
-0@@ -723,10 +723,6 @@ static int do_vfs_lock(struct file *file, stru=
ct file_lock *fl)
Quoted 16 lines
Quoted 9 lines
fs/nfs/file.c +0
-4default :BUG (); } -if (res <0 ) -dprintk (KERN_WARNING "%s: VFS is out of sync with lock manager" -" - error %d!\n" , - __func__, res);return res; }Quoted 6 lines
=20
=20
Please keep me copied as I don't subscribe to the list. =20
Regards,
F=C3=A1bio Oliv=C3=A9=20
Quoted 1 line
Reviewed-by Jeff Layton <[email protected]>
Applied (after removing the ^M)...
Trond