Add basic support for FriendlyARM MINI6410 development board
Subsystems (2)
PATCH 1/1 Add basic support for FriendlyARM MINI6410 development board
This patch adds basic support for FriendlyARM MINI6410 development board (a Chinese clone of Samsung SMDK6410)
--- MAINTAINERS | 4 + MAKEALL | 1 + Makefile | 14 ++ board/samsung/mini6410/.gitignore | 5 + board/samsung/mini6410/Makefile | 57 +++++ board/samsung/mini6410/config.mk | 35 +++ board/samsung/mini6410/lowlevel_init.S | 310 ++++++++++++++++++++++++++++ board/samsung/mini6410/mini6410.c | 86 ++++++++ board/samsung/mini6410/u-boot-nand.lds | 62 ++++++ include/configs/mini6410.h | 296 ++++++++++++++++++++++++++ nand_spl/board/samsung/mini6410/Makefile | 112 ++++++++++ nand_spl/board/samsung/mini6410/config.mk | 41 ++++ nand_spl/board/samsung/mini6410/u-boot.lds | 61 ++++++ 13 files changed, 1084 insertions(+), 0 deletions(-) create mode 100644 board/samsung/mini6410/.gitignore create mode 100644 board/samsung/mini6410/Makefile create mode 100644 board/samsung/mini6410/config.mk create mode 100644 board/samsung/mini6410/lowlevel_init.S create mode 100644 board/samsung/mini6410/mini6410.c create mode 100644 board/samsung/mini6410/u-boot-nand.lds create mode 100644 include/configs/mini6410.h create mode 100644 nand_spl/board/samsung/mini6410/Makefile create mode 100644 nand_spl/board/samsung/mini6410/config.mk create mode 100644 nand_spl/board/samsung/mini6410/u-boot.lds
MAINTAINERS +4 -0
@@ -815,6 +815,10 @@ Alex Z lart SA1100 dnp1110 SA1110 +Alex Ling <[email protected]> + + MINI6410 ARM1176JZF-S (S3C6410) + ------------------------------------------------------------------------- Unknown / orphaned boards:
MAKEALL +1 -0
@@ -644,6 +644,7 @@ LIST_ARM11=" \ qong \ smdk6400 \ tnetv107x_evm \ + mini6410 \ " #########################################################################
Makefile +14 -0
@@ -2235,6 +2235,20 @@ smdk6400_config : unconfig @$(MKCONFIG) smdk6400 arm arm1176 smdk6400 samsung s3c64xx @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk +mini6410_noUSB_config \ +mini6410_config : unconfig + @mkdir -p $(obj)include $(obj)board/samsung/mini6410 + @mkdir -p $(obj)nand_spl/board/samsung/mini6410 + @echo "#define CONFIG_NAND_U_BOOT" > $(obj)include/config.h + @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk + @if [ -z "$(findstring mini6410_noUSB_config,$@)" ]; then \ + echo "RAM_TEXT = 0x57e00000" >> $(obj)board/samsung/mini6410/config.tmp;\ + else \ + echo "RAM_TEXT = 0xc7e00000" >> $(obj)board/samsung/mini6410/config.tmp;\ + fi + @$(MKCONFIG) mini6410 arm arm1176 mini6410 samsung s3c64xx + @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk + #======================================================================== # MIPS #========================================================================
board/samsung/mini6410/.gitignore new file +5 -0
@@ -0,0 +1,5 @@ +# +# Generated files +# + +/config.tmp
board/samsung/mini6410/Makefile new file +57 -0
57 lines not on this page · raw message
board/samsung/mini6410/config.mk new file +35 -0
@@ -0,0 +1,35 @@ +# +# (C) Copyright 2002 +# Gary Jennejohn, DENX Software Engineering, <[email protected]> +# David Mueller, ELSOFT AG, <[email protected]> +# +# (C) Copyright 2008 +# Guennadi Liakhovetki, DENX Software Engineering, <[email protected]> +# +# (C) Copyright 2010 +# Alex Ling, <[email protected]> +# +# FriendlyARM MINI6410 board with mDirac3 (ARM1176) cpu +# +# see http://www.samsung.com/ for more information on SAMSUNG + +# On MINI6410 we use the 128 MB SDRAM bank at +# +# 0x50000000 to 0x58000000 +# +# Linux-Kernel is expected to be at 0x50008000, entry 0x50008000 +# +# we load ourselves to 0x57e00000 without MMU +# with MMU, load address is changed to 0xc7e00000 +# +# download area is 0x5000c000 + +sinclude $(OBJTREE)/board/$(BOARDDIR)/config.tmp + +ifndef CONFIG_NAND_SPL +TEXT_BASE = $(RAM_TEXT) +else +TEXT_BASE = 0 +endif + +LDSCRIPT := $(SRCTREE)/board/$(BOARDDIR)/u-boot-nand.lds
board/samsung/mini6410/lowlevel_init.S new file +310 -0
310 lines not on this page · raw message
board/samsung/mini6410/mini6410.c new file +86 -0
86 lines not on this page · raw message
board/samsung/mini6410/u-boot-nand.lds new file +62 -0
62 lines not on this page · raw message
include/configs/mini6410.h new file +296 -0
296 lines not on this page · raw message
nand_spl/board/samsung/mini6410/Makefile new file +112 -0
112 lines not on this page · raw message
nand_spl/board/samsung/mini6410/config.mk new file +41 -0
41 lines not on this page · raw message
nand_spl/board/samsung/mini6410/u-boot.lds new file +61 -0
61 lines not on this page · raw message
Signature · 1 line
1.7.0.4
PATCH 1/1 Add basic support for FriendlyARM MINI6410 development board
Dear Alex Ling,
Quoted 1 line · In message <[email protected]> you wrote:
This patch adds basic support for FriendlyARM MINI6410 development board (a Chinese clone of Samsung SMDK6410)
Please restrict your line length to < 70 characters.
General note: please rebase your code on top of Heiko's ARm rework patches (enable caches, add relocation). These will go in before your board support.
Quoted 32 lines
Signed-off-by Alex Ling <[email protected]>--- MAINTAINERS | 4 + MAKEALL | 1 + Makefile | 14 ++ board/samsung/mini6410/.gitignore | 5 + board/samsung/mini6410/Makefile | 57 +++++ board/samsung/mini6410/config.mk | 35 +++ board/samsung/mini6410/lowlevel_init.S | 310 ++++++++++++++++++++++++++++ board/samsung/mini6410/mini6410.c | 86 ++++++++ board/samsung/mini6410/u-boot-nand.lds | 62 ++++++ include/configs/mini6410.h | 296 ++++++++++++++++++++++++++ nand_spl/board/samsung/mini6410/Makefile | 112 ++++++++++ nand_spl/board/samsung/mini6410/config.mk | 41 ++++ nand_spl/board/samsung/mini6410/u-boot.lds | 61 ++++++ 13 files changed, 1084 insertions(+), 0 deletions(-) create mode 100644 board/samsung/mini6410/.gitignore create mode 100644 board/samsung/mini6410/Makefile create mode 100644 board/samsung/mini6410/config.mk create mode 100644 board/samsung/mini6410/lowlevel_init.S create mode 100644 board/samsung/mini6410/mini6410.c create mode 100644 board/samsung/mini6410/u-boot-nand.lds create mode 100644 include/configs/mini6410.h create mode 100644 nand_spl/board/samsung/mini6410/Makefile create mode 100644 nand_spl/board/samsung/mini6410/config.mk create mode 100644 nand_spl/board/samsung/mini6410/u-boot.ldsMAINTAINERS +0
-0
MAINTAINERS Alex Z · line 820
Quoted 6 lines
MAINTAINERS +3
-0@@ -815,6 +815,10 @@ Alex Z lart SA1100 dnp1110 SA1110 +Alex Ling <[email protected]> + + MINI6410 ARM1176JZF-S (S3C6410)
Please keep list sorted.
MAKEALL LIST_ARM11=" \ · line 647
Quoted 9 lines
MAKEALL +1
-0@@ -644,6 +644,7 @@ LIST_ARM11=" \ qong \ smdk6400 \ tnetv107x_evm \ + mini6410 \
Please keep list sorted.
Quoted 11 lines
Makefile +3
-0@@ -2235,6 +2235,20 @@ smdk6400_config : unconfig @$(MKCONFIG) smdk6400 arm arm1176 smdk6400 samsung s3c64xx @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk +mini6410_noUSB_config \ +mini6410_config : unconfig + @mkdir -p $(obj)include $(obj)board/samsung/mini6410
Makefile smdk6400_config : unconfig · line 2250
Quoted 10 lines
Makefile +10
-0+ @mkdir -p $(obj)nand_spl/board/samsung/mini6410 + @echo "#define CONFIG_NAND_U_BOOT" > $(obj)include/config.h + @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk + @if [ -z "$(findstring mini6410_noUSB_config,$@)" ]; then \ + echo "RAM_TEXT = 0x57e00000" >> $(obj)board/samsung/mini6410/config.tmp;\ + else \ + echo "RAM_TEXT = 0xc7e00000" >> $(obj)board/samsung/mini6410/config.tmp;\ + fi + @$(MKCONFIG) mini6410 arm arm1176 mini6410 samsung s3c64xx + @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk
NAK. We don't allow such changes any more. Please see previous discussions about this topic and configure using boards.cfg instead.
board/samsung/mini6410/.gitignore line 5
Quoted 11 lines
board/samsung/mini6410/.gitignore new file +5
-0@@ -0,0 +1,5 @@ +# +# Generated files +# + +/config.tmp
Try to avoid such a file.
Quoted 5 lines
board/samsung/mini6410/Makefile new file +0
-0
...
board/samsung/mini6410/Makefile line 34
Quoted 3 lines
board/samsung/mini6410/Makefile new file +3
-0+LIB = $(obj)lib$(BOARD).a + +COBJS-y := mini6410.o
There is no configuration doen here, so rename into plain COBJS.
Quoted 3 lines
board/samsung/mini6410/lowlevel_init.S new file +0
-0
...
board/samsung/mini6410/lowlevel_init.S
Quoted 7 lines
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */board/samsung/mini6410/lowlevel_init.S new file +2
-0+ +
One blank line should be sufficient.
board/samsung/mini6410/lowlevel_init.S line 48
Quoted 7 lines
board/samsung/mini6410/lowlevel_init.S new file +7
-0+#ifdef CONFIG_SERIAL1 +#define ELFIN_UART_CONSOLE_BASE (ELFIN_UART_BASE + ELFIN_UART0_OFFSET) +#elif defined(CONFIG_SERIAL2) +#define ELFIN_UART_CONSOLE_BASE (ELFIN_UART_BASE + ELFIN_UART1_OFFSET) +#else +#define ELFIN_UART_CONSOLE_BASE (ELFIN_UART_BASE + ELFIN_UART2_OFFSET) +#endif
These seem to be unused. Please remove dead code.
board/samsung/mini6410/lowlevel_init.S line 174
Quoted 5 lines
board/samsung/mini6410/lowlevel_init.S new file +5
-0+ /* + * This was unconditional in original Samsung sources, but it doesn't + * seem to make much sense on S3C6400. + */ +#ifndef CONFIG_S3C6400
So does this make sense on your board? Please remove dead code.
...
Quoted 5 lines
board/samsung/mini6410/mini6410.c new file +0
-0
...
board/samsung/mini6410/mini6410.c line 42
Quoted 6 lines
board/samsung/mini6410/mini6410.c new file +6
-0+static inline void delay (unsigned long loops) +{ + __asm__volatile ("1:\n" "subs %0, %1, #1\n" +"bne 1b" + :"=r" (loops) :"0" (loops)); +}
This is probably NOT what you want to do.
board/samsung/mini6410/mini6410.c line 50
Quoted 3 lines
board/samsung/mini6410/mini6410.c new file +3
-0+int board_init (void ) +{ +DECLARE_GLOBAL_DATA_PTR ;
DECLARE_GLOBAL_DATA_PTR must be declared on file scope, not on function scope, or incorrect code may result. Please fix globally.
Quoted 5 lines
include/configs/mini6410.h new file +0
-0
...
Quoted 1 line
+#define
CONFIG_SYS_HUSH_PARSER/* use "hush" command parser */
Line too long. Please fix globally.
include/configs/mini6410.h line 114
Quoted 13 lines
include/configs/mini6410.h new file +13
-0+#define CONFIG_CMD_CACHE +#define CONFIG_CMD_REGINFO +#define CONFIG_CMD_LOADS +#define CONFIG_CMD_LOADB +#define CONFIG_CMD_SAVEENV +#define CONFIG_CMD_NAND +#if defined(CONFIG_BOOT_ONENAND ) +#define CONFIG_CMD_ONENAND +#endif +#define CONFIG_CMD_PING +#define CONFIG_CMD_ELF +#define CONFIG_CMD_FAT +#define CONFIG_CMD_EXT2
This would be easier to read if the list was sorted.
include/configs/mini6410.h line 139
Quoted 2 lines
include/configs/mini6410.h new file +2
-0+#define CONFIG_SYS_MEMTEST_START CONFIG_SYS_SDRAM_BASE/* memtest works on */ +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_SDRAM_BASE + 0x7e00000)/* 126MB in DRAM */
Have you really tested these settings?
Quoted 5 lines
+/*-----------------------------------------------------------------------
+ * Stack sizes
+ *
+ * The stack sizes are set up instart.Susing the settings below
+ */
Incorrect multiline comment style.
Quoted 3 lines
+/**********************************
+ Support Clock Settings
+ **********************************
Ditto. Please fix globally.
include/configs/mini6410.h line 172
Quoted 7 lines
include/configs/mini6410.h new file +7
-0+/*#define CONFIG_CLK_667_133_66*/ +#define CONFIG_CLK_533_133_66 +/* +#define CONFIG_CLK_400_100_50 +#define CONFIG_CLK_400_133_66 +#define CONFIG_SYNC_MODE +*/
Please remove dead code.
Quoted 1 line
+/* SMDK6400 has 2 banks of DRAM, but we use only one in U-Boot */
Why?
include/configs/mini6410.h line 266
Quoted 6 lines
include/configs/mini6410.h new file +6
-0+/* None of these are currently implemented. Left from the original Samsung +* version for reference +#define CONFIG_BOOT_NOR +#define CONFIG_BOOT_MOVINAND +#define CONFIG_BOOT_ONENAND +*/
Please remove dead code. Please fix globally.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Too many people are ready to carry the stool when the piano needs to be moved.
PATCH 1/1 Add basic support for FriendlyARM MINI6410 development board
Thanks. I'll fix them and resubmit the patch
Quoted 252 lines · Wolfgang Denk
Dear Alex Ling,
Quoted 1 line · In message <[email protected]> you wrote:
This patch adds basic support for FriendlyARM MINI6410 development board (a Chinese clone of Samsung SMDK6410)
Please restrict your line length to < 70 characters.
General note: please rebase your code on top of Heiko's ARm rework patches (enable caches, add relocation). These will go in before your board support.
Quoted 35 lines
Signed-off-by Alex Ling <[email protected]>---
?MAINTAINERS ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| ? ?4 + ?MAKEALL ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| ? ?1 + ?Makefile ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? | ? 14 ++ ?board/samsung/mini6410/.gitignore ? ? ? ? ?| ? ?5 + ?board/samsung/mini6410/Makefile ? ? ? ? ? ?| ? 57 +++++ ?board/samsung/mini6410/config.mk ? ? ? ? ? | ? 35 +++ ?board/samsung/mini6410/lowlevel_init.S ? ? | ?310 ++++++++++++++++++++++++++++ ?board/samsung/mini6410/mini6410.c ? ? ? ? ?| ? 86 ++++++++ ?board/samsung/mini6410/u-boot-nand.lds ? ? | ? 62 ++++++ ?include/configs/mini6410.h ? ? ? ? ? ? ? ? | ?296 ++++++++++++++++++++++++++ ?nand_spl/board/samsung/mini6410/Makefile ? | ?112 ++++++++++ ?nand_spl/board/samsung/mini6410/config.mk ?| ? 41 ++++ ?nand_spl/board/samsung/mini6410/u-boot.lds | ? 61 ++++++?13 files changed, 1084 insertions(+), 0 deletions(-) ?create mode 100644 board/samsung/mini6410/.gitignore ?create mode 100644 board/samsung/mini6410/Makefile ?create mode 100644
board/samsung/mini6410/config.mk?create mode 100644board/samsung/mini6410/lowlevel_init.S?create mode 100644board/samsung/mini6410/mini6410.c?create mode 100644board/samsung/mini6410/u-boot-nand.lds?create mode 100644include/configs/mini6410.h?create mode 100644 nand_spl/board/samsung/mini6410/Makefile ?create mode 100644nand_spl/board/samsung/mini6410/config.mk?create mode 100644nand_spl/board/samsung/mini6410/u-boot.ldsMAINTAINERS +0
-0@@ -815,6 +815,10 @@ Alex Z? ? ? lart ? ? ? ? ? ?SA1100
? ? ? dnp1110 ? ? ? ? SA1110MAINTAINERS Alex Z
Quoted 3 lines
MAINTAINERS +3
-0+Alex Ling <[email protected]> + + ? ? MINI6410 ? ? ? ?ARM1176JZF-S (S3C6410)Please keep list sorted.
MAKEALL LIST_ARM11=" ? ? ? ? ? ? ? ? ? ? ?\ · line 647
Quoted 9 lines
MAKEALL +1
-0@@ -644,6 +644,7 @@ LIST_ARM11=" ? ? ? ? ? ? ? ? ? ? ?\ ? ? ? qong ? ? ? ? ? ? ? ? ? ?\ ? ? ? smdk6400 ? ? ? ? ? ? ? ?\ ? ? ? tnetv107x_evm ? ? ? ? ? \ + ? ? mini6410 ? ? ? ? ? ? ? ?\Please keep list sorted.
Quoted 11 lines
Makefile +0
-0@@ -2235,6 +2235,20 @@ smdk6400_config ? ? ? ?: ? ? ? unconfig? ? ? @$(MKCONFIG) smdk6400 arm arm1176 smdk6400 samsung s3c64xx ? ? ? @echo "
CONFIG_NAND_U_BOOT= y" >> $(obj)include/config.mkMakefile +3
-0+mini6410_noUSB_config ? \ +mini6410_config : ? ?unconfig + ? ? @mkdir -p $(obj)include $(obj)board/samsung/mini6410Makefile
Quoted 10 lines
Makefile +10
-0+ ? ? @mkdir -p $(obj)nand_spl/board/samsung/mini6410 + ? ? @echo "#define CONFIG_NAND_U_BOOT" > $(obj)include/config.h + ? ? @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk + ? ? @if [ -z "$(findstring mini6410_noUSB_config,$@)" ]; then ? ? ? ? ? ? ? ? ? ? ? \ + ? ? ? ? ? ? echo "RAM_TEXT = 0x57e00000" >> $(obj)board/samsung/mini6410/config.tmp;\ + ? ? else ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\ + ? ? ? ? ? ? echo "RAM_TEXT = 0xc7e00000" >> $(obj)board/samsung/mini6410/config.tmp;\ + ? ? fi + ? ? @$(MKCONFIG) mini6410 arm arm1176 mini6410 samsung s3c64xx + ? ? @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mkNAK. We don't allow such changes any more. Please see previous discussions about this topic and configure using boards.cfg instead.
board/samsung/mini6410/.gitignore line 5
Quoted 11 lines
board/samsung/mini6410/.gitignore new file +5
-0@@ -0,0 +1,5 @@ +# +# Generated files +# + +/config.tmpTry to avoid such a file.
Quoted 5 lines
board/samsung/mini6410/Makefile new file +0
-0...
board/samsung/mini6410/Makefile
Quoted 3 lines
board/samsung/mini6410/Makefile new file +3
-0+LIB ?= $(obj)lib$(BOARD).a + +COBJS-y ? ? ?:= mini6410.oThere is no configuration doen here, so rename into plain COBJS.
Quoted 3 lines
board/samsung/mini6410/lowlevel_init.S new file +0
-0...
board/samsung/mini6410/lowlevel_init.S
Quoted 7 lines
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */board/samsung/mini6410/lowlevel_init.S new file +2
-0+ +One blank line should be sufficient.
board/samsung/mini6410/lowlevel_init.S line 48
Quoted 7 lines
board/samsung/mini6410/lowlevel_init.S new file +7
-0+#ifdef CONFIG_SERIAL1 +#define ELFIN_UART_CONSOLE_BASE (ELFIN_UART_BASE + ELFIN_UART0_OFFSET) +#elif defined(CONFIG_SERIAL2) +#define ELFIN_UART_CONSOLE_BASE (ELFIN_UART_BASE + ELFIN_UART1_OFFSET) +#else +#define ELFIN_UART_CONSOLE_BASE (ELFIN_UART_BASE + ELFIN_UART2_OFFSET) +#endifThese seem to be unused. Please remove dead code.
Quoted 5 lines
+ ? ? /*
+ ? ? ?* This was unconditional in original Samsung sources, but it doesn't
+ ? ? ?* seem to make much sense on S3C6400.
+ ? ? ?*/
+#ifndefCONFIG_S3C6400So does this make sense on your board? ?Please remove dead code.
...
Quoted 5 lines
board/samsung/mini6410/mini6410.c new file +0
-0...
board/samsung/mini6410/mini6410.c line 42
Quoted 6 lines
board/samsung/mini6410/mini6410.c new file +6
-0+static inline void delay (unsigned long loops) +{ + ? ? __asm__ volatile ("1:\n" "subs %0, %1, #1\n" + ? ? ? ? ? ? ? ? ? ? ? "bne 1b" + ? ? ? ? ? ? ? ? ? ? ? : "=r" (loops) : "0" (loops)); +}This is probably NOT what you want to do.
board/samsung/mini6410/mini6410.c
Quoted 3 lines
board/samsung/mini6410/mini6410.c new file +3
-0+int board_init (void ) +{ + ? ? DECLARE_GLOBAL_DATA_PTR;
DECLARE_GLOBAL_DATA_PTRmust be declared on file scope, not on function scope, or incorrect code may result. ?Please fix globally.Quoted 5 lines
include/configs/mini6410.h new file +0
-0...
Quoted 1 line
+#define
CONFIG_SYS_HUSH_PARSER? ? ? ? ? ? ? ? ? ? ? /* use "hush" command parser ? ?*/Line too long. Please fix globally.
include/configs/mini6410.h line 114
Quoted 13 lines
include/configs/mini6410.h new file +13
-0+#define CONFIG_CMD_CACHE +#define CONFIG_CMD_REGINFO +#define CONFIG_CMD_LOADS +#define CONFIG_CMD_LOADB +#define CONFIG_CMD_SAVEENV +#define CONFIG_CMD_NAND +#if defined(CONFIG_BOOT_ONENAND ) +#define CONFIG_CMD_ONENAND +#endif +#define CONFIG_CMD_PING +#define CONFIG_CMD_ELF +#define CONFIG_CMD_FAT +#define CONFIG_CMD_EXT2 This would be easier to read if the list was sorted.
include/configs/mini6410.h
Quoted 2 lines
include/configs/mini6410.h new file +2
-0+#define CONFIG_SYS_MEMTEST_START ? ? CONFIG_SYS_SDRAM_BASE ?/* memtest works on ? ? ? ? ? */ +#define CONFIG_SYS_MEMTEST_END ? ? ? ? ? ? ? (CONFIG_SYS_SDRAM_BASE + 0x7e00000)/* 126MB in DRAM */ Have you really tested these settings?
Quoted 5 lines
+/*-----------------------------------------------------------------------
+ * Stack sizes
+ *
+ * The stack sizes are set up instart.Susing the settings below
+ */Incorrect multiline comment style.
Quoted 3 lines
+/**********************************
+ Support Clock Settings
+ **********************************Ditto. Please fix globally.
include/configs/mini6410.h line 172
Quoted 7 lines
include/configs/mini6410.h new file +7
-0+/*#define CONFIG_CLK_667_133_66*/ +#define CONFIG_CLK_533_133_66 +/* +#define CONFIG_CLK_400_100_50 +#define CONFIG_CLK_400_133_66 +#define CONFIG_SYNC_MODE +*/ Please remove dead code.
Quoted 1 line
+/* SMDK6400 has 2 banks of DRAM, but we use only one in U-Boot */
Why?
include/configs/mini6410.h line 266
Quoted 6 lines
include/configs/mini6410.h new file +6
-0+/* None of these are currently implemented. Left from the original Samsung +* version for reference +#define CONFIG_BOOT_NOR +#define CONFIG_BOOT_MOVINAND +#define CONFIG_BOOT_ONENAND +*/ Please remove dead code. Please fix globally.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Too many people are ready to carry the stool when the piano needs ?to be moved.