Skip to contentSkip to conversation

RDMA/nes: correct register write in set TX pause param

PATCH In review Chien Tung 2 participants 2 messages Sep 7, 2010 – Sep 8, 2010 InfiniBand

lore
Share & tools
lore

Chien Tung

author
#0 lore raw

PATCH 1/1 RDMA/nes: correct register write in set TX pause param

Set TX pause param is writing to the wrong register location causing the adpater to hang. Correct the define used to write the reigster. This fixes OFED bug #2116.
https://bugs.openfabrics.org/show_bug.cgi?id=2116

Reported-by Shiri Franchi <shirif-smomgflXvOZWk0Htik3J/[email protected]>
Signed-off-by Chien Tung <[email protected]>
---
 drivers/infiniband/hw/nes/nes_nic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/infiniband/hw/nes/nes_nic.c +2 -2
index 37a6733..3892e2c 100644
@@ -1447,14 +1447,14 @@ static int nes_netdev_set_pauseparam(struct net_device *netdev,
 				NES_IDX_MAC_TX_CONFIG + (nesdev->mac_index*0x200));
 		u32temp |= NES_IDX_MAC_TX_CONFIG_ENABLE_PAUSE;
 		nes_write_indexed(nesdev,
-				NES_IDX_MAC_TX_CONFIG_ENABLE_PAUSE + (nesdev->mac_index*0x200), u32temp);
+				NES_IDX_MAC_TX_CONFIG + (nesdev->mac_index*0x200), u32temp);
 		nesdev->disable_tx_flow_control = 0;
 	} else if ((et_pauseparam->tx_pause == 0) && (nesdev->disable_tx_flow_control == 0)) {
 		u32temp = nes_read_indexed(nesdev,
 				NES_IDX_MAC_TX_CONFIG + (nesdev->mac_index*0x200));
 		u32temp &= ~NES_IDX_MAC_TX_CONFIG_ENABLE_PAUSE;
 		nes_write_indexed(nesdev,
-				NES_IDX_MAC_TX_CONFIG_ENABLE_PAUSE + (nesdev->mac_index*0x200), u32temp);
+				NES_IDX_MAC_TX_CONFIG + (nesdev->mac_index*0x200), u32temp);
 		nesdev->disable_tx_flow_control = 1;
 	}
 	if ((et_pauseparam->rx_pause == 1) && (nesdev->disable_rx_flow_control == 1)) {
Signature · 6 lines
1.6.4.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html