atlx: make strings const
Subsystems (2)
PATCH 1/1 atlx: make strings const
Signed-off-by Stephen Hemminger <[email protected]>
Acked-by Chris Snook <[email protected]>
drivers/net/atlx/atl2.c +3 -3
@@ -51,10 +51,10 @@#define ATL2_DRV_VERSION "2.2.3" -static char atl2_driver_name[] ="atl2" ; +static const char atl2_driver_name[] ="atl2" ;static const char atl2_driver_string[] ="Atheros(R) L2 Ethernet Driver" ; -static char atl2_copyright[] ="Copyright (c) 2007 Atheros Corporation." ; -static char atl2_driver_version[] =ATL2_DRV_VERSION ; +static const char atl2_copyright[] ="Copyright (c) 2007 Atheros Corporation." ; +static const char atl2_driver_version[] =ATL2_DRV_VERSION ;MODULE_AUTHOR ("Atheros Corporation <[email protected]>, Chris Snook <[email protected]>" );MODULE_DESCRIPTION ("Atheros Fast Ethernet Network Driver" );
Quoted 3 lines · Stephen Hemminger
Signed-off-by Stephen Hemminger <[email protected]>Acked-by Chris Snook <[email protected]>
Shouldn't that be done with all of the global
static char foo[] = "bar"; declarations?
Quoted 7 lines · On Wed, 08 Sep 2010 15:58:11 -0700 Joe Perches <[email protected]> wrote:
Quoted 3 lines · Stephen Hemminger
Signed-off-by Stephen Hemminger <[email protected]>Acked-by Chris Snook <[email protected]>Shouldn't that be done with all of the global
static char foo[] = "bar"; declarations?
Yes, that what I was looking at when I found some of these. Those that are __initdata don't matter as much since they get dropped (although they could be changed to __initconst).
From: Stephen Hemminger <[email protected]>
Date: Wed, 8 Sep 2010 15:18:36 -0700
Quoted 3 lines
Signed-off-by Stephen Hemminger <[email protected]>Acked-by Chris Snook <[email protected]>
Applied, feel free to hit those __initconst cases too.