omap: OMAP_IOMMU not visible in menuconfig
Subsystems (3)
PATCH 1/1 omap: OMAP_IOMMU not visible in menuconfig
The menu option to select CONFIG_OMAP_IOMMU
was not visible in the menuconfig due to missing
description.
--- arch/arm/plat-omap/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/Kconfig +1 -1
@@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE module parameter). config OMAP_IOMMU - tristate + tristate "OMAP IOMMU support" config OMAP_IOMMU_DEBUG tristate "Export OMAP IOMMU internals in DebugFS"
Signature · 1 line
1.6.2.4
Hi Sanjeev,
From: ext Sanjeev Premi <[email protected]>
Subject: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
Date: Wed, 8 Sep 2010 16:51:21 +0200
Quoted 3 lines
The menu option to select
CONFIG_OMAP_IOMMU
was not visible in the menuconfig due to missing
description.
There's no point to make OMAP_IOMMU visible since this is a kind of feature used by other device implicitly. OMAP_IOMMU on menu might confuse users at kernel menuconfig. Instead this should be automatically selected by its clients when it is selected. For exmaple, the case that DSP or Tesla is selected. There was a discussion about this before.
Quoted 26 lines
Signed-off-by Sanjeev Premi <[email protected]>--- arch/arm/plat-omap/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-omap/Kconfig +1
-1@@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE module parameter). config OMAP_IOMMU - tristate + tristate "OMAP IOMMU support" config OMAP_IOMMU_DEBUG tristate "Export OMAP IOMMU internals in DebugFS"Signature · 6 lines
1.6.2.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 17 lines
-----Original Message-----
From: Hiroshi DOYU [mailto:[email protected]]
Sent: Thursday, September 09, 2010 10:35 AM
To: Premi, Sanjeev
Cc: [email protected]
Subject: Re: [PATCH] omap:OMAP_IOMMUnot visible in menuconfigHi Sanjeev,
From: ext Sanjeev Premi <[email protected]>
Subject: [PATCH] omap:OMAP_IOMMUnot visible in menuconfig
Date: Wed, 8 Sep 2010 16:51:21 +0200Quoted 3 lines
The menu option to select
CONFIG_OMAP_IOMMU
was not visible in the menuconfig due to missing
description.
Quoted 7 lines
There's no point to make
OMAP_IOMMUvisible since this is a kind of feature used by other device implicitly.OMAP_IOMMUon menu might confuse
users at kernel menuconfig. Instead this should be automatically selected by its clients when it is selected. For exmaple, the case that DSP or Tesla is selected. There was a discussion about this before.
[sp] You would have noticed that there are mnay OMAP3 variants and
some of them are ARM only - detection being runtime, not compile time.
All these processors share same defconfig.
Keeping/ maintaining specific defconfigs for each processor will be too difficult.
~sanjeev
Quoted 29 lines
Quoted 25 lines
Signed-off-by Sanjeev Premi <[email protected]>--- arch/arm/plat-omap/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-omap/Kconfig +1
-1@@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE module parameter). config OMAP_IOMMU - tristate + tristate "OMAP IOMMU support" config OMAP_IOMMU_DEBUG tristate "Export OMAP IOMMU internals in DebugFS"Signature · 4 lines
1.6.2.4 -- To unsubscribe from this list: send the line "unsubscribelinux-omap" in
Quoted 2 lines
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: "ext Premi, Sanjeev" <[email protected]>
Subject: RE: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
Date: Thu, 9 Sep 2010 07:10:05 +0200
Quoted 25 lines
Quoted 17 lines
-----Original Message-----
From: Hiroshi DOYU [mailto:[email protected]]
Sent: Thursday, September 09, 2010 10:35 AM
To: Premi, Sanjeev
Cc: [email protected]
Subject: Re: [PATCH] omap:OMAP_IOMMUnot visible in menuconfigHi Sanjeev,
From: ext Sanjeev Premi <[email protected]>
Subject: [PATCH] omap:OMAP_IOMMUnot visible in menuconfig
Date: Wed, 8 Sep 2010 16:51:21 +0200Quoted 3 lines
The menu option to select
CONFIG_OMAP_IOMMU
was not visible in the menuconfig due to missing
description.Quoted 7 lines
There's no point to make
OMAP_IOMMUvisible since this is a kind of feature used by other device implicitly.OMAP_IOMMUon menu might confuse
users at kernel menuconfig. Instead this should be automatically selected by its clients when it is selected. For exmaple, the case that DSP or Tesla is selected. There was a discussion about this before.
Quoted 5 lines
[sp] You would have noticed that there are mnay OMAP3 variants and
some of them are ARM only - detection being runtime, not compile time.All these processors share same defconfig.
Setting dependency correctly could solve this?
Modified drivers/staging/tidspbridge/Kconfig
drivers/staging/tidspbridge/Kconfig +1 -0
@@ -6,6 +6,7 @@ menuconfig TIDSPBRIDGE tristate "DSP Bridge driver" depends on ARCH_OMAP3 select OMAP_MBOX_FWK + select OMAP_IOMMU help DSP/BIOS Bridge is designed for platforms that contain a GPP and one or more attached DSPs. The GPP is considered the master or
Quoted 35 lines
Keeping/ maintaining specific defconfigs for each processor will be too difficult.
~sanjeev
Quoted 29 lines
Quoted 25 lines
Signed-off-by Sanjeev Premi <[email protected]>--- arch/arm/plat-omap/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-omap/Kconfig +1
-1@@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE module parameter). config OMAP_IOMMU - tristate + tristate "OMAP IOMMU support" config OMAP_IOMMU_DEBUG tristate "Export OMAP IOMMU internals in DebugFS"Signature · 4 lines
1.6.2.4 -- To unsubscribe from this list: send the line "unsubscribelinux-omap" in
Quoted 2 lines
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Hiroshi DOYU <[email protected]>
Subject: Re: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
Date: Thu, 09 Sep 2010 08:24:05 +0300 (EEST)
Quoted 32 lines
From: "ext Premi, Sanjeev" <[email protected]>
Subject: RE: [PATCH] omap:OMAP_IOMMUnot visible in menuconfig
Date: Thu, 9 Sep 2010 07:10:05 +0200Quoted 28 lines
Quoted 17 lines
-----Original Message-----
From: Hiroshi DOYU [mailto:[email protected]]
Sent: Thursday, September 09, 2010 10:35 AM
To: Premi, Sanjeev
Cc: [email protected]
Subject: Re: [PATCH] omap:OMAP_IOMMUnot visible in menuconfigHi Sanjeev,
From: ext Sanjeev Premi <[email protected]>
Subject: [PATCH] omap:OMAP_IOMMUnot visible in menuconfig
Date: Wed, 8 Sep 2010 16:51:21 +0200Quoted 3 lines
The menu option to select
CONFIG_OMAP_IOMMU
was not visible in the menuconfig due to missing
description.Quoted 7 lines
There's no point to make
OMAP_IOMMUvisible since this is a kind of feature used by other device implicitly.OMAP_IOMMUon menu might confuse
users at kernel menuconfig. Instead this should be automatically selected by its clients when it is selected. For exmaple, the case that DSP or Tesla is selected. There was a discussion about this before.[sp] You would have noticed that there are mnay OMAP3 variants and
some of them are ARM only - detection being runtime, not compile time.
For the runtime detection, can this be done at platform_device registration time?
Quoted 55 lines
Quoted 2 lines
All these processors share same defconfig.
Setting dependency correctly could solve this?
Modified
drivers/staging/tidspbridge/Kconfigdrivers/staging/tidspbridge/Kconfig +1
-0@@ -6,6 +6,7 @@ menuconfig TIDSPBRIDGE tristate "DSP Bridge driver" depends on ARCH_OMAP3 select OMAP_MBOX_FWK + select OMAP_IOMMU help DSP/BIOS Bridge is designed for platforms that contain a GPP and one or more attached DSPs. The GPP is considered the master orQuoted 37 lines
Keeping/ maintaining specific defconfigs for each processor will be too difficult.
~sanjeev
Quoted 29 lines
Quoted 25 lines
Signed-off-by Sanjeev Premi <[email protected]>--- arch/arm/plat-omap/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-omap/Kconfig +1
-1@@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE module parameter). config OMAP_IOMMU - tristate + tristate "OMAP IOMMU support" config OMAP_IOMMU_DEBUG tristate "Export OMAP IOMMU internals in DebugFS"Signature · 4 lines
1.6.2.4 -- To unsubscribe from this list: send the line "unsubscribelinux-omap" in
Quoted 2 lines
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 10 lines · Hiroshi DOYU
Hi Sanjeev,
From: ext Sanjeev Premi <[email protected]>
Subject: [PATCH] omap:OMAP_IOMMUnot visible in menuconfig
Date: Wed, 8 Sep 2010 16:51:21 +0200Quoted 3 lines
The menu option to select
CONFIG_OMAP_IOMMU
was not visible in the menuconfig due to missing
description.
Quoted 6 lines
There's no point to make
OMAP_IOMMUvisible since this is a kind of feature used by other device implicitly.OMAP_IOMMUon menu might confuse users at kernel menuconfig. Instead this should be automatically selected by its clients when it is selected. For exmaple, the case that DSP or Tesla is selected. There was a discussion about this before.
in that case...
Quoted 6 lines
arch/arm/plat-omap/Kconfig config OMAP_MBOX_KFIFO_SIZE · line 101
Quoted 6 lines
arch/arm/plat-omap/Kconfig +1
-1@@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE module parameter). config OMAP_IOMMU - tristate + tristate "OMAP IOMMU support"
it doesn't have to be tristate as select will always mark it 'y'
Signature · 1 line
balbi
Quoted 20 lines · On Thu, 9 Sep 2010 07:58:55 +0200 ext Felipe Balbi <[email protected]> wrote:
Quoted 10 lines · Hiroshi DOYU
Hi Sanjeev,
From: ext Sanjeev Premi <[email protected]>
Subject: [PATCH] omap:OMAP_IOMMUnot visible in menuconfig
Date: Wed, 8 Sep 2010 16:51:21 +0200Quoted 3 lines
The menu option to select
CONFIG_OMAP_IOMMU
was not visible in the menuconfig due to missing
description.Quoted 6 lines
There's no point to make
OMAP_IOMMUvisible since this is a kind of feature used by other device implicitly.OMAP_IOMMUon menu might confuse users at kernel menuconfig. Instead this should be automatically selected by its clients when it is selected. For exmaple, the case that DSP or Tesla is selected. There was a discussion about this before.in that case...
Quoted 8 lines
Quoted 6 lines
arch/arm/plat-omap/Kconfig config OMAP_MBOX_KFIFO_SIZE · line 101
Quoted 6 lines
arch/arm/plat-omap/Kconfig +1
-1@@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE module parameter). config OMAP_IOMMU - tristate + tristate "OMAP IOMMU support"it doesn't have to be tristate as select will always mark it 'y'
Right;p
Quoted 36 lines
-----Original Message-----
From: Hiroshi DOYU [mailto:[email protected]]
Sent: Thursday, September 09, 2010 11:52 AM
To: Balbi, Felipe
Cc: Premi, Sanjeev; [email protected]
Subject: Re: [PATCH] omap:OMAP_IOMMUnot visible in menuconfigQuoted 7 lines · On Thu, 9 Sep 2010 07:58:55 +0200 ext Felipe Balbi <[email protected]> wrote:
Quoted 6 lines · Hiroshi DOYU
Hi Sanjeev,
From: ext Sanjeev Premi <[email protected]>
Subject: [PATCH] omap:OMAP_IOMMUnot visible in menuconfig
Date: Wed, 8 Sep 2010 16:51:21 +0200Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
The menu option to select
CONFIG_OMAP_IOMMU
was not visible in the menuconfig due to missing
description.There's no point to make
OMAP_IOMMUvisible since this is a kind of feature used by other device implicitly.OMAP_IOMMUonmenu might confuse
Quoted 10 lines
Quoted 4 lines
users at kernel menuconfig. Instead this should be automatically selected by its clients when it is selected. For exmaple, the case that DSP or Tesla is selected. There was a discussion about this before.
in that case...
Quoted 3 lines
Quoted 3 lines
arch/arm/plat-omap/Kconfig +0
-0@@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE module parameter).
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
arch/arm/plat-omap/Kconfig config OMAP_MBOX_KFIFO_SIZE · line 101
Quoted 3 lines
arch/arm/plat-omap/Kconfig +1
-1config OMAP_IOMMU - tristate + tristate "OMAP IOMMU support"it doesn't have to be tristate as select will always mark it 'y'
Right;p
[sp] So, we will need to "select" this option with ARCH_OMAP3.
And maybe for OMAP4...
~sanjeev