Skip to contentSkip to conversation

SPI: move PL022 probe call to subsys_initcall()

PATCH New Linus Walleij 3 participants 3 messages Sep 6, 2010 – Sep 9, 2010 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SPI: move PL022 probe call to subsys_initcall()

The PL022 SPI bus is sometimes used for early stuff like regulators that need to be present at module_init() time, so we move this to a subsys_initcall().

---
 drivers/spi/amba-pl022.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/spi/amba-pl022.c +1 -1
index 3db5402..f958072 100644
@@ -2324,7 +2324,7 @@ static int __init pl022_init(void)
 	return amba_driver_register(&pl022_driver);
 }
 
-module_init(pl022_init);
+subsys_initcall(pl022_init);
 
 static void __exit pl022_exit(void)
 {
Signature · 1 line
1.6.3.3
Applied
#1 lore raw

PATCH 1/1 SPI: move PL022 probe call to subsys_initcall()

Quoted 6 lines · Linus Walleij

The PL022 SPI bus is sometimes used for early stuff like regulators that need to be present at module_init() time, so we move this to a subsys_initcall().

Applied, thanks.

Note on the subject line: The preferred form for spi patches is:

spi[/chip]: <description>

'spi' in the header and the optional driver name are both lowercase. I fix patches up to match this form, but it is less work for me when I don't have to.

g.

Quoted 20 lines
---
 drivers/spi/amba-pl022.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/spi/amba-pl022.c +1 -1
index 3db5402..f958072 100644
@@ -2324,7 +2324,7 @@ static int __init pl022_init(void)
 	return amba_driver_register(&pl022_driver);
 }
 
-module_init(pl022_init);
+subsys_initcall(pl022_init);
 
 static void __exit pl022_exit(void)
 {
Signature · 1 line
1.6.3.3
#2 lore raw

PATCH 1/1 SPI: move PL022 probe call to subsys_initcall()

2010/9/9 Grant Likely <[email protected]>:

Quoted 3 lines

Note on the subject line: ?The preferred form for spi patches is:

? ?spi[/chip]: <description>

Ah OK I'll use that syntax henceforth. Thanks!

Linus Walleij