Skip to contentSkip to conversation

opensm/osm_subnet.c: fixing small bug in error path

PATCH Applied Yevgeny Kliteynik 2 participants 2 messages Sep 7, 2010 – Sep 9, 2010 1 message not in the archive InfiniBand

lore
Share & tools
lore

Yevgeny Kliteynik

author
#0 lore raw

PATCH 1/1 opensm/osm_subnet.c: fixing small bug in error path

Closing file on failure

Signed-off-by Yevgeny Kliteynik <[email protected]>
---
 opensm/opensm/osm_subnet.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
opensm/opensm/osm_subnet.c +3 -1
index d5c5ab2..149ab85 100644
@@ -1163,8 +1163,10 @@ int osm_subn_parse_conf_file(char *file_name, osm_subn_opt_t * p_opts)
 	cl_log_event("OpenSM", CL_LOG_INFO, line, NULL, 0);
 
 	p_opts->config_file = file_name;
-	if (!p_opts->file_opts && !(p_opts->file_opts = malloc(sizeof(*p_opts))))
+	if (!p_opts->file_opts && !(p_opts->file_opts = malloc(sizeof(*p_opts)))) {
+		fclose(opts_file);
 		return -1;
+	}
 	memcpy(p_opts->file_opts, p_opts, sizeof(*p_opts));
 
 	while (fgets(line, 1023, opts_file) != NULL) {
Signature · 6 lines
1.6.2.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 4C865486.4040909-VPRAkNaXOzVS1MOuV/[email protected]