Skip to contentSkip to conversation

Zoom2 & Zoom3: introduced a macro to use a different buffer size when compiling for Zoom2 or Zoom3.

PATCH New Aldo Cedillo 3 participants 3 messages Aug 30, 2010 – Sep 14, 2010 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Zoom2 & Zoom3: introduced a macro to use a different buffer size when compiling for Zoom2 or Zoom3.

From: Aldo Brett Cedillo Martinez <[email protected]>

Zoom2 and Zoom2 used to hang with "md" command. It was due to a problem with a buffer size in print_buffer() function. A macro was introduced to use a different buffer size in case of compiling for Zoom2 and Zoom3.

Jeff could you please test it on your board with the Zoom3 initial support patch.

Sandeep I also saw this behaving in Zoom2, so maybe I could send a patch that introduces only Zoom2 change, which could be introduced in TI tree without waiting for Zoom3 initial support for going mainline.

---
 lib/display_options.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
lib/display_options.c +5 -0
index 20319e6..99e43f7 100644
@@ -101,7 +101,12 @@ void print_size(unsigned long long size, const char *s)
 #define DEFAULT_LINE_LENGTH_BYTES (16)
 int print_buffer (ulong addr, void* data, uint width, uint count, uint linelen)
 {
+#if defined(CONFIG_OMAP3_ZOOM2) || defined(CONFIG_OMAP3_ZOOM3)
+	uint8_t linebuf[DEFAULT_LINE_LENGTH_BYTES];
+#else
 	uint8_t linebuf[MAX_LINE_LENGTH_BYTES + 1];
+#endif /* CONFIG_OMAP3 */
+
 	uint32_t *uip = (void*)linebuf;
 	uint16_t *usp = (void*)linebuf;
 	uint8_t *ucp = (void*)linebuf;
Signature · 1 line
1.6.3.3
#1 lore raw

PATCH 1/1 Zoom2 & Zoom3: introduced a macro to use a different buffer size when compiling for Zoom2 or Zoom3.

Dear Aldo Cedillo,

Quoted 5 lines · In message <[email protected]> you wrote:

From: Aldo Brett Cedillo Martinez <[email protected]>

Zoom2 and Zoom2 used to hang with "md" command. It was due to a problem with a buffer size in print_buffer() function. A macro was introduced to use a different buffer size in case of compiling for Zoom2 and Zoom3.

NAK to this patch.

Forst, I thinkt he problem is not with buffer size, but with buffer alignemnt as observed elasewhere, so most probably Albert's "display_buffer: fix misaligned buffer" patch will fix this issue, too.

lib/display_options.c void print_size(unsigned long long size, const char *s) · line 108

Quoted 8 lines

#define DEFAULT_LINE_LENGTH_BYTES (16)
int print_buffer (ulong addr, void* data, uint width, uint count, uint linelen) {

lib/display_options.c +4 -0
+#if defined(CONFIG_OMAP3_ZOOM2) || defined(CONFIG_OMAP3_ZOOM3)
+	uint8_t linebuf[DEFAULT_LINE_LENGTH_BYTES];
+#else
 	uint8_t linebuf[MAX_LINE_LENGTH_BYTES + 1];
+#endif /* CONFIG_OMAP3 */

Second, it is broken to use DEFAULT_LINE_LENGTH_BYTES in the declaration of the buffer, but then use MAX_LINE_LENGTH_BYTES+1 when accessing it.

[Actually I think we should kill one of these defines.]

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Overflow on /dev/null, please empty the bit bucket.
#2 lore raw

PATCH 1/1 Zoom2 & Zoom3: introduced a macro to use a different buffer size when compiling for Zoom2 or Zoom3.

Dear Wolfgang,

Quoted 11 lines
Quoted 3 lines

Zoom2 and Zoom2 used to hang with "md" command. It was due to a problem with a buffer size in print_buffer() function. A macro was introduced to use a different buffer size in case of compiling for Zoom2 and Zoom3.

NAK to this patch.

Forst, I thinkt he problem is not with buffer size, but with buffer alignemnt as observed elasewhere, so most probably Albert's "display_buffer: fix misaligned buffer" patch will fix this issue, too.

You are right, the problem is the buffer alignment, and the patch you mentioned solves this problem.

Quoted 4 lines

Best regards,

Wolfgang Denk

Thanks for the comments and best regards,
Aldo