drivers/mmc/host/imxmmc.c: adjust confusing if indentation
Subsystems (2)
PATCH 18/41 drivers/mmc/host/imxmmc.c: adjust confusing if indentation
From: Julia Lawall <[email protected]>
Move the second if (reg & ...) test into the branch indicated by its indentation. The test was previously always executed after the if containing that branch, but it was always false unless the if branch was taken.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by Julia Lawall <[email protected]>
Signed-off-by Chris Ball <[email protected]>
Cc Pavel Pisa <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
drivers/mmc/host/imxmmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/imxmmc.c renamed from drivers/mmc/host/imxmmc.c~drivers-mmc-host-imxmmcc-adjust-confusing-if-indentation +2 -1
@@ -148,11 +148,12 @@ static int imxmci_start_clock(struct imxwhile (delay--) { reg =readw (host->base +MMC_REG_STATUS ); -if (reg &STATUS_CARD_BUS_CLK_RUN ) +if (reg &STATUS_CARD_BUS_CLK_RUN ) {/* Check twice before cut */ reg =readw (host->base +MMC_REG_STATUS );if (reg &STATUS_CARD_BUS_CLK_RUN )return 0 ; + }if (test_bit (IMXMCI_PEND_STARTED_b, &host->pending_events))return 0 ;
_