Skip to contentSkip to conversation

powerpc, perf: Fix sampling enable for PPC970

PATCH New Paul Mackerras 1 participant 1 message Sep 10, 2010 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc, perf: Fix sampling enable for PPC970

The logic to distinguish marked instruction events from ordinary events on PPC970 and derivatives was flawed. The result is that instruction sampling didn't get enabled in the PMU for some marked instruction events, so they would never trigger. This fixes it by adding the appropriate break statements in the switch statement.

---
 arch/powerpc/kernel/ppc970-pmu.c |    2 ++
 1 file changed, 2 insertions(+)
arch/powerpc/kernel/ppc970-pmu.c +2 -0
index 8eff48e..3fee685 100644
@@ -169,9 +169,11 @@ static int p970_marked_instr_event(u64 event)
 	switch (unit) {
 	case PM_VPU:
 		mask = 0x4c;		/* byte 0 bits 2,3,6 */
+		break;
 	case PM_LSU0:
 		/* byte 2 bits 0,2,3,4,6; all of byte 1 */
 		mask = 0x085dff00;
+		break;
 	case PM_LSU1L:
 		mask = 0x50 << 24;	/* byte 3 bits 4,6 */
 		break;