net/llc: make opt unsigned in llc_ui_setsockopt()

PATCH Applied Dan Carpenter 2 participants 2 messages Sep 10, 2010 – Sep 13, 2010

Subsystems (4)

Networking Network drivers Kernel janitors LLC (802.2)

lore

Share & tools

lore

Dan Carpenter

author

2010-09-10 11:56 UTC #0 lore raw

PATCH 1/1 net/llc: make opt unsigned in llc_ui_setsockopt()

The members of struct llc_sock are unsigned so if we pass a negative value for "opt" it can cause a sign bug. Also it can cause an integer overflow when we multiply "opt * HZ".

CC [email protected]

Signed-off-by Dan Carpenter <[email protected]>

net/llc/af_llc.c +2 -1

index 023ba82..5826129 100644
@@ -1024,7 +1024,8 @@ static int llc_ui_setsockopt(struct socket *sock, int level, int optname,
 {
 	struct sock *sk = sock->sk;
 	struct llc_sock *llc = llc_sk(sk);
-	int rc = -EINVAL, opt;
+	unsigned int opt;
+	int rc = -EINVAL;
 
 	lock_sock(sk);
 	if (unlikely(level != SOL_LLC || optlen != sizeof(int)))

David Miller

maintainer Applied

2010-09-13 19:44 UTC #1 lore raw

From: Dan Carpenter <[email protected]>
Date: Fri, 10 Sep 2010 13:56:16 +0200

Quoted 6 lines

The members of struct llc_sock are unsigned so if we pass a negative value for "opt" it can cause a sign bug. Also it can cause an integer overflow when we multiply "opt * HZ".
CC [email protected]
Signed-off-by Dan Carpenter <[email protected]>

Applied.