Skip to contentSkip to conversation

silence awk command display during build

PATCH New Kim Phillips 3 participants 15 messages Sep 14, 2010 – Sep 21, 2010 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 silence awk command display during build

[u-boot next]$ ./MAKEALL 83xx
awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg > .boards.depend Configuring for ve8313 board...

---
applies to u-boot.git's next branch.

 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
index 36f2e1e..50bbe08 100644
@@ -495,7 +495,7 @@ unconfig:
 
 sinclude .boards.depend
 .boards.depend:	boards.cfg
-	awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@
+	@awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@
 
 #
 # Functions to generate common board directory names
Signature · 1 line
1.7.2.1
#1 lore raw

PATCH 1/1 silence awk command display during build

Quoted 3 lines · On Monday, September 13, 2010 21:17:30 Kim Phillips wrote:

[u-boot next]$ ./MAKEALL 83xx
awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg

Quoted 1 line

.boards.depend Configuring for ve8313 board...

how about we change MAKEALL to run the config step with -s ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100913/4660f470/attachment.pgp

#2 lore raw

PATCH 1/1 silence awk command display during build

Quoted 6 lines · On Mon, 13 Sep 2010 21:59:21 -0400 Mike Frysinger <[email protected]> wrote:
Quoted 3 lines · On Monday, September 13, 2010 21:17:30 Kim Phillips wrote:

[u-boot next]$ ./MAKEALL 83xx
awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg

Quoted 1 line

.boards.depend Configuring for ve8313 board...

how about we change MAKEALL to run the config step with -s ?

not sure how that relates to this patch...afaict, make board config, MAKEALL or non:

[u-boot next]$ make distclean && make ve8313_config
Generating include/autoconf.mk
Generating include/autoconf.mk.dep
awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg > .boards.depend Configuring for ve8313 board...
[u-boot next]$

..should be silent except for announcing what board its configuring.

Kim

#3 lore raw

PATCH 1/1 silence awk command display during build

Quoted 13 lines · On Tuesday, September 14, 2010 14:41:16 Kim Phillips wrote:
Quoted 8 lines · On Mon, 13 Sep 2010 21:59:21 -0400 Mike Frysinger wrote:
Quoted 5 lines · On Monday, September 13, 2010 21:17:30 Kim Phillips wrote:

[u-boot next]$ ./MAKEALL 83xx
awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg

Quoted 1 line

.boards.depend Configuring for ve8313 board...

how about we change MAKEALL to run the config step with -s ?

not sure how that relates to this patch...afaict, make board config, MAKEALL or non:

Quoted 8 lines

[u-boot next]$ make distclean && make ve8313_config
Generating include/autoconf.mk
Generating include/autoconf.mk.dep
awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg

Quoted 1 line

.boards.depend Configuring for ve8313 board...

[u-boot next]$

..should be silent except for announcing what board its configuring.

instead of silencing a somewhat complicated command that could break the build system if it goes wrong, use the mechanisms already in place if you want nice & concise output -- the --silent option to make. i dont see a problem with this output you've quoted in the normal run of things.

so to get back to your patch, if you want "pretty" MAKEALL output, change MAKEALL to call make with "-s".
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100914/99f3b6a7/attachment.pgp

#4 lore raw

PATCH v2 1/1 silence config step commands display during MAKEALL builds

[u-boot next]$ ./MAKEALL 83xx
awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg > .boards.depend Configuring for ve8313 board...

---
applies to u-boot.git's next branch.

 MAKEALL |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
MAKEALL +1 -1
index 761038e..1b506d6 100755
@@ -727,7 +727,7 @@ build_target() {
 	target=$1
 
 	${MAKE} distclean >/dev/null
-	${MAKE} ${target}_config
+	${MAKE} -s ${target}_config
 
 	${MAKE} ${JOBS} all 2>&1 >${LOG_DIR}/$target.MAKELOG \
 				| tee ${LOG_DIR}/$target.ERR
Signature · 1 line
1.7.2.1
#5 lore raw

PATCH v2 1/1 silence config step commands display during MAKEALL builds

Quoted 5 lines · On Tuesday, September 14, 2010 15:48:16 Kim Phillips wrote:

[u-boot next]$ ./MAKEALL 83xx
awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg

Quoted 1 line

.boards.depend Configuring for ve8313 board...

-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100914/d05e721c/attachment.pgp

#6 lore raw

PATCH v2 1/1 silence config step commands display during MAKEALL builds

In reply to Kim Phillips

Dear Kim Phillips,

Quoted 10 lines · In message <[email protected]> you wrote:

[u-boot next]$ ./MAKEALL 83xx
awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg > .boards.depend Configuring for ve8313 board...

---
applies to u-boot.git's next branch.

 MAKEALL |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied to "next" branch, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You get a wonderful view from the point of no return.
                                    - Terry Pratchett, _Making_Money_
#7 lore raw

PATCH 1/1 silence awk command display during build

In reply to Mike Frysinger

Dear Mike Frysinger,

Quoted 5 lines · In message <[email protected]> you wrote:

instead of silencing a somewhat complicated command that could break the build system if it goes wrong, use the mechanisms already in place if you want nice & concise output -- the --silent option to make. i dont see a problem with this output you've quoted in the normal run of things.

I do. It is a change in behaviour and potentially braks a number of build systems.

Please let's fix this so the previous behaviour is restored.

#8 lore raw

PATCH 1/1 silence awk command display during build

Quoted 9 lines · On Tuesday, September 14, 2010 18:04:29 Wolfgang Denk wrote:
Quoted 5 lines · Mike Frysinger

instead of silencing a somewhat complicated command that could break the build system if it goes wrong, use the mechanisms already in place if you want nice & concise output -- the --silent option to make. i dont see a problem with this output you've quoted in the normal run of things.

I do. It is a change in behaviour and potentially braks a number of build systems.

as Kim highlighted, this has already been "broken" somewhat by other commits as sometimes output can be shown before the config line. so if it was breaking people, wouldnt they have complained by now ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100914/245a03e5/attachment.pgp

#9 lore raw

PATCH 1/1 silence awk command display during build

Quoted 8 lines · On Tue, 14 Sep 2010 22:09:58 -0400 Mike Frysinger <[email protected]> wrote:
Quoted 7 lines · On Tuesday, September 14, 2010 18:04:29 Wolfgang Denk wrote:
Quoted 5 lines · Mike Frysinger

instead of silencing a somewhat complicated command that could break the build system if it goes wrong, use the mechanisms already in place if you want nice & concise output -- the --silent option to make. i dont see a problem with this output you've quoted in the normal run of things.

Quoted 5 lines
Quoted 2 lines

I do. It is a change in behaviour and potentially braks a number of build systems.

as Kim highlighted, this has already been "broken" somewhat by other commits as sometimes output can be shown before the config line. so if it was

what commits? awk is the only command in the area that isn't silenced in make. wrt the output...I believe that was distclean speaking..make config only emits "configuring for blah.."

Quoted 1 line

breaking people, wouldnt they have complained by now ?

both the MAKEALL and make blah_config behaviour have changed since:

commit 866b5619fbc15db8a88954961bbc371c2c9c8b86

Author: Mike Frysinger <[email protected]>
Date:   Wed Aug 11 18:52:36 2010 -0400

Makefile: restore support for board shortcut targets

I was originally confused because build verbosity is has a reversed sense in u-boot (make is by default noisy, needs silencing vs. linux' make is by default 'neat', needs verbosity flag set to be noisy), but I tend to agree with WD on this one. Else, e.g., why isn't the mkconfig invocation noisy?

Anyway, for backward noise compatible operation, the 1st patch in this thread should be applied.

Kim

#10 lore raw

PATCH 1/1 silence awk command display during build

Quoted 14 lines · On Wednesday, September 15, 2010 12:12:32 Kim Phillips wrote:

On Tue, 14 Sep 2010 22:09:58 -0400

Quoted 11 lines · Mike Frysinger
Quoted 9 lines · On Tuesday, September 14, 2010 18:04:29 Wolfgang Denk wrote:
Quoted 5 lines · Mike Frysinger

instead of silencing a somewhat complicated command that could break the build system if it goes wrong, use the mechanisms already in place if you want nice & concise output -- the --silent option to make. i dont see a problem with this output you've quoted in the normal run of things.

I do. It is a change in behaviour and potentially braks a number of build systems.

Quoted 7 lines
Quoted 3 lines

as Kim highlighted, this has already been "broken" somewhat by other commits as sometimes output can be shown before the config line. so if it was

what commits? awk is the only command in the area that isn't silenced in make. wrt the output...I believe that was distclean speaking..make config only emits "configuring for blah.."

it is not tied strictly to disclean. run config targets multiple times and see the same thing. make ve8313; make ve8313.

Quoted 3 lines
Quoted 1 line

breaking people, wouldnt they have complained by now ?

both the MAKEALL and make blah_config behaviour have changed since:

behavior changed !== breakage

Quoted 5 lines

I was originally confused because build verbosity is has a reversed sense in u-boot (make is by default noisy, needs silencing vs. linux' make is by default 'neat', needs verbosity flag set to be noisy), but I tend to agree with WD on this one. Else, e.g., why isn't the mkconfig invocation noisy?

yes, the current behavior is pretty squirrelly imo
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100915/1db44002/attachment.pgp

#11 lore raw

PATCH 1/1 silence awk command display during build

Dear Mike Frysinger,

Quoted 2 lines · In message <[email protected]> you wrote:
Quoted 2 lines
Quoted 2 lines

breaking people, wouldnt they have complained by now ?

Eventually they don't complain because they did not use this feature (yet).

Quoted 3 lines
Quoted 1 line

both the MAKEALL and make blah_config behaviour have changed since:

behavior changed !== breakage

OK.

Please undo that behaviour change anyway.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A fail-safe circuit will destroy others.                 -- Klipstein
#12 lore raw

PATCH 1/1 silence awk command display during build

Quoted 7 lines · On Wednesday, September 15, 2010 15:28:58 Wolfgang Denk wrote:
Quoted 2 lines · Mike Frysinger
Quoted 1 line

both the MAKEALL and make blah_config behaviour have changed since:

behavior changed !== breakage

OK.

Please undo that behaviour change anyway.

i dont really want this to be completely silenced all the time. introduce a variable to prefix things with for people to control ?
Q_BUILD = @
...

	$(Q_BUILD).....

-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100915/a94a1f2d/attachment.pgp

#13 lore raw

PATCH 1/1 silence awk command display during build

Dear Mike Frysinger,

Quoted 6 lines · In message <[email protected]> you wrote:

i dont really want this to be completely silenced all the time. introduce a variable to prefix things with for people to control ?
Q_BUILD = @
...

	$(Q_BUILD).....

NAK. Please do not add such mess to the Makefile. It does not belong there. If you want such behaviour, it should be added to the make command itself.

I repeat myself, but all this cmd_* / quiet_cmd_* stuff etc. we see in the Linux kernel Makefiles (and copied around into a zillion of other projects) does not belong to the Makefile; it should be implemented inside make itself.

I never understood why nobody bothered to solve the problem at the root.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Steal five dollars and you were a petty  thief.  Steal  thousands  of
dollars and you are either a government or a hero.
                                   - Terry Pratchett, _Going_Postal_
#14 lore raw

PATCH 1/1 silence awk command display during build

Quoted 11 lines · On Wednesday, September 15, 2010 17:25:25 Wolfgang Denk wrote:
Quoted 6 lines · Mike Frysinger

i dont really want this to be completely silenced all the time. introduce a variable to prefix things with for people to control ? Q_BUILD = @
...

	$(Q_BUILD).....

NAK. Please do not add such mess to the Makefile. It does not belong there. If you want such behaviour, it should be added to the make command itself.

funny, i could say the same exact thing about "quiet" config output. make already has an option to accomplish exactly that: use the --silent option. i dont see why you would ban pretty output in favor of using standard make options while at the same exact time you want to change u-boot's make code so that it produces pretty output instead of using standard make options that already exist.

how are these situations any different ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100916/dc8ca6b2/attachment.pgp