linux-next: build failure after merge of the final tree (maybe percpu tree related)
Subsystems (2)
Hi all,
After merging the final tree, next-20100909 and next-20100910 builds (alpha defconfig) failed like this:
In file included from mm/percpu.c:71:arch/alpha/include/asm/cacheflush.h: In function 'flush_icache_user_range':arch/alpha/include/asm/cacheflush.h:53: error: dereferencing pointer to incomplete type
Signature · 3 lines
Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
PATCH 1/1 alpha: fix build breakage in asm/cacheflush.h
Alpha SMP flush_icache_user_range() is implemented as an inline function inside include/asm/cacheflush.h. It dereferences @current but doesn't include linux/sched.h and thus causes build failure if linux/sched.h wasn't included previously. Fix it by including the needed header file explicitly.
--- arch/alpha/include/asm/cacheflush.h | 2 ++ 1 file changed, 2 insertions(+)
arch/alpha/include/asm/cacheflush.h +2 -0
@@ -43,6 +43,8 @@ extern void smp_imb(void);/* ??? Ought to use this in arch/alpha/kernel/signal.c too. */ #ifndef CONFIG_SMP +#include <linux/sched.h> +extern void __load_new_mm_context (struct mm_struct *); static inline void flush_icache_user_range(struct vm_area_struct *vma, struct page *page,
Matt Turner
maintainerRe: [PATCH] alpha: fix build breakage in asm/cacheflush.h
Quoted 23 lines · Tejun Heo
Alpha SMP
flush_icache_user_range()is implemented as an inline function insideinclude/asm/cacheflush.h. It dereferences @current but doesn't includelinux/sched.hand thus causes build failure iflinux/sched.hwasn't included previously. Fix it by including the needed header file explicitly.Signed-off-by Tejun Heo <[email protected]>Reported-by Stephen Rothwell <[email protected]>---
arch/alpha/include/asm/cacheflush.h | 2 ++1 file changed, 2 insertions(+)arch/alpha/include/asm/cacheflush.h +2
-0@@ -43,6 +43,8 @@ extern void smp_imb(void); /* ??? Ought to use this in arch/alpha/kernel/signal.c too. */ #ifndef CONFIG_SMP +#include <linux/sched.h> + extern void __load_new_mm_context(struct mm_struct *);
Quoted 2 lines
static inline void
flush_icache_user_range(structvm_area_struct*vma, struct page *page,
Thanks! Applied this to my tree and sent it to Linus.
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html