Skip to contentSkip to conversation

hid: Fix for A4Tech RP-649 horizontal scrollwheel

PATCH In review Lech Perczak 3 participants 3 messages Sep 9, 2010 – Sep 14, 2010 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hid: Fix for A4Tech RP-649 horizontal scrollwheel

From: Lech Perczak <[email protected]>

- Barely add USB device ID of A4Tech RF mouse receiver (09da:001a) used with RP-649(Z) mice to enable fix for their horizontal scroll wheel behaviour, and associate it with B8 hack.

---

hid-a4tech.c renamed from hid-a4tech.c.orig +2 -0
diff -up hid/hid-a4tech.c.orig hid/hid-a4tech.c
@@ -133,6 +133,8 @@
 		.driver_data = A4_2WHEEL_MOUSE_HACK_7 },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_A4TECH, USB_DEVICE_ID_A4TECH_X5_005D),
 		.driver_data = A4_2WHEEL_MOUSE_HACK_B8 },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_A4TECH, USB_DEVICE_ID_A4TECH_RP_649),
+		.driver_data = A4_2WHEEL_MOUSE_HACK_B8 },
 	{ }
 };
 MODULE_DEVICE_TABLE(hid, a4_devices);
hid-ids.h renamed from hid-ids.h.orig +1 -0
diff -up hid/hid-ids.h.orig hid/hid-ids.h
@@ -25,6 +25,7 @@
 #define USB_VENDOR_ID_A4TECH		0x09da
 #define USB_DEVICE_ID_A4TECH_WCP32PU	0x0006
 #define USB_DEVICE_ID_A4TECH_X5_005D	0x000a
+#define USB_DEVICE_ID_A4TECH_RP_649	0x001a
 
 #define USB_VENDOR_ID_AASHIMA		0x06d6
 #define USB_DEVICE_ID_AASHIMA_GAMEPAD	0x0025
#1 lore raw
Quoted 24 lines · Lech Perczak

From: Lech Perczak <[email protected]>

- Barely add USB device ID of A4Tech RF mouse receiver (09da:001a) used with RP-649(Z) mice to enable fix for their horizontal scroll wheel behaviour, and associate it with B8 hack.

---
diff -up hid/hid-a4tech.c.orig hid/hid-a4tech.c

hid-a4tech.c renamed from hid-a4tech.c.orig +2 -0
@@ -133,6 +133,8 @@
 		.driver_data = A4_2WHEEL_MOUSE_HACK_7 },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_A4TECH, USB_DEVICE_ID_A4TECH_X5_005D),
 		.driver_data = A4_2WHEEL_MOUSE_HACK_B8 },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_A4TECH, USB_DEVICE_ID_A4TECH_RP_649),
+		.driver_data = A4_2WHEEL_MOUSE_HACK_B8 },
 	{ }
 };
 MODULE_DEVICE_TABLE(hid, a4_devices);

diff -up hid/hid-ids.h.orig hid/hid-ids.h

hid-ids.h line 31

Quoted 7 lines
hid-ids.h renamed from hid-ids.h.orig +1 -0
@@ -25,6 +25,7 @@
 #define USB_VENDOR_ID_A4TECH		0x09da
 #define USB_DEVICE_ID_A4TECH_WCP32PU	0x0006
 #define USB_DEVICE_ID_A4TECH_X5_005D	0x000a
+#define USB_DEVICE_ID_A4TECH_RP_649	0x001a
 
 #define USB_VENDOR_ID_AASHIMA		0x06d6
 #define USB_DEVICE_ID_AASHIMA_GAMEPAD	0x0025

You'd also need to add this device to hid_blacklist[] in hid-core.c, otherwise hid-a4tech driver wouldn't automatically bind to the device.

Could you please fix that up in your patch and resend it to me?

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
#2 lore raw
In reply to Lech Perczak
Quoted 3 lines · Lech Perczak

From: Lech Perczak <[email protected]>

- Barely add USB device ID of A4Tech RF mouse receiver (09da:001a)

I think you were looking for word "simply".

Quoted 3 lines

used with RP-649(Z) mice to enable fix for their horizontal scroll wheel behaviour, and associate it with B8 hack.

Signature · 1 line
Dmitry