Skip to contentSkip to conversation

host tools: create the host sed in $(O)/host/

PATCH New Yann E. MORIN 3 participants 3 messages Sep 13, 2010 – Sep 18, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 host tools: create the host sed in $(O)/host/

The host sed does not belong to $(O)toolchain/ but really belongs to $(O)/host/

---
 package/sed/sed.mk |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
package/sed/sed.mk +3 -5
index c393dd9..deae71d 100644
@@ -7,7 +7,7 @@ SED_VERSION:=4.2.1
 SED_SOURCE:=sed-$(SED_VERSION).tar.gz
 SED_SITE:=$(BR2_GNU_MIRROR)/sed
 SED_CAT:=$(ZCAT)
-SED_DIR1:=$(TOOLCHAIN_DIR)/sed-$(SED_VERSION)
+SED_DIR1:=$(HOST_DIR)/sed-$(SED_VERSION)
 SED_DIR2:=$(BUILD_DIR)/sed-$(SED_VERSION)
 SED_BINARY:=sed/sed
 SED_TARGET_BINARY:=bin/sed
@@ -15,7 +15,7 @@ ifeq ($(BR2_LARGEFILE),y)
 SED_CPPFLAGS=-D_FILE_OFFSET_BITS=64
 endif
 #HOST_SED_DIR:=$(STAGING_DIR)
-HOST_SED_DIR:=$(TOOLCHAIN_DIR)
+HOST_SED_DIR:=$(HOST_DIR)
 SED:=$(HOST_SED_DIR)/bin/sed -i -e
 HOST_SED_BINARY:=$(shell package/sed/sedcheck.sh)
 HOST_SED_IF_ANY=$(shell toolchain/dependencies/check-host-sed.sh)
@@ -33,9 +33,7 @@ sed-source: $(DL_DIR)/$(SED_SOURCE)
 #
 #############################################################
 $(SED_DIR1)/.unpacked: $(DL_DIR)/$(SED_SOURCE)
-	mkdir -p $(TOOLCHAIN_DIR)
-	mkdir -p $(HOST_SED_DIR)/bin
-	$(SED_CAT) $(DL_DIR)/$(SED_SOURCE) | tar -C $(TOOLCHAIN_DIR) $(TAR_OPTIONS) -
+	$(SED_CAT) $(DL_DIR)/$(SED_SOURCE) | tar -C $(HOST_DIR) $(TAR_OPTIONS) -
 	toolchain/patch-kernel.sh $(SED_DIR1) package/sed/ configure.patch
 	$(CONFIG_UPDATE) $(SED_DIR1)/config
 	touch $@
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 host tools: create the host sed in $(O)/host/

Hello,

Quoted 2 lines · On Tue, 14 Sep 2010 01:27:14 +0200 "Yann E. MORIN"…

The host sed does not belong to $(O)toolchain/ but really belongs to $(O)/host/

In my opinion, the host-sed does not belong anywhere, we could just use the real host sed, and remove all the crap to detect if the host sed is good or not, the symlinking stuff, etc.

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 host tools: create the host sed in $(O)/host/

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> Hello,
Thomas> On Tue, 14 Sep 2010 01:27:14 +0200

Quoted 2 lines · Thomas> "Yann E. MORIN" <[email protected]> wrote:
Quoted 2 lines

The host sed does not belong to $(O)toolchain/ but really belongs to $(O)/host/

Thomas> In my opinion, the host-sed does not belong anywhere, we could just use Thomas> the real host sed, and remove all the crap to detect if the host sed is Thomas> good or not, the symlinking stuff, etc.

Agreed. Care to make a patch?

Signature · 1 line
Bye, Peter Korsgaard