FW_LOADER: fix kconfig dependency warning on HOTPLUG
PATCH 1/1 FW_LOADER: fix kconfig dependency warning on HOTPLUG
From: Randy Dunlap <[email protected]>
Fix kconfig dependency warning for FW_LOADER.
Lots of drivers select FW_LOADER without bothering to depend on HOTPLUG and/or without selecting HOTPLUG. A kernel builds fine when FW_LOADER is enabled, whether HOTPLUG is enabled or not, and a kernel config file (make oldconfig) is not changed by this patch. (Yes, drivers/base/firmware_class.c uses interfaces from linux/kobject.h, which does have some CONFIG_HOTPLUG dependencies, but this patch does not change that.)
warning: (MICROCODE || MICROCODE_INTEL && MICROCODE || MICROCODE_AMD && MICROCODE || PCMCIA_LOAD_CIS && PCCARD && PCMCIA && EXPERIMENTAL || USB_IRDA && NET && IRDA && USB || BT_HCIBCM203X && NET && BT && USB || BT_HCIBFUSB && NET && BT && USB || BT_HCIBT3C && NET && BT && PCMCIA || BT_MRVL_SDIO && NET
...
!STAGING_EXCLUDE_BUILD && USB && (X86 || ARM) && WLAN || DRM_NOUVEAU && STAGING && !STAGING_EXCLUDE_BUILD && DRM && PCI || TI_ST && STAGING && !STAGING_EXCLUDE_BUILD && RFKILL || DELL_RBU && X86) selects FW_LOADER which has unmet direct dependencies (HOTPLUG) (5200 byte line reduced a lot)
--- drivers/base/Kconfig | 1 - 1 file changed, 1 deletion(-)
BTW, drivers/base/firmware_class.c should #include <linux/kobject.h>.
drivers/base/Kconfig +0 -1
@@ -71,7 +71,6 @@ config PREVENT_FIRMWARE_BUILD config FW_LOADER tristate "Userspace firmware loading support" if EMBEDDED - depends on HOTPLUG default y ---help--- This option is provided for the case where no in-kernel-tree modules
Quoted 2 lines · Randy Dunlap
BTW,
drivers/base/firmware_class.cshould #include <linux/kobject.h>.
Why, it looks like it builds properly now, right?
thanks,
greg k-h
Quoted 5 lines · Greg KH
Quoted 2 lines · Randy Dunlap
BTW,
drivers/base/firmware_class.cshould #include <linux/kobject.h>.Why, it looks like it builds properly now, right?
Yes, it builds because (apparently) some other header file is causing <linux/kobject.h> to be sucked in. That's not how we prefer to have header files used.
See Documentation/SubmitChecklist, item #1 (from Stephen Rothwell):
1: If you use a facility then #include the file that defines/declares
that facility. Don't depend on other header files pulling in ones that you use.
Signature · 2 lines
~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
Quoted 11 lines · Randy Dunlap
Quoted 5 lines · Greg KH
Quoted 2 lines · Randy Dunlap
BTW,
drivers/base/firmware_class.cshould #include <linux/kobject.h>.Why, it looks like it builds properly now, right?
Yes, it builds because (apparently) some other header file is causing <
linux/kobject.h> to be sucked in. That's not how we prefer to have header files used.
Quoted 5 lines
See
Documentation/SubmitChecklist, item #1 (from Stephen Rothwell):1: If you use a facility then #include the file that defines/declares
that facility. Don't depend on other header files pulling in ones that you use.
Fair enough, care to send a patch? :)
thanks,
greg k-h