Skip to contentSkip to conversation

bna: off by one

PATCH Applied Dan Carpenter 3 participants 3 messages Sep 18, 2010 – Sep 19, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bna: off by one

The mod->mbhdlr[] array has BFI_MC_MAX elements.

drivers/net/bna/bfa_ioc.c +1 -1
index caa45c2..73493de 100644
@@ -1514,7 +1514,7 @@ bfa_nw_ioc_mbox_isr(struct bfa_ioc *ioc)
 		return;
 	}
 
-	if ((mc > BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn = NULL))
+	if ((mc >= BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn = NULL))
 		return;
 
 	mod->mbhdlr[mc].cbfn(mod->mbhdlr[mc].cbarg, &m);
#1 lore raw

-----Original Message-----
From: Dan Carpenter [mailto:[email protected]]
Sent: Saturday, September 18, 2010 4:42 PM
To: Rasesh Mody
Cc: Debashis Dutt; David S. Miller; [email protected]; [email protected]
Subject: [patch -next] bna: off by one

The mod->mbhdlr[] array has BFI_MC_MAX elements.

drivers/net/bna/bfa_ioc.c +1 -1
index caa45c2..73493de 100644
@@ -1514,7 +1514,7 @@ bfa_nw_ioc_mbox_isr(struct bfa_ioc *ioc)
 		return;
 	}
 
-	if ((mc > BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn = NULL))
+	if ((mc >= BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn = NULL))
 		return;
 
 	mod->mbhdlr[mc].cbfn(mod->mbhdlr[mc].cbarg, &m);

Dan,

Patch looks good.

Thanks
--Debashis