Skip to contentSkip to conversation

uinput: add devname alias to allow module on-demand load

PATCH In review Kay Sievers 2 participants 5 messages Aug 19, 2010 – Sep 19, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uinput: add devname alias to allow module on-demand load

From: Kay Sievers <[email protected]>
Subject: uinput: add devname alias to allow module on-demand load

Recent modprobe and udev versions allow to create device nodes for modules which are not loaded. Only the first access will cause the in-kernel module loader to pull-in the module. Systems which never access the device node will not needlessly load the module, and no longer need init scripts or other facilities to unconditionally load it.

---
 drivers/input/misc/uinput.c |    2 ++
 include/linux/miscdevice.h  |    1 +
 include/linux/uinput.h      |    1 -
 3 files changed, 3 insertions(+), 1 deletion(-)
drivers/input/misc/uinput.c +2 -0
@@ -806,6 +806,8 @@ static struct miscdevice uinput_misc = {
 	.minor		= UINPUT_MINOR,
 	.name		= UINPUT_NAME,
 };
+MODULE_ALIAS_MISCDEV(UINPUT_MINOR);
+MODULE_ALIAS("devname:" UINPUT_NAME);
 
 static int __init uinput_init(void)
 {
include/linux/miscdevice.h +1 -0
@@ -33,6 +33,7 @@
 #define MWAVE_MINOR		219	/* ACP/Mwave Modem */
 #define MPT_MINOR		220
 #define MPT2SAS_MINOR		221
+#define UINPUT_MINOR		223
 #define HPET_MINOR		228
 #define FUSE_MINOR		229
 #define KVM_MINOR		232
include/linux/uinput.h +0 -1
@@ -37,7 +37,6 @@
 #define UINPUT_VERSION		3
 
 #ifdef __KERNEL__
-#define UINPUT_MINOR		223
 #define UINPUT_NAME		"uinput"
 #define UINPUT_BUFFER_SIZE	16
 #define UINPUT_NUM_REQUESTS	16
#1 lore raw
Quoted 9 lines · Kay Sievers

From: Kay Sievers <[email protected]>
Subject: uinput: add devname alias to allow module on-demand load

Recent modprobe and udev versions allow to create device nodes for modules which are not loaded. Only the first access will cause the in-kernel module loader to pull-in the module. Systems which never access the device node will not needlessly load the module, and no longer need init scripts or other facilities to unconditionally load it.

Dmitry?

Kay

maintainer
#2 lore raw
Quoted 4 lines · Kay Sievers
Quoted 3 lines · Kay Sievers

From: Kay Sievers <[email protected]>
Subject: uinput: add devname alias to allow module on-demand load

Quoted 9 lines
Quoted 6 lines

Recent modprobe and udev versions allow to create device nodes for modules which are not loaded. Only the first access will cause the in-kernel module loader to pull-in the module. Systems which never access the device node will not needlessly load the module, and no longer need init scripts or other facilities to unconditionally load it.

Dmitry?

[dtor@hammer work]$ git describe --contains 8905aaafb4b5d9764c5b4b54c7d03eb41bb0a7e9 v2.6.36-rc3~19^2~2

;)

Signature · 1 line
Dmitry
#3 lore raw
Quoted 12 lines · Dmitry Torokhov
Quoted 11 lines · Kay Sievers
Quoted 9 lines · Kay Sievers

From: Kay Sievers <[email protected]>
Subject: uinput: add devname alias to allow module on-demand load

Recent modprobe and udev versions allow to create device nodes for modules which are not loaded. Only the first access will cause the in-kernel module loader to pull-in the module. Systems which never access the device node will not needlessly load the module, and no longer need init scripts or other facilities to unconditionally load it.

Quoted 4 lines
Quoted 1 line

Dmitry?

[dtor@hammer work]$ git describe --contains 8905aaafb4b5d9764c5b4b54c7d03eb41bb0a7e9 v2.6.36-rc3~19^2~2

Awesome!
So much for stupidly waiting-for-reply instead of just checking the reality. :)

Thanks,
Kay

maintainer
#4 lore raw
Quoted 14 lines · Kay Sievers
Quoted 12 lines · Dmitry Torokhov
Quoted 11 lines · Kay Sievers
Quoted 9 lines · Kay Sievers

From: Kay Sievers <[email protected]>
Subject: uinput: add devname alias to allow module on-demand load

Recent modprobe and udev versions allow to create device nodes for modules which are not loaded. Only the first access will cause the in-kernel module loader to pull-in the module. Systems which never access the device node will not needlessly load the module, and no longer need init scripts or other facilities to unconditionally load it.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Dmitry?

[dtor@hammer work]$ git describe --contains 8905aaafb4b5d9764c5b4b54c7d03eb41bb0a7e9 v2.6.36-rc3~19^2~2

Awesome!
So much for stupidly waiting-for-reply instead of just checking the reality. :)

Well, my fault really. Normally I try to let people know when I accept a patch but I neglected doing this in this case...

Signature · 1 line
Dmitry