Skip to contentSkip to conversation

oprofile: Add Support for Intel CPU Family 6 / Model 29

PATCH Applied Jiri Olsa 5 participants 11 messages Sep 21, 2010 – Sep 27, 2010 x86

lore
Share & tools
lore

Jiri Olsa

author
#0 lore raw

PATCH 1/1 oprofile: Add Support for Intel CPU Family 6 / Model 29

This patch adds CPU type detection for dunnington processor (Family 6 / Model 29) to be identified as core 2 family cpu type (wikipedia source).

I tested oprofile on Intel(R) Xeon(R) CPU E7440 reporting itself as model 29, and it runs without an issue.

wbr,
jirka

---
 arch/x86/oprofile/nmi_int.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/oprofile/nmi_int.c +1 -0
index 009b819..f1575c9 100644
@@ -674,6 +674,7 @@ static int __init ppro_init(char **cpu_type)
 	case 0x0f:
 	case 0x16:
 	case 0x17:
+	case 0x1d:
 		*cpu_type = "i386/core_2";
 		break;
 	case 0x1a:
Signature · 1 line
1.7.1
#1 lore raw
Quoted 11 lines · Jiri Olsa

This patch adds CPU type detection for dunnington processor (Family 6 / Model 29) to be identified as core 2 family cpu type (wikipedia source).

I tested oprofile on Intel(R) Xeon(R) CPU E7440 reporting itself as model 29, and it runs without an issue.

wbr,
jirka

Andi,

found this spec:

http://www.intel.com/Assets/en_US/PDF/specupdate/320336.pdf

Please ack.

Thanks,

-Robert

Quoted 20 lines
---
 arch/x86/oprofile/nmi_int.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/oprofile/nmi_int.c +1 -0
index 009b819..f1575c9 100644
@@ -674,6 +674,7 @@ static int __init ppro_init(char **cpu_type)
 	case 0x0f:
 	case 0x16:
 	case 0x17:
+	case 0x1d:
 		*cpu_type = "i386/core_2";
 		break;
 	case 0x1a:
Signature · 1 line
1.7.1
Signature · 2 lines
Advanced Micro Devices, Inc.
Operating System Research Center
Acked-by
#2 lore raw
Quoted 15 lines · Jiri Olsa
Quoted 8 lines

This patch adds CPU type detection for dunnington processor (Family 6 / Model 29)
to be identified as core 2 family cpu type (wikipedia source).

I tested oprofile on Intel(R) Xeon(R) CPU E7440 reporting itself as model 29,
and it runs without an issue.

Quoted 5 lines

wbr,
jirka

Quoted 7 lines

Andi,

found this spec:

http://www.intel.com/Assets/en_US/PDF/specupdate/320336.pdf

Please ack.

Thanks,
-Andi

#3 lore raw
In reply to Jiri Olsa
Quoted 11 lines · Jiri Olsa

This patch adds CPU type detection for dunnington processor (Family 6 / Model 29) to be identified as core 2 family cpu type (wikipedia source).

I tested oprofile on Intel(R) Xeon(R) CPU E7440 reporting itself as model 29, and it runs without an issue.

wbr,
jirka

Applied to oprofile/urgent. Thanks Jiri.

Ingo,

please pull for tip/perf/urgent:

git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent

This should be ff-only, pull request see below.

Thanks,

-Robert

Quoted 20 lines
---
 arch/x86/oprofile/nmi_int.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/oprofile/nmi_int.c +1 -0
index 009b819..f1575c9 100644
@@ -674,6 +674,7 @@ static int __init ppro_init(char **cpu_type)
 	case 0x0f:
 	case 0x16:
 	case 0x17:
+	case 0x1d:
 		*cpu_type = "i386/core_2";
 		break;
 	case 0x1a:
Signature · 1 line
1.7.1

The following changes since commit 068e35eee9ef98eb4cab55181977e24995d273be:

hw breakpoints: Fix pid namespace bug (2010-09-17 04:42:59 +0200)

are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent

Jiri Olsa (1):
oprofile: Add Support for Intel CPU Family 6 / Model 29

 arch/x86/oprofile/nmi_int.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Signature · 2 lines
Advanced Micro Devices, Inc.
Operating System Research Center
#4 lore raw

[GIT PULL] oprofile fixes

Ingo,

please pull for tip/perf/urgent:

git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent

Thanks,

-Robert

The following changes since commit 068e35eee9ef98eb4cab55181977e24995d273be:

hw breakpoints: Fix pid namespace bug (2010-09-17 04:42:59 +0200)

are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent

Jiri Olsa (1):
oprofile: Add Support for Intel CPU Family 6 / Model 29

 arch/x86/oprofile/nmi_int.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Signature · 2 lines
Advanced Micro Devices, Inc.
Operating System Research Center
#5 lore raw

Re: [GIT PULL] oprofile fixes

Quoted 14 lines · Robert Richter

Ingo,

please pull for tip/perf/urgent:

git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent

Thanks,

-Robert

The following changes since commit 068e35eee9ef98eb4cab55181977e24995d273be:

hw breakpoints: Fix pid namespace bug (2010-09-17 04:42:59 +0200)

Quoted 8 lines

are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent

Jiri Olsa (1):
oprofile: Add Support for Intel CPU Family 6 / Model 29

 arch/x86/oprofile/nmi_int.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Pulled, thanks Robert!

Ingo

#6 lore raw
In reply to Jiri Olsa

arch/x86/oprofile/nmi_int.c static int __init ppro_init(char **cpu_type) · line 680

Quoted 10 lines · Jiri Olsa
arch/x86/oprofile/nmi_int.c +1 -0
@@ -674,6 +674,7 @@ static int __init ppro_init(char **cpu_type)
        case 0x0f:
        case 0x16:
        case 0x17:
+       case 0x1d:
                *cpu_type = "i386/core_2";
                break;
        case 0x1a:

Just curious about the other missing IDs: this now supports all Core microarchitecture CPUs, but only some Nehalem/Westmere ones.

There is support for 0x1a (Bloomfield/Gainestown) and 0x2e (Beckton), but not for the much more common 0x1e (Lynnfield/Clarksfield/Jasper Forest), 0x25 (Clarkdale/Arrandale) and 0x26 (Gulftown/Westmere-EP).

Shouldn't those be added as well?

When you're there, it probably also wouldn't hurt to fill in the blanks of some of the older CPUs like Tolopai (0x15) and newer Atoms (0x1c).

Arnd

#7 lore raw
Quoted 11 lines · Arnd Bergmann

Just curious about the other missing IDs: this now supports all Core microarchitecture CPUs, but only some Nehalem/Westmere ones.

There is support for 0x1a (Bloomfield/Gainestown) and 0x2e (Beckton), but not for the much more common 0x1e (Lynnfield/Clarksfield/Jasper Forest), 0x25 (Clarkdale/Arrandale) and 0x26 (Gulftown/Westmere-EP).

Shouldn't those be added as well?

When you're there, it probably also wouldn't hurt to fill in the blanks of some of the older CPUs like Tolopai (0x15) and newer Atoms (0x1c).

Yes, would be nice to have also an update for the remaining unsupported models. Andi?

Thanks,

-Robert

Signature · 2 lines
Advanced Micro Devices, Inc.
Operating System Research Center
#8 lore raw
Quoted 10 lines · Arnd Bergmann
Quoted 9 lines

Just curious about the other missing IDs: this now supports all Core microarchitecture CPUs, but only some Nehalem/Westmere ones.

There is support for 0x1a (Bloomfield/Gainestown) and 0x2e (Beckton), but
not for the much more common 0x1e (Lynnfield/Clarksfield/Jasper Forest), 0x25 (Clarkdale/Arrandale) and 0x26 (Gulftown/Westmere-EP).

Shouldn't those be added as well?

Westmere I still hold off because the oprofile user land doesn't have the correct event list yet.

BTW I was thinking in this case to only add the model numbers to the user code and just let it handle arch_perfmon from the kernel.

This should work currently fine and avoid the problem that you need to update user land and kernel in parallel for a new cpu type.

Quoted 6 lines
Quoted 3 lines

When you're there, it probably also wouldn't hurt to fill in the blanks of some of the older CPUs like Tolopai (0x15) and newer Atoms (0x1c).

Yes, would be nice to have also an update for the remaining unsupported models. Andi?

Yes would make sense. I'll ask around if there is a consolidated list somewhere that could be used as a base.

-Andi

#9 lore raw
Quoted 8 lines · Andi Kleen
Quoted 8 lines · Arnd Bergmann
Quoted 7 lines

Just curious about the other missing IDs: this now supports all Core microarchitecture CPUs, but only some Nehalem/Westmere ones.

There is support for 0x1a (Bloomfield/Gainestown) and 0x2e (Beckton), but
not for the much more common 0x1e (Lynnfield/Clarksfield/Jasper Forest), 0x25 (Clarkdale/Arrandale) and 0x26 (Gulftown/Westmere-EP).

I also found reports for 0x2c (Gulftown/Westmere-EP?):

vendor_id : GenuineIntel
cpu family : 6
model : 44
model name : Intel(R) Xeon(R) CPU E5620 @ 2.40GHz

-Robert

Quoted 27 lines
Quoted 2 lines
Quoted 2 lines

Shouldn't those be added as well?

Westmere I still hold off because the oprofile user land doesn't have the correct event list yet.

BTW I was thinking in this case to only add the model numbers to the user code and just let it handle arch_perfmon from the kernel.

This should work currently fine and avoid the problem that you need to update user land and kernel in parallel for a new cpu type.

Quoted 6 lines
Quoted 3 lines

When you're there, it probably also wouldn't hurt to fill in the blanks of some of the older CPUs like Tolopai (0x15) and newer Atoms (0x1c).

Yes, would be nice to have also an update for the remaining unsupported models. Andi?

Yes would make sense. I'll ask around if there is a consolidated list somewhere that could be used as a base.

-Andi

Signature · 2 lines
Advanced Micro Devices, Inc.
Operating System Research Center
#10 lore raw
Quoted 10 lines · Robert Richter
Quoted 8 lines · Andi Kleen
Quoted 8 lines · Arnd Bergmann
Quoted 7 lines

Just curious about the other missing IDs: this now supports all Core microarchitecture CPUs, but only some Nehalem/Westmere ones.

There is support for 0x1a (Bloomfield/Gainestown) and 0x2e (Beckton), but
not for the much more common 0x1e (Lynnfield/Clarksfield/Jasper Forest), 0x25 (Clarkdale/Arrandale) and 0x26 (Gulftown/Westmere-EP).

Quoted 7 lines

I also found reports for 0x2c (Gulftown/Westmere-EP?):

vendor_id : GenuineIntel
cpu family : 6
model : 44
model name : Intel(R) Xeon(R) CPU E5620 @ 2.40GHz

Right, that seems to be the correct one, I must have been looking in the wrong place.

Arnd