x86, CPUID: Correct operator precedence when generating mask
PATCH 2/2 x86, CPUID: Correct operator precedence when generating mask
NEED_<cpufeature> masks used in the CPU feature testing macros are cutoff at the last 5 bits to prevent overflow since the cpu feature words are 32-bit-wide bitfields. Fix this for the PSE and PGE masks too.
This wasn't a real problem since the PSE and PGE bits are nicely < 31.
--- arch/x86/include/asm/required-features.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/include/asm/required-features.h +2 -2
@@ -53,8 +53,8 @@#define NEED_PSE 0#define NEED_PGE 0#else -#define NEED_PSE (1<<(X86_FEATURE_PSE) & 31) -#define NEED_PGE (1<<(X86_FEATURE_PGE) & 31) +#define NEED_PSE (1<<(X86_FEATURE_PSE & 31)) +#define NEED_PGE (1<<(X86_FEATURE_PGE & 31))#endif #define NEED_MSR (1<<(X86_FEATURE_MSR & 31))#define NEED_FXSR (1<<(X86_FEATURE_FXSR & 31))
Signature · 12 lines
1.7.1 -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
H. Peter Anvin
reviewerQuoted 8 lines · Borislav Petkov
NEED_<cpufeature> masks used in the CPU feature testing macros are cutoff at the last 5 bits to prevent overflow since the cpu feature words are 32-bit-wide bitfields. Fix this for the PSE and PGE masks too.
This wasn't a real problem since the PSE and PGE bits are nicely < 31.
Signed-off-by Borislav Petkov <[email protected]>
Since this is a non-manifest bug there really doesn't seem to be any reason to bother stable with it.
-hpa
Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
From: "H. Peter Anvin" <[email protected]>
Date: Mon, Sep 20, 2010 at 11:11:43AM -0400
Quoted 2 lines
Since this is a non-manifest bug there really doesn't seem to be any reason to bother stable with it.
--
From: Borislav Petkov <[email protected]>
Date: Tue Sep 21 13:56:59 CEST 2010
Subject: [PATCH] x86, CPUID: Correct operator precedence when generating mask
NEED_<cpufeature> masks used in the CPU feature testing macros are cutoff at the last 5 bits to prevent overflow since the cpu feature words are 32-bit-wide bitfields. Fix this for the PSE and PGE masks too.
This wasn't a real problem since the PSE and PGE bits are nicely < 31.
--- arch/x86/include/asm/required-features.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/include/asm/required-features.h +2 -2
@@ -53,8 +53,8 @@#define NEED_PSE 0#define NEED_PGE 0#else -#define NEED_PSE (1<<(X86_FEATURE_PSE) & 31) -#define NEED_PGE (1<<(X86_FEATURE_PGE) & 31) +#define NEED_PSE (1<<(X86_FEATURE_PSE & 31)) +#define NEED_PGE (1<<(X86_FEATURE_PGE & 31))#endif #define NEED_MSR (1<<(X86_FEATURE_MSR & 31))#define NEED_FXSR (1<<(X86_FEATURE_FXSR & 31))
Signature · 12 lines
1.7.1 -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632