ASoC: Fix soc-cache buffer overflow bug
PATCH 1/1 ASoC: Fix soc-cache buffer overflow bug
Make sure we stay within the cache boundaries when updating the register cache.
--- sound/soc/soc-cache.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
sound/soc/soc-cache.c +3 -2
@@ -203,8 +203,9 @@ static int snd_soc_8_16_write(struct snd_soc_codec *codec, unsigned int reg, data[1 ] = (value >>8 ) &0xff ; data[2 ] = value &0xff ; -if (!snd_soc_codec_volatile_register (codec, reg)) - reg_cache[reg] = value; +if (!snd_soc_codec_volatile_register (codec, reg) + && reg < codec->driver->reg_cache_size) + reg_cache[reg] = value;if (codec->cache_only) { codec->cache_sync =1 ;
Signature · 1 line
1.7.3
Quoted 4 lines · Dimitris Papastamos
Make sure we stay within the cache boundaries when updating the register cache.
Signed-off-by Dimitris Papastamos <[email protected]>
OK, will wait for Liam's review before applying but as discussed off-line please also do a version of this patch that applies to 2.6.36-rc since it's a bug fix.
Liam Girdwood
Acked-byQuoted 6 lines · Mark Brown
Quoted 4 lines · Dimitris Papastamos
Make sure we stay within the cache boundaries when updating the register cache.
Signed-off-by Dimitris Papastamos <[email protected]>
Quoted 7 lines
OK, will wait for Liam's review before applying but as discussed off-line please also do a version of this patch that applies to 2.6.36-rc since it's a bug fix.
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Signature · 3 lines
Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk
Mark Brown
AppliedQuoted 4 lines · Dimitris Papastamos
Make sure we stay within the cache boundaries when updating the register cache.
Signed-off-by Dimitris Papastamos <[email protected]>
Applied, thanks.