Skip to contentSkip to conversation

mx3fb and ipu_idmac cleanups

PATCH New Michael Grzeschik 2 participants 2 messages Sep 22, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mx3fb and ipu_idmac cleanups

From: Juergen Beisert <[email protected]>

---
 drivers/dma/ipu/ipu_idmac.c |    2 +-
 drivers/video/mx3fb.c       |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/dma/ipu/ipu_idmac.c +1 -1
index cb26ee9..e065703 100644
@@ -321,7 +321,7 @@ static void ipu_ch_param_set_size(union chan_param_mem *params,
 		params->ip.wid2	= 4;		/* Blue bit width - 1 */
 		break;
 	case IPU_PIX_FMT_BGR24:
-		params->ip.bpp	= 1;		/* 24 BPP & RGB PFS */
+		params->ip.bpp	= 1;		/* 24 BPP & BGR PFS */
 		params->ip.pfs	= 4;
 		params->ip.npb	= 7;
 		params->ip.sat	= 2;		/* SAT = 32-bit access */
drivers/video/mx3fb.c +3 -3
index 7cfc170..658f10a 100644
@@ -660,12 +660,12 @@ static uint32_t bpp_to_pixfmt(int bpp)
 {
 	uint32_t pixfmt = 0;
 	switch (bpp) {
-	case 24:
-		pixfmt = IPU_PIX_FMT_BGR24;
-		break;
 	case 32:
 		pixfmt = IPU_PIX_FMT_BGR32;
 		break;
+	case 24:
+		pixfmt = IPU_PIX_FMT_BGR24;
+		break;
 	case 16:
 		pixfmt = IPU_PIX_FMT_RGB565;
 		break;
Signature · 1 line
1.7.2.3
#1 lore raw

PATCH 1/1 mx3fb and ipu_idmac cleanups

Quoted 8 lines · Michael Grzeschik

From: Juergen Beisert <[email protected]>

---
 drivers/dma/ipu/ipu_idmac.c |    2 +-
 drivers/video/mx3fb.c       |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

Ehrm, I think it makes sense to split them up.

Quoted 42 lines
drivers/dma/ipu/ipu_idmac.c +1 -1
index cb26ee9..e065703 100644
@@ -321,7 +321,7 @@ static void ipu_ch_param_set_size(union chan_param_mem *params,
 		params->ip.wid2	= 4;		/* Blue bit width - 1 */
 		break;
 	case IPU_PIX_FMT_BGR24:
-		params->ip.bpp	= 1;		/* 24 BPP & RGB PFS */
+		params->ip.bpp	= 1;		/* 24 BPP & BGR PFS */
 		params->ip.pfs	= 4;
 		params->ip.npb	= 7;
 		params->ip.sat	= 2;		/* SAT = 32-bit access */
drivers/video/mx3fb.c +3 -3
index 7cfc170..658f10a 100644
@@ -660,12 +660,12 @@ static uint32_t bpp_to_pixfmt(int bpp)
 {
 	uint32_t pixfmt = 0;
 	switch (bpp) {
-	case 24:
-		pixfmt = IPU_PIX_FMT_BGR24;
-		break;
 	case 32:
 		pixfmt = IPU_PIX_FMT_BGR32;
 		break;
+	case 24:
+		pixfmt = IPU_PIX_FMT_BGR24;
+		break;
 	case 16:
 		pixfmt = IPU_PIX_FMT_RGB565;
 		break;
Signature · 7 lines
1.7.2.3


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 9 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100922/79f2317a/attachment-0001.sig>