Skip to contentSkip to conversation

ASoC: Fix incorrect parameter to snd_soc_codec_volatile_register

PATCH In review Dimitris Papastamos 3 participants 4 messages Sep 22, 2010 – Sep 23, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Fix incorrect parameter to snd_soc_codec_volatile_register

We need to pass the register index and not the register value. This patch depends on my previous patch "ASoC: Delegate to hw specific read for volatile registers".

---
 sound/soc/soc-cache.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/soc-cache.c +1 -1
index 5d9d2f8..3e4680b 100644
@@ -177,7 +177,7 @@ static int snd_soc_8_8_write(struct snd_soc_codec *codec, unsigned int reg,
 	data[0] = reg;
 	data[1] = value & 0xff;
 
-	if (!snd_soc_codec_volatile_register(codec, value) &&
+	if (!snd_soc_codec_volatile_register(codec, reg) &&
 		reg < codec->driver->reg_cache_size)
 			cache[reg] = value;
 
Signature · 1 line
1.7.3
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Dimitris Papastamos

We need to pass the register index and not the register value. This patch depends on my previous patch "ASoC: Delegate to hw specific read for volatile registers".

---
 sound/soc/soc-cache.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/soc-cache.c +0 -0
index 5d9d2f8..3e4680b 100644

sound/soc/soc-cache.c static int snd_soc_8_8_write(struct snd_soc_codec *codec, unsigned int reg, · line 183

Quoted 8 lines
sound/soc/soc-cache.c +1 -1
@@ -177,7 +177,7 @@ static int snd_soc_8_8_write(struct snd_soc_codec *codec, unsigned int reg,
 	data[0] = reg;
 	data[1] = value & 0xff;
 
-	if (!snd_soc_codec_volatile_register(codec, value) &&
+	if (!snd_soc_codec_volatile_register(codec, reg) &&
 		reg < codec->driver->reg_cache_size)
 			cache[reg] = value;
 
Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk