ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem
PATCH 1/1 ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem
There are very few legitimate use cases, if any, for directly accessing system RAM through /dev/mem. So let's mimic what they do on x86 and forbid it when CONFIG_STRICT_DEVMEM is turned on.
arch/arm/Kconfig.debug +14 -0
@@ -2,6 +2,20 @@ menu "Kernel hacking" source "lib/Kconfig.debug" +config STRICT_DEVMEM + bool "Filter access to /dev/mem" + depends on MMU + ---help--- + If this option is disabled, you allow userspace (root) access to all + of memory, including kernel and userspace memory. Accidental + access to this is obviously disastrous, but specific access can + be used by people debugging the kernel. + + If this option is switched on, the /dev/mem file only allows + userspace access to memory mapped peripherals. + + If in doubt, say Y. + # RMK wants arm kernels compiled with frame pointers or stack unwinding. # If you know what you are doing and are willing to live without stack # traces, you can get a slightly smaller kernel by setting this option to
arch/arm/include/asm/io.h +1 -0
@@ -294,6 +294,7 @@ extern void pci_iounmap(struct pci_dev *dev, void __iomem *addr);#define ARCH_HAS_VALID_PHYS_ADDR_RANGE extern int valid_phys_addr_range (unsigned long addr,size_t size);extern int valid_mmap_phys_addr_range (unsigned long pfn,size_t size); +extern int devmem_is_allowed (unsigned long pfn);#endif /*
arch/arm/mm/mmap.c +22 -0
@@ -144,3 +144,25 @@ int valid_mmap_phys_addr_range(unsigned long pfn, size_t size) {return !(pfn + (size >>PAGE_SHIFT ) >0x00100000 ); } + +#ifdef CONFIG_STRICT_DEVMEM + +#include <linux/ioport.h> + +/* +* devmem_is_allowed() checks to see if /dev/mem access to a certain +* address is valid. The argument is a physical page number. +* We mimic x86 here by disallowing access to system RAM as well as +* device-exclusive MMIO regions. This effectively disable read()/write() +* on /dev/mem. +*/ +int devmem_is_allowed (unsigned long pfn) +{ +if (iomem_is_exclusive (pfn <<PAGE_SHIFT )) +return 0 ; +if (!page_is_ram (pfn)) +return 1 ; +return 0 ; +} + +#endif
PATCH 1/1 ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem
Quoted 4 lines · Nicolas Pitre
There are very few legitimate use cases, if any, for directly accessing system RAM through
/dev/mem. So let's mimic what they do on x86 and forbid it whenCONFIG_STRICT_DEVMEMis turned on.
Is this supposed to replace 6383/1 ?
PATCH 1/1 ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem
Quoted 7 lines · Russell King - ARM Linux
Quoted 4 lines · Nicolas Pitre
There are very few legitimate use cases, if any, for directly accessing system RAM through
/dev/mem. So let's mimic what they do on x86 and forbid it whenCONFIG_STRICT_DEVMEMis turned on.Is this supposed to replace 6383/1 ?
No, this is orthogonal.
Nicolas