Skip to contentSkip to conversation

s390: use free_netdev(netdev) instead of kfree()

PATCH Applied Vasiliy Kulikov 2 participants 2 messages Sep 26, 2010 – Sep 27, 2010

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 4/9 s390: use free_netdev(netdev) instead of kfree()

Freeing netdev without free_netdev() leads to net, tx leaks. I might lead to dereferencing freed pointer.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

@@
struct net_device* dev;
@@

-kfree(dev)
+free_netdev(dev)

---
 drivers/s390/net/ctcm_main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/s390/net/ctcm_main.c +2 -2
index 6edf20b..2c7d2d9 100644
@@ -1154,7 +1154,7 @@ static struct net_device *ctcm_init_netdevice(struct ctcm_priv *priv)
 				dev_fsm, dev_fsm_len, GFP_KERNEL);
 	if (priv->fsm = NULL) {
 		CTCMY_DBF_DEV(SETUP, dev, "init_fsm error");
-		kfree(dev);
+		free_netdev(dev);
 		return NULL;
 	}
 	fsm_newstate(priv->fsm, DEV_STATE_STOPPED);
@@ -1165,7 +1165,7 @@ static struct net_device *ctcm_init_netdevice(struct ctcm_priv *priv)
 		grp = ctcmpc_init_mpc_group(priv);
 		if (grp = NULL) {
 			MPC_DBF_DEV(SETUP, dev, "init_mpc_group error");
-			kfree(dev);
+			free_netdev(dev);
 			return NULL;
 		}
 		tasklet_init(&grp->mpc_tasklet2,
Signature · 1 line
1.7.0.4
maintainer Applied
#1 lore raw

From: Vasiliy Kulikov <[email protected]>
Date: Sun, 26 Sep 2010 13:58:09 +0400

Review

Quoted 12 lines

Freeing netdev without free_netdev() leads to net, tx leaks. I might lead to dereferencing freed pointer.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

@@
struct net_device* dev;
@@

(quoted diff) +1 -1
-kfree(dev)
+free_netdev(dev)

Applied.