2.6.36-rc5+: drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask'
$ make V=2 CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh - due to target is PHONY CHK include/generated/compile.h CC [M] drivers/hwmon/coretemp.o - due to target missing drivers/hwmon/coretemp.c: In function 'coretemp_device_remove': drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask' make[2]: *** [drivers/hwmon/coretemp.o] Error 1 make[1]: *** [drivers/hwmon] Error 2 make: *** [drivers] Error 2
above function is not defined on UP.
This commit introduced the error:
commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f
Author: Jan Beulich <[email protected]> Date: Mon Sep 13 10:23:05 2010 +0000
x86/hwmon: register alternate sibling upon CPU removal
Just like pkgtemp registers another core of the same package when one gets removed, coretemp should register another hyperthread (if available) in that situation.
As pointed out in the patch fixing the respective code in pkgtemp, the list protectng mutex must be dropped before calling coretemp_device_add(), and due to the restructured loop (including an explicit return) the "safe" variant of the list iterator isn't needed anymore.
Quoted 12 lines · On Sun, 26 Sep 2010 23:17:50 +0200 Thomas Meyer wrote:
$ make V=2 CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh - due to target is PHONY CHK include/generated/compile.h CC [M] drivers/hwmon/coretemp.o - due to target missing drivers/hwmon/coretemp.c: In function 'coretemp_device_remove': drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask' make[2]: *** [drivers/hwmon/coretemp.o] Error 1 make[1]: *** [drivers/hwmon] Error 2 make: *** [drivers] Error 2
Quoted 1 line
above function is not defined on UP.
Patch just posted:
http://lkml.org/lkml/2010/9/26/112
Quoted 18 lines
This commit introduced the error:
commit
e40cc4bdfd4b89813f072f72bd9c7055814d3f0fAuthor: Jan Beulich <[email protected]> Date: Mon Sep 13 10:23:05 2010 +0000x86/hwmon: register alternate sibling upon CPU removal
Just like pkgtemp registers another core of the same package when one gets removed, coretemp should register another hyperthread (if available) in that situation.
As pointed out in the patch fixing the respective code in pkgtemp, the list protectng mutex must be dropped before calling
coretemp_device_add(), and due to the restructured loop (including an explicit return) the "safe" variant of the list iterator isn't needed anymore.
Quoted 4 lines
Signed-off-by Jan Beulich <[email protected]>Cc Rudolf Marek <[email protected]>Signed-off-by Guenter Roeck <[email protected]>--
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Quoted 14 lines · Randy Dunlap
Quoted 12 lines · On Sun, 26 Sep 2010 23:17:50 +0200 Thomas Meyer wrote:
$ make V=2 CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh - due to target is PHONY CHK include/generated/compile.h CC [M] drivers/hwmon/coretemp.o - due to target missing drivers/hwmon/coretemp.c: In function 'coretemp_device_remove': drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask' make[2]: *** [drivers/hwmon/coretemp.o] Error 1 make[1]: *** [drivers/hwmon] Error 2 make: *** [drivers] Error 2
Quoted 7 lines
Quoted 1 line
above function is not defined on UP.
Patch just posted:
... with apologies
Guenter