Skip to contentSkip to conversation

mrst_max3110: Missing linux/irq.h include.

PATCH In review David Miller 3 participants 3 messages Sep 29, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mrst_max3110: Missing linux/irq.h include.

This driver makes use of IRQ_TYPE_EDGE_FALLING, therefore it must include linux/irq.h

drivers/serial/mrst_max3110.c: In function 'serial_m3110_startup':
drivers/serial/mrst_max3110.c:470:5: error: 'IRQ_TYPE_EDGE_FALLING' undeclared (first use in this function) drivers/serial/mrst_max3110.c:470:5: note: each undeclared identifier is reported only once for each function it appears in

drivers/serial/mrst_max3110.c +1 -0
index f6ad1ec..915dedc 100644
@@ -33,6 +33,7 @@
 #include <linux/console.h>
 #include <linux/sysrq.h>
 #include <linux/platform_device.h>
+#include <linux/irq.h>
 #include <linux/tty.h>
 #include <linux/tty_flip.h>
 #include <linux/serial_core.h>
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Tue, 28 Sep 2010 21:36:20 -0700 (PDT) David Miller <[email protected]>…

This driver makes use of IRQ_TYPE_EDGE_FALLING, therefore it must include linux/irq.h

drivers/serial/mrst_max3110.c: In function 'serial_m3110_startup':
drivers/serial/mrst_max3110.c:470:5: error: 'IRQ_TYPE_EDGE_FALLING' undeclared (first use in this function) drivers/serial/mrst_max3110.c:470:5: note: each undeclared identifier is reported only once for each function it appears in

#2 lore raw
In reply to David Miller

Looks good to me, thanks for fixing it.

- Feng
-----Original Message-----
From: David Miller [mailto:[email protected]]
Sent: Tuesday, September 28, 2010 11:36 PM
To: [email protected]
Cc: Tang, Feng; [email protected]
Subject: [PATCH] mrst_max3110: Missing linux/irq.h include.

This driver makes use of IRQ_TYPE_EDGE_FALLING, therefore it must include linux/irq.h

drivers/serial/mrst_max3110.c: In function 'serial_m3110_startup':
drivers/serial/mrst_max3110.c:470:5: error: 'IRQ_TYPE_EDGE_FALLING' undeclared (first use in this function) drivers/serial/mrst_max3110.c:470:5: note: each undeclared identifier is reported only once for each function it appears in

drivers/serial/mrst_max3110.c +1 -0
index f6ad1ec..915dedc 100644
@@ -33,6 +33,7 @@
 #include <linux/console.h>
 #include <linux/sysrq.h>
 #include <linux/platform_device.h>
+#include <linux/irq.h>
 #include <linux/tty.h>
 #include <linux/tty_flip.h>
 #include <linux/serial_core.h>