Skip to contentSkip to conversation

ARM: Samsung: Add helper function for setup gpios

PATCH New Kyungmin Park 2 participants 3 messages Sep 30, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Samsung: Add helper function for setup gpios

From: Kyungmin Park <[email protected]>

There are many places setup GPIOs for configuring the pin and pull state. With this helper function we can make it simple codes.

Before:

        /* Set all the necessary GPK0[0:1] pins to special-function 2 */
        for (gpio = S5PV310_GPK0(0); gpio < S5PV310_GPK0(2); gpio++) {
                s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(2));
                s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
        }

        switch (width) {
        case 8:
                /* GPK1[3:6] special-funtion 3 */
                for (gpio = S5PV310_GPK1(3); gpio <= S5PV310_GPK1(6); gpio++) {
                        s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(3));
                        s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
                }
        case 4:
                /* GPK0[3:6] special-funtion 2 */
                for (gpio = S5PV310_GPK0(3); gpio <= S5PV310_GPK0(6); gpio++) {
                        s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(2));
                        s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
                }
        default:
                break;
        }

After:

        /* Set all the necessary GPK0[0:1] pins to special-function 2 */
        s3c_setup_gpios(S5PV310_GPK0(0), S5PV310_GPK0(1),
                                S3C_GPIO_SFN(2), S3C_GPIO_PULL_NONE);
        switch (width) {
        case 8:
                /* GPK1[3:6] special-funtion 3 */
                s3c_setup_gpios(S5PV310_GPK1(3), S5PV310_GPK1(6),
                                S3C_GPIO_SFN(3), S3C_GPIO_PULL_NONE);
        case 4:
                /* GPK0[3:6] special-funtion 2 */
                s3c_setup_gpios(S5PV310_GPK0(3), S5PV310_GPK0(6),
                                S3C_GPIO_SFN(2), S3C_GPIO_PULL_NONE);
        default:
                break;
        }

---

arch/arm/plat-samsung/gpio-config.c +14 -0
index e3d41ea..66b838f 100644
@@ -80,6 +80,20 @@ int s3c_gpio_setpull(unsigned int pin, s3c_gpio_pull_t pull)
 }
 EXPORT_SYMBOL(s3c_gpio_setpull);
 
+int s3c_setup_gpios(unsigned int start, unsigned int end,
+			unsigned int config, s3c_gpio_pull_t pull)
+{
+	unsigned int gpio;
+
+	for (gpio = start; gpio <= end; gpio++) {
+		s3c_gpio_cfgpin(gpio, config);
+		s3c_gpio_setpull(gpio, pull);
+	}
+
+	return 0;
+}
+EXPORT_SYMBOL(s3c_setup_gpios);
+
 #ifdef CONFIG_S3C_GPIO_CFG_S3C24XX
 int s3c_gpio_setcfg_s3c24xx_a(struct s3c_gpio_chip *chip,
 			      unsigned int off, unsigned int cfg)
arch/arm/plat-samsung/include/plat/gpio-cfg.h +13 -0
index 1c6b929..6ac9091 100644
@@ -133,6 +133,19 @@ extern unsigned s3c_gpio_getcfg(unsigned int pin);
 extern int s3c_gpio_setpull(unsigned int pin, s3c_gpio_pull_t pull);
 
 /**
+ * s3c_setup_gpios() - Change & set gpios pin from start to end
+ * @start: The start pin number to configure
+ * @end: The end pin number to configure
+ * @config: The configuration for the pin's function.
+ * @pull: The configuration for the pull resistor.
+ *
+ * Helper functions to do both s3c_gpio_cfgpin and s3c_gpio_setpull
+ * with range
+ */
+extern int s3c_setup_gpios(unsigned int start, unsigned int end,
+			unsigned int config, s3c_gpio_pull_t pull);
+
+/**
  * s3c_gpio_getpull() - get the pull resistor state of a gpio pin
  * @pin: The pin number to get the settings for
  *
#1 lore raw

PATCH 1/1 ARM: Samsung: Add helper function for setup gpios

Quoted 52 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

There are many places setup GPIOs for configuring the pin and pull state. With this helper function we can make it simple codes.

Before:

        /* Set all the necessary GPK0[0:1] pins to special-function 2 */
        for (gpio = S5PV310_GPK0(0); gpio < S5PV310_GPK0(2); gpio++) {
                s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(2));
                s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
        }

        switch (width) {
        case 8:
                /* GPK1[3:6] special-funtion 3 */
                for (gpio = S5PV310_GPK1(3); gpio <= S5PV310_GPK1(6);
gpio++) {
                        s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(3));
                        s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
                }
        case 4:
                /* GPK0[3:6] special-funtion 2 */
                for (gpio = S5PV310_GPK0(3); gpio <= S5PV310_GPK0(6);
gpio++) {
                        s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(2));
                        s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
                }
        default:
                break;
        }

After:

        /* Set all the necessary GPK0[0:1] pins to special-function 2 */
        s3c_setup_gpios(S5PV310_GPK0(0), S5PV310_GPK0(1),
                                S3C_GPIO_SFN(2),
S3C_GPIO_PULL_NONE);
        switch (width) {
        case 8:
                /* GPK1[3:6] special-funtion 3 */
                s3c_setup_gpios(S5PV310_GPK1(3), S5PV310_GPK1(6),
                                S3C_GPIO_SFN(3),
S3C_GPIO_PULL_NONE);
        case 4:
                /* GPK0[3:6] special-funtion 2 */
                s3c_setup_gpios(S5PV310_GPK0(3), S5PV310_GPK0(6),
                                S3C_GPIO_SFN(2),
S3C_GPIO_PULL_NONE);
        default:
                break;
        }

Review

Quoted 3 lines

---

(quoted diff) +0 -0

b/arch/arm/plat-samsung/gpio-

arch/arm/plat-samsung/gpio-config.c int s3c_gpio_setpull(unsigned int pin, s3c_gpio_pull_t

Quoted 5 lines

config.c
index e3d41ea..66b838f 100644

arch/arm/plat-samsung/gpio-config.c +0 -0
@@ -80,6 +80,20 @@ int s3c_gpio_setpull(unsigned int pin, s3c_gpio_pull_t

pull)

Review

Quoted 21 lines
arch/arm/plat-samsung/gpio-config.c +14 -0
 }
 EXPORT_SYMBOL(s3c_gpio_setpull);
 
+int s3c_setup_gpios(unsigned int start, unsigned int end,
+			unsigned int config, s3c_gpio_pull_t pull)
+{
+	unsigned int gpio;
+
+	for (gpio = start; gpio <= end; gpio++) {
+		s3c_gpio_cfgpin(gpio, config);
+		s3c_gpio_setpull(gpio, pull);
+	}
+
+	return 0;
+}
+EXPORT_SYMBOL(s3c_setup_gpios);
+
 #ifdef CONFIG_S3C_GPIO_CFG_S3C24XX
 int s3c_gpio_setcfg_s3c24xx_a(struct s3c_gpio_chip *chip,
 			      unsigned int off, unsigned int cfg)
(quoted diff) +0 -0

b/arch/arm/plat-

Quoted 14 lines

samsung/include/plat/gpio-cfg.h
index 1c6b929..6ac9091 100644

arch/arm/plat-samsung/include/plat/gpio-cfg.h +6 -0
@@ -133,6 +133,19 @@ extern unsigned s3c_gpio_getcfg(unsigned int pin);
 extern int s3c_gpio_setpull(unsigned int pin, s3c_gpio_pull_t pull);
 
 /**
+ * s3c_setup_gpios() - Change & set gpios pin from start to end
+ * @start: The start pin number to configure
+ * @end: The end pin number to configure
+ * @config: The configuration for the pin's function.
+ * @pull: The configuration for the pull resistor.
+ *

arch/arm/plat-samsung/include/plat/gpio-cfg.h extern unsigned s3c_gpio_getcfg(unsigned int pin); · line 151

Quoted 10 lines
arch/arm/plat-samsung/include/plat/gpio-cfg.h +7 -0
+ * Helper functions to do both s3c_gpio_cfgpin and s3c_gpio_setpull
+ * with range
+ */
+extern int s3c_setup_gpios(unsigned int start, unsigned int end,
+			unsigned int config, s3c_gpio_pull_t pull);
+
+/**
  * s3c_gpio_getpull() - get the pull resistor state of a gpio pin
  * @pin: The pin number to get the settings for
  *

Hmm...this has been submitted by Ben.
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-May/016629.html

If possible, I'd like to merge Ben's full patches except several patches which have some problem.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#2 lore raw

PATCH 1/1 ARM: Samsung: Add helper function for setup gpios

Quoted 113 lines · Kukjin Kim
Quoted 52 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

There are many places setup GPIOs for configuring the pin and pull state. With this helper function we can make it simple codes.

Before:
? ? ? ? /* Set all the necessary GPK0[0:1] pins to special-function 2 */ ? ? ? ? for (gpio = S5PV310_GPK0(0); gpio < S5PV310_GPK0(2); gpio++) { ? ? ? ? ? ? ? ? s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(2));
? ? ? ? ? ? ? ? s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE); ? ? ? ? }

? ? ? ? switch (width) {
? ? ? ? case 8:
? ? ? ? ? ? ? ? /* GPK1[3:6] special-funtion 3 */
? ? ? ? ? ? ? ? for (gpio = S5PV310_GPK1(3); gpio <= S5PV310_GPK1(6); gpio++) {
? ? ? ? ? ? ? ? ? ? ? ? s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(3)); ? ? ? ? ? ? ? ? ? ? ? ? s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE); ? ? ? ? ? ? ? ? }
? ? ? ? case 4:
? ? ? ? ? ? ? ? /* GPK0[3:6] special-funtion 2 */
? ? ? ? ? ? ? ? for (gpio = S5PV310_GPK0(3); gpio <= S5PV310_GPK0(6); gpio++) {
? ? ? ? ? ? ? ? ? ? ? ? s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(2)); ? ? ? ? ? ? ? ? ? ? ? ? s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE); ? ? ? ? ? ? ? ? }
? ? ? ? default:
? ? ? ? ? ? ? ? break;
? ? ? ? }
After:

? ? ? ? /* Set all the necessary GPK0[0:1] pins to special-function 2 */ ? ? ? ? s3c_setup_gpios(S5PV310_GPK0(0), S5PV310_GPK0(1),
? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? S3C_GPIO_SFN(2), S3C_GPIO_PULL_NONE);
? ? ? ? switch (width) {
? ? ? ? case 8:
? ? ? ? ? ? ? ? /* GPK1[3:6] special-funtion 3 */
? ? ? ? ? ? ? ? s3c_setup_gpios(S5PV310_GPK1(3), S5PV310_GPK1(6), ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? S3C_GPIO_SFN(3), S3C_GPIO_PULL_NONE);
? ? ? ? case 4:
? ? ? ? ? ? ? ? /* GPK0[3:6] special-funtion 2 */
? ? ? ? ? ? ? ? s3c_setup_gpios(S5PV310_GPK0(3), S5PV310_GPK0(6), ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? S3C_GPIO_SFN(2), S3C_GPIO_PULL_NONE);
? ? ? ? default:
? ? ? ? ? ? ? ? break;
? ? ? ? }

Review

Quoted 3 lines

---

(quoted diff) +0 -0

b/arch/arm/plat-samsung/gpio-

arch/arm/plat-samsung/gpio-config.c int s3c_gpio_setpull(unsigned int pin, s3c_gpio_pull_t

Quoted 5 lines

config.c
index e3d41ea..66b838f 100644

arch/arm/plat-samsung/gpio-config.c +0 -0
@@ -80,6 +80,20 @@ int s3c_gpio_setpull(unsigned int pin, s3c_gpio_pull_t

pull)

Quoted 20 lines
arch/arm/plat-samsung/gpio-config.c +14 -0
 ?}
 ?EXPORT_SYMBOL(s3c_gpio_setpull);
 
+int s3c_setup_gpios(unsigned int start, unsigned int end,
+ ? ? ? ? ? ? ? ? ? ? unsigned int config, s3c_gpio_pull_t pull)
+{
+ ? ? unsigned int gpio;
+
+ ? ? for (gpio = start; gpio <= end; gpio++) {
+ ? ? ? ? ? ? s3c_gpio_cfgpin(gpio, config);
+ ? ? ? ? ? ? s3c_gpio_setpull(gpio, pull);
+ ? ? }
+
+ ? ? return 0;
+}
+EXPORT_SYMBOL(s3c_setup_gpios);
+

?#ifdef CONFIG_S3C_GPIO_CFG_S3C24XX
?int s3c_gpio_setcfg_s3c24xx_a(struct s3c_gpio_chip *chip, ? ? ? ? ? ? ? ? ? ? ? ? ? ? unsigned int off, unsigned int cfg)

Review

Quoted 1 line
(quoted diff) +0 -0

b/arch/arm/plat-

Quoted 21 lines

samsung/include/plat/gpio-cfg.h
index 1c6b929..6ac9091 100644

arch/arm/plat-samsung/include/plat/gpio-cfg.h +0 -0
@@ -133,6 +133,19 @@ extern unsigned s3c_gpio_getcfg(unsigned int pin);
 ?extern int s3c_gpio_setpull(unsigned int pin, s3c_gpio_pull_t pull);
 

?/**
+ * s3c_setup_gpios() - Change & set gpios pin from start to end
+ * @start: The start pin number to configure
+ * @end: The end pin number to configure
+ * @config: The configuration for the pin's function.
+ * @pull: The configuration for the pull resistor.
+ *
+ * Helper functions to do both s3c_gpio_cfgpin and s3c_gpio_setpull
+ * with range
+ */

arch/arm/plat-samsung/include/plat/gpio-cfg.h +4 -0
+extern int s3c_setup_gpios(unsigned int start, unsigned int end,
+ ? ? ? ? ? ? ? ? ? ? unsigned int config, s3c_gpio_pull_t pull);
+
+/**
Quoted 3 lines

? * s3c_gpio_getpull() - get the pull resistor state of a gpio pin ? * @pin: The pin number to get the settings for
? *

Hmm...this has been submitted by Ben.
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-May/016629.html

Quoted 2 lines

If possible, I'd like to merge Ben's full patches except several patches which have some problem.

Yes I remember it. but after that there's no activity. Actually there are so many pending patches from others but not merged. Anyway I need it and please merge it for 2.6.37.
I hope you merge it and see the codes at for-next git soon.

Thank you,
Kyungmin Park