Skip to contentSkip to conversation

tg3: Bugfixes and updates

PATCH In review Matt Carlson 2 participants 3 messages Sep 30, 2010 – Oct 1, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover tg3: Bugfixes and updates

This patchset implements some bugfixes, removes the 5724 device ID and introduces extended rx buffer rings.

maintainer
#1 lore raw

From: "Matt Carlson" <[email protected]>
Date: Thu, 30 Sep 2010 13:34:29 -0700

Quoted 2 lines

This patchset implements some bugfixes, removes the 5724 device ID and introduces extended rx buffer rings.

All applied....

But really, I want to hear some real justification for a 2048 entry RX ring at gigabit speeds. I even think 512 is way too large for gigabit parts.

Any machine that gets one of these newer 5717 parts does not need that much queueing, and too deep queues tend to hurt locality and thus performance.

#2 lore raw
Quoted 11 lines · David Miller

From: "Matt Carlson" <[email protected]>
Date: Thu, 30 Sep 2010 13:34:29 -0700

Quoted 2 lines

This patchset implements some bugfixes, removes the 5724 device ID and introduces extended rx buffer rings.

All applied....

But really, I want to hear some real justification for a 2048 entry RX ring at gigabit speeds. I even think 512 is way too large for gigabit parts.

I don't have any personal experience where a larger ring size could benefit. However, I have heard of situations in the past where people have said increasing the amount of rx buffers available has smoothed over some bursty traffic / cpu usage patterns. These people really did want more than 512 rx buffers.

Quoted 3 lines

Any machine that gets one of these newer 5717 parts does not need that much queueing, and too deep queues tend to hurt locality and thus performance.

Good point. I'll see if we can scale the BD ring size based on the number of rx buffers the administrator has configured.