Skip to contentSkip to conversation

drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes

PATCH Applied [email protected] 2 participants 2 messages Oct 1, 2010 – Oct 4, 2010

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/2 drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes

From: Andrew Morton <[email protected]>

ERROR: trailing statements should be on next line #23: FILE: drivers/net/tulip/de4x5.c:5477:
+ if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;

total: 1 errors, 0 warnings, 8 lines checked

./patches/drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc Dan Rosenberg <[email protected]>
Cc Grant Grundler <[email protected]>
Cc Jeff Mahoney <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/net/tulip/de4x5.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/tulip/de4x5.c renamed from drivers/net/tulip/de4x5.c~drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes +2 -1
diff -puN drivers/net/tulip/de4x5.c~drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes drivers/net/tulip/de4x5.c
@@ -5474,7 +5474,8 @@ de4x5_ioctl(struct net_device *dev, stru
 	tmp.lval[6] = inl(DE4X5_STRR); j+=4;
 	tmp.lval[7] = inl(DE4X5_SIGR); j+=4;
 	ioc->len = j;
-	if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
+	if (copy_to_user(ioc->data, tmp.lval, ioc->len))
+		return -EFAULT;
 	break;
 
 #define DE4X5_DUMP              0x0f /* Dump the DE4X5 Status */

_

maintainer Applied
#1 lore raw

From: [email protected]
Date: Fri, 01 Oct 2010 14:17:12 -0700

Quoted 12 lines

From: Andrew Morton <[email protected]>

ERROR: trailing statements should be on next line #23: FILE: drivers/net/tulip/de4x5.c:5477:

(quoted diff) +1 -0
+	if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;

total: 1 errors, 0 warnings, 8 lines checked

./patches/drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Quoted 6 lines

Please run checkpatch prior to sending patches

Cc Dan Rosenberg <[email protected]>
Cc Grant Grundler <[email protected]>
Cc Jeff Mahoney <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

Applied to net-next-2.6