Skip to contentSkip to conversation

Add summary column to cyclictest histograms

PATCH New Carsten Emde 1 participant 2 messages Oct 3, 2010

lore
Share & tools
lore
#0 lore raw

cover Add summary column to cyclictest histograms

Clark,

With this patch, a summary column is optionally displayed to provide an overview of latency histograms when cyclictest runs more than a single thread. For this purpose, the new option -H/histofall was introduced. I am fully aware that cyclictest does not suffer from too few options, but I did not want to break existing scripts that rely on the number of columns in cyclictest's output.

Carsten.

#1 lore raw

PATCH 1/1 cyclictest-histogram-add-summary-column.patch

To compare histograms of several SMP machines or to gain an overview when cyclictest is running more than a single thread, an overall histogram is required that contains a summary of the individual thread latencies.

This patch adds this functionality and introduces the new option -H/--histofall for this purpose.

---
 src/cyclictest/cyclictest.8 |    3 ++
 src/cyclictest/cyclictest.c |   50 ++++++++++++++++++++++++++++++++++++--------
 2 files changed, 45 insertions(+), 8 deletions(-)
src/cyclictest/cyclictest.8 +3 -0
Index: rt-tests/src/cyclictest/cyclictest.8
===================================================================
@@ -93,6 +93,9 @@ Enable function tracing using ftrace as 
 .B \-h, \-\-histogram=MAXLATENCYINUS
 Dump latency histogram to stdout. US means the max time to be be tracked in microseconds. When you use \-h option to get histogram data, Cyclictest runs many threads with same priority without priority\-\-.
 .TP
+.B \-H, \-\-histofall=MAXLATENCYINUS
+Same as -h except that an additional histogram column is displayed at the right that contains summary data of all thread histograms. If cyclictest runs a single thread only, the -H option is equivalent to -h.
+.TP
 .B \-i, \-\-interval=INTV
 Set the base interval of the thread(s) in microseconds (default is 1000us). This sets the interval of the first thread. See also \-d.
 .TP
src/cyclictest/cyclictest.c +42 -8

126 lines not on this page · raw message