Skip to contentSkip to conversation

opensm/osm_state_mgr.c: Don't signal DISCOVER to SM state machine when already DISCOVERING

PATCH Applied Hal Rosenstock 2 participants 2 messages Oct 4, 2010 – Oct 25, 2010 1 message not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 opensm/osm_state_mgr.c: Don't signal DISCOVER to SM state machine when already DISCOVERING

Eliminate this "illegal" state machine transition which triggers the following log message:

sm_state_mgr_signal_error: ERR 3207: Invalid signal OSM_SM_SIGNAL_DISCOVER in state DISCOVERING

This is observed when the SM port is down.

---

opensm/opensm/osm_state_mgr.c +2 -1
index e7bff46..68841f8 100644
@@ -1191,7 +1191,8 @@ repeat_discovery:
 		osm_drop_mgr_process(sm);
 
 		/* Move to DISCOVERING state */
-		osm_sm_state_mgr_process(sm, OSM_SM_SIGNAL_DISCOVER);
+		 if (sm->p_subn->sm_state != IB_SMINFO_STATE_DISCOVERING)
+			osm_sm_state_mgr_process(sm, OSM_SM_SIGNAL_DISCOVER);
 		osm_opensm_report_event(sm->p_subn->p_osm,
 				OSM_EVENT_ID_STATE_CHANGE, NULL);
 		return;

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 9 lines · Hal Rosenstock

Eliminate this "illegal" state machine transition which triggers the following log message:

sm_state_mgr_signal_error: ERR 3207: Invalid signal OSM_SM_SIGNAL_DISCOVER in state DISCOVERING

This is observed when the SM port is down.

Applied. Thanks.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html