Skip to contentSkip to conversation

jbd: Remove unnecessary goto statement

PATCH In review Namhyung Kim 2 participants 2 messages Oct 4, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 jbd: Remove unnecessary goto statement

Remove goto statement which jumps to very next line. Also remove target label because it is no longer used anywhere.

---
 fs/jbd/transaction.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
fs/jbd/transaction.c +0 -2
index 5ae71e7..981449c 100644
@@ -293,9 +293,7 @@ handle_t *journal_start(journal_t *journal, int nblocks)
 		jbd_free_handle(handle);
 		current->journal_info = NULL;
 		handle = ERR_PTR(err);
-		goto out;
 	}
-out:
 	return handle;
 }
 
Signature · 1 line
1.7.0.4
#1 lore raw
Quoted 2 lines · Namhyung Kim

Remove goto statement which jumps to very next line. Also remove target label because it is no longer used anywhere.

Thanks. Merged into my tree.

Honza

Quoted 23 lines
---
 fs/jbd/transaction.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
fs/jbd/transaction.c +0 -2
index 5ae71e7..981449c 100644
@@ -293,9 +293,7 @@ handle_t *journal_start(journal_t *journal, int nblocks)
 		jbd_free_handle(handle);
 		current->journal_info = NULL;
 		handle = ERR_PTR(err);
-		goto out;
 	}
-out:
 	return handle;
 }
 
Signature · 1 line
1.7.0.4
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR