USB: Make non-bulk delay longer in OHCI
Subsystems (3)
PATCH 1/2 USB: Make non-bulk delay longer in OHCI
This fixes TIMEOUT with my Kingston 32GB USB3.0 flashdrive, which I experienced on my PXA270 (USB 1.1) Vpac270 board.
--- drivers/usb/host/ohci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/ohci-hcd.c +1 -1
@@ -1529,7 +1529,7 @@ int submit_common_msg(struct usb_device *dev, unsigned long pipe, void *buffer,if (usb_pipebulk (pipe)) timeout =BULK_TO ;else - timeout =100 ; + timeout =1000 ;/* wait for it to complete */ for (;;) {
Signature · 1 line
1.7.1
PATCH 1/2 USB: Make non-bulk delay longer in OHCI
Dne Po 20. z??? 2010 03:57:25 Marek Vasut napsal(a):
Quoted 2 lines
This fixes TIMEOUT with my Kingston 32GB USB3.0 flashdrive, which I experienced on my PXA270 (USB 1.1) Vpac270 board.
CC Remy
Quoted 19 lines
Signed-off-by Marek Vasut <[email protected]>--- drivers/usb/host/ohci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/usb/host/ohci-hcd.c +1
-1@@ -1529,7 +1529,7 @@ int submit_common_msg(struct usb_device *dev, unsigned long pipe, void *buffer, if (usb_pipebulk(pipe)) timeout =BULK_TO ; else - timeout =100 ; + timeout =1000 ;/* wait for it to complete */ for (;;) {
PATCH 1/2 USB: Make non-bulk delay longer in OHCI
Dear Marek Vasut,
Quoted 5 lines · In message <[email protected]> you wrote:
Dne Po 20. z?#? 2010 03:57:25 Marek Vasut napsal(a):
Quoted 2 lines
This fixes TIMEOUT with my Kingston 32GB USB3.0 flashdrive, which I experienced on my PXA270 (USB 1.1) Vpac270 board.
CC Remy
How do you expoect this to work? You did NOT add him to the Cc: list.
Also please note that "wdenk at denx.de" is a non-existing address.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Summit meetings tend to be like panda matings. The expectations are always high, and the results usually disappointing." - Robert Orben
PATCH 1/2 USB: Make non-bulk delay longer in OHCI
Dne Po 4. ??jna 2010 06:43:45 Wolfgang Denk napsal(a):
Quoted 11 lines
Dear Marek Vasut,
Quoted 5 lines · In message <[email protected]> you wrote:
Dne Po 20. z?#? 2010 03:57:25 Marek Vasut napsal(a):
Quoted 2 lines
This fixes TIMEOUT with my Kingston 32GB USB3.0 flashdrive, which I experienced on my PXA270 (USB 1.1) Vpac270 board.
CC Remy
How do you expoect this to work? You did NOT add him to the Cc: list.
Quoted 7 lines
Also please note that "wdenk at denx.de" is a non-existing address.
Best regards,
Wolfgang Denk
I added him to CC in mail ... what else do you expect?
PATCH 1/2 USB: Make non-bulk delay longer in OHCI
Dear Marek Vasut,
Quoted 2 lines · In message <[email protected]> you wrote:
Quoted 2 lines
How do you expoect this to work? You did NOT add him to the Cc: list.
...
Quoted 1 line
I added him to CC in mail ... what else do you expect?
The message I received through the list did not contain any such Cc:
| Subject: Re: [U-Boot] [PATCH 1/2] USB: Make non-bulk delay longer in OHCI | From: Marek Vasut <[email protected]> | Date: Mon, 4 Oct 2010 01:36:27 +0200 | To: u-boot at lists.denx.de | Cc: wdenk at denx.de
But I ran into a similar issue myself today.
Dunno what happens...
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Microsoft Multitasking:
several applications can crash at the same time.PATCH 1/2 USB: Make non-bulk delay longer in OHCI
Hi Wolfgang,
[...]
Quoted 11 lines
The message I received through the list did not contain any such Cc:
| Subject: Re: [U-Boot] [PATCH 1/2] USB: Make non-bulk delay longer in OHCI | From: Marek Vasut <[email protected]> | Date: Mon, 4 Oct 2010 01:36:27 +0200 | To: u-boot at lists.denx.de | Cc: wdenk at denx.deBut I ran into a similar issue myself today.
Dunno what happens...
Welcome to the club - been there, didn't understand it either ;)
Cheers
Detlev
Signature · 6 lines
Die eine Haelfte der Welt lacht ueber die andere, und Narren sind alle.
--- Baltasar Gracian
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.dePATCH 2/2 Config: Add "board variant" column to boards.cfg
In reply to Marek VasutThere are some boards where it's not currently possible to detect all board information at runtime, therefore I introduced a new column called "variant" to boards.cfg . If this field is set, CONFIG_fieldvalue is #define-d in config.h
Also, I had to add fallback logic, because each of the board variants has a distinct name. This led to the mkconfig #including incorrect board configuration file (<configs/whole-board-configuration-name.h> aka. the value in column one). I implemented a logic which checks if such file exists and if it does not, it includes<configs/board-name.h> aka. the value in third column.
--- Makefile | 22 ---------------------- boards.cfg | 9 +++++++-- mkconfig | 18 +++++++++++++++++- 3 files changed, 24 insertions(+), 25 deletions(-)
Makefile +0 -22
@@ -2179,28 +2179,6 @@ scpu_config: unconfig fi @$(MKCONFIG) -n $@ -a pdnb3 arm ixp pdnb3 prodrive -polaris_config \ -trizepsiv_config : unconfig - @mkdir -p $(obj)include - @if [ "$(findstring polaris,$@)" ] ; then \ - echo "#define CONFIG_POLARIS 1" >>$(obj)include/config.h ; \ - fi; - @$(MKCONFIG) -n $@ -a trizepsiv arm pxa trizepsiv - -vpac270_nor_256M_config \ -vpac270_nor_128M_config \ -vpac270_onenand_config : unconfig - @mkdir -p $(obj)include - @if [ "$(findstring onenand,$@)" ] ; then \ - echo "#define CONFIG_ONENAND_U_BOOT" \ - >>$(obj)include/config.h ; \ - fi; - @if [ "$(findstring 256M,$@)" ] ; then \ - echo "#define CONFIG_256M_U_BOOT" \ - >>$(obj)include/config.h ; \ - fi; - @$(MKCONFIG) -n $@ -a vpac270 arm pxa vpac270 - ######################################################################### ## ARM1136 Systems #########################################################################
boards.cfg +7 -2
@@ -17,8 +17,8 @@ # # :.,$! sort -f -k2,2 -k3,3 -k6,6 -k5,5 -k1,1 # -# Target ARCH CPU Board name Vendor SoC -########################################################################### +# Target ARCH CPU Board name Vendor SoC Variant +############################################################################################### qong arm arm1136 - davedenx mx31 mx31ads arm arm1136 - freescale mx31
@@ -64,6 +64,11 @@ lubbock arm pxa palmld arm pxa palmtc arm pxa pleb2 arm pxa +polaris arm pxa trizepsiv - - POLARIS +trizepsiv arm pxa trizepsiv +vpac270_nor_128M arm pxa vpac270 +vpac270_nor_256M arm pxa vpac270 - - 256M_U_BOOT +vpac270_onenand arm pxa vpac270 - - ONENAND_U_BOOT xaeniax arm pxa xm250 arm pxa zipitz2 arm pxa
mkconfig +17 -1
@@ -17,6 +17,7 @@ cpu="" board="" vendor="" soc="" +variant="" if [ \( $# -eq 2 \) -a \( "$1" = "-A" \) ] ; then # Automatic mode
@@ -41,7 +42,7 @@ while [ $# -gt 0 ] ; do done [ $# -lt 4 ] && exit 1 -[ $# -gt 6 ] && exit 1 +[ $# -gt 7 ] && exit 1 CONFIG_NAME="${1%_config}"
@@ -56,6 +57,7 @@ else fi [ $# -gt 4 ] && [ "$5" != "-" ] && vendor="$5" [ $# -gt 5 ] && [ "$6" != "-" ] && soc="$6" +[ $# -gt 6 ] && [ "$7" != "-" ] && variant="$7" if [ "${ARCH}" -a "${ARCH}" != "${arch}" ]; then echo "Failed: \$ARCH=${ARCH}, should be '${arch}' for ${BOARD_NAME}" 1>&2
@@ -129,6 +131,20 @@ for i in ${TARGETS} ; do echo "#define CONFIG_MK_${i} 1" >>config.h ; done +if [ -n "${variant}" ] ; then + echo "#define CONFIG_${variant} 1" >>config.h ; +fi + +# If there's no config file for the configuration, try config file for the +# board instead. +if [ ! -e configs/${CONFIG_NAME}.h ] ; then + if [ -e configs/${board}.h ] ; then + CONFIG_NAME=${board} ; + else + exit 1 ; + fi; +fi + cat << EOF >> config.h #define CONFIG_BOARDDIR board/$BOARDDIR #include <config_defaults.h>
Signature · 1 line
1.7.1
PATCH 2/2 Config: Add "board variant" column to boards.cfg
Dear Marek Vasut,
Quoted 3 lines · In message <[email protected]> you wrote:
There are some boards where it's not currently possible to detect all board information at runtime, therefore I introduced a new column called "variant" to boards.cfg . If this field is set,
CONFIG_fieldvalueis #define-d inconfig.h
Thanks for the start on this, but I would like to see a little more genral approach here.
Passing a single option is IMO not enough. I posted a pretty complete specification of the format I have in mind before:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/81138/focus=81332
Do you think you could adapt your implementation to more in line with that?
Thanks.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de After a heated argument on some trivial matter Nancy [Astor] . . . shouted, ``If I were your wife I would put poison in your coffee!'' Whereupon Winston Churchill with equal heat and sincerity answered, ``And if I were your husband I would drink it.''
PATCH 1/2 USB: Make non-bulk delay longer in OHCI
In reply to Marek VasutHi,
2010/9/20 Marek Vasut <[email protected]>:
Quoted 19 lines
This fixes TIMEOUT with my Kingston 32GB USB3.0 flashdrive, which I experienced on my PXA270 (USB 1.1) Vpac270 board.
Signed-off-by Marek Vasut <[email protected]>---
?drivers/usb/host/ohci-hcd.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)drivers/usb/host/ohci-hcd.c +0
-0@@ -1529,7 +1529,7 @@ int submit_common_msg(struct usb_device *dev, unsigned long pipe, void *buffer, ? ? ? ?if (usb_pipebulk(pipe)) ? ? ? ? ? ? ? ?timeout = BULK_TO;? ? ? ?else
- ? ? ? ? ? ? ? timeout = 100;
+ ? ? ? ? ? ? ? timeout = 1000;
Quoted 2 lines
? ? ? ?/* wait for it to complete */
? ? ? ?for (;;) {
No problem to increase this default timeout.
So, applied to u-boot-usb.
Thanks.
Remy