Skip to contentSkip to conversation

VCMA9 build fails: ARM board references PPC4xx header

U-Boot Wolfgang Denk 3 participants 3 messages Oct 5, 2010 – Oct 6, 2010

lore
Share & tools
lore
#0 lore raw

Dear David & Peter,

since Stefan's ppc4xx reorganization patches (commit b36df561:
"ppc4xx: Move ppc4xx headers to powerpc include directory") the building of the VCMA9 breaks with this error message:

../common/memtst.c:51:28: error: asm/ppc4xx-i2c.h: No such file or directory

The problem comes from board/mpl/common/memtst.c which contains an unconditional "#include <asm/ppc4xx-i2c.h>" which is obviously wrong when the file gets compiled for an ARM board as VCMA9.

Can you please provide a fix?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Everything should be made as simple as possible, but not simpler."
                                                    - Albert Einstein
#1 lore raw
Quoted 5 lines · Wolfgang Denk

The problem comes from board/mpl/common/memtst.c which contains an unconditional "#include <asm/ppc4xx-i2c.h>" which is obviously wrong when the file gets compiled for an ARM board as VCMA9.

Can you please provide a fix?

The solution is to remove the include completely as it is not needed at all.

Dave
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: u-boot-memtst.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20101006/a321175e/attachment.txt

#2 lore raw
Quoted 8 lines · David M?ller (ELSOFT AG)
Quoted 5 lines · Wolfgang Denk

The problem comes from board/mpl/common/memtst.c which contains an unconditional "#include <asm/ppc4xx-i2c.h>" which is obviously wrong when the file gets compiled for an ARM board as VCMA9.

Can you please provide a fix?

The solution is to remove the include completely as it is not needed at all.

Is there any reason to not remove the memtst.c file altogether as in this patch:
http://lists.denx.de/pipermail/u-boot/2010-October/078649.html ?

Best,
Peter