media: consolidation of -I flags

I have been doing cleanup of makefiles, namely replacing the older style compilation flag variables with the newer style. While doing this, I noticed that the majority of drivers in the media subsystem seem to rely on a few core header files:

-Idrivers/media/video
-Idrivers/media/common/tuners
-Idrivers/media/dvb/dvb-core
-Idrivers/media/dvb/frontends

This patch removes them from the individual makefiles and puts them in the main makefile under media.

If neither idea is considered beneficial, I will go ahead and replace the older variables with the newer ones as is.

Quoted 5 lines · matt mooney

I have been doing cleanup of makefiles, namely replacing the older style compilation flag variables with the newer style. While doing this, I noticed that the majority of drivers in the media subsystem seem to rely on a few core header files:

Quoted 7 lines

-Idrivers/media/video
-Idrivers/media/common/tuners
-Idrivers/media/dvb/dvb-core
-Idrivers/media/dvb/frontends

This patch removes them from the individual makefiles and puts them in the main makefile under media.

Using subdir-ccflags-y has one drawback you need to be aware of. The variable is _not_ picked up if you build individual drivers like this:

make drivers/media/dvb/b2c2/

So with this patch applied it is no longer possible to do so. It is better to accept the duplication rather than breaking the build of individual drivers.

Quoted 3 lines

If neither idea is considered beneficial, I will go ahead and replace the older variables with the newer ones as is.

This is the right approach.

You could consider to do a more general cleanup:
1) replace EXTRA_CFLAGS with ccflags-y (the one you suggest)
2) replace use of <module>-objs with <module>-y
3) break continued lines into several assignments
People very often uses '\' to break long lines, where a
simple += would be much more readable.
But this topic may be personal - I never uses "\" in my .c code unless in macros, and I have applied the same rule for Makefiles.
An ugly example is drivers/media/Makefile
4) In general use ":=" instead of "=".
Add using "+=" as first assignment is OK - but it just looks plain wrong
5) some files has a mixture of spaces/tabs (are red in my vim) dvb-core/Makefile is one such example
6) remove useless stuff
siano/Makefile has some strange assignments to EXTRA_CFLAGS
7) Likely a few more items to look after...

This is more work - but then you finish a Makefile rather than doing a simple conversion.

Quoted 5 lines · matt mooney

I have been doing cleanup of makefiles, namely replacing the older style compilation flag variables with the newer style. While doing this, I noticed that the majority of drivers in the media subsystem seem to rely on a few core header files:

Quoted 7 lines

-Idrivers/media/video
-Idrivers/media/common/tuners
-Idrivers/media/dvb/dvb-core
-Idrivers/media/dvb/frontends

This patch removes them from the individual makefiles and puts them in the main makefile under media.

Using subdir-ccflags-y has one drawback you need to be aware of. The variable is _not_ picked up if you build individual drivers like this:

make drivers/media/dvb/b2c2/

So with this patch applied it is no longer possible to do so. It is better to accept the duplication rather than breaking the build of individual drivers.

Quoted 3 lines

If neither idea is considered beneficial, I will go ahead and replace the older variables with the newer ones as is.

This is the right approach.

You could consider to do a more general cleanup:
1) replace EXTRA_CFLAGS with ccflags-y (the one you suggest)
2) replace use of <module>-objs with <module>-y
3) break continued lines into several assignments

People very often uses '\' to break long lines, where a simple += would be much more readable.
But this topic may be personal - I never uses "\" in my .c code unless in
macros,
and I have applied the same rule for Makefiles.
An ugly example is drivers/media/Makefile
4) In general use ":=" instead of "=".
Add using "+=" as first assignment is OK - but it just looks plain wrong
5) some files has a mixture of spaces/tabs (are red in my vim) dvb-core/Makefile is one such example
6) remove useless stuff
siano/Makefile has some strange assignments to EXTRA_CFLAGS
7) Likely a few more items to look after...

This is more work - but then you finish a Makefile rather than doing a simple
conversion.

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Quoted 28 lines · Sam Ravnborg

Quoted 5 lines · matt mooney

I have been doing cleanup of makefiles, namely replacing the older style compilation flag variables with the newer style. While doing this, I noticed that the majority of drivers in the media subsystem seem to rely on a few core header files:

Quoted 7 lines

-Idrivers/media/video
-Idrivers/media/common/tuners
-Idrivers/media/dvb/dvb-core
-Idrivers/media/dvb/frontends

This patch removes them from the individual makefiles and puts them in the main makefile under media.

Using subdir-ccflags-y has one drawback you need to be aware of. The variable is _not_ picked up if you build individual drivers like this:

make drivers/media/dvb/b2c2/

So with this patch applied it is no longer possible to do so. It is better to accept the duplication rather than breaking the build of individual drivers.

Quoted 3 lines

If neither idea is considered beneficial, I will go ahead and replace the older variables with the newer ones as is.

Quoted 6 lines

This is the right approach.

You could consider to do a more general cleanup:
1) replace EXTRA_CFLAGS with ccflags-y (the one you suggest)
2) replace use of <module>-objs with <module>-y
3) break continued lines into several assignments

I have a question when you say this do you mean change something like this:

r8187se-objs :>
to

r8187se-y :

If so, I could start working on that in the staging directory.

Quoted 18 lines

People very often uses '\' to break long lines, where a simple += would be much more readable.
But this topic may be personal - I never uses "\" in my .c code unless in
macros,
and I have applied the same rule for Makefiles.
An ugly example is drivers/media/Makefile
4) In general use ":=" instead of "=".
Add using "+=" as first assignment is OK - but it just looks plain wrong
5) some files has a mixture of spaces/tabs (are red in my vim) dvb-core/Makefile is one such example
6) remove useless stuff
siano/Makefile has some strange assignments to EXTRA_CFLAGS
7) Likely a few more items to look after...

This is more work - but then you finish a Makefile rather than doing a simple
conversion.

Quoted 7 lines

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Thanks,

Tracey D
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 41 lines · T Dent

Quoted 30 lines · Sam Ravnborg

Quoted 7 lines · matt mooney

I have been doing cleanup of makefiles, namely replacing the older style
compilation flag variables with the newer style. While doing this, I noticed that the majority of drivers in the media subsystem seem to rely
on a few core header files:

Quoted 7 lines

-Idrivers/media/video
-Idrivers/media/common/tuners
-Idrivers/media/dvb/dvb-core
-Idrivers/media/dvb/frontends

This patch removes them from the individual makefiles and puts them in the main makefile under media.

Using subdir-ccflags-y has one drawback you need to be aware of. The variable is _not_ picked up if you build individual drivers like this:

make drivers/media/dvb/b2c2/

So with this patch applied it is no longer possible to do so. It is better to accept the duplication rather than breaking the build of individual drivers.

Quoted 3 lines

If neither idea is considered beneficial, I will go ahead and replace the older variables with the newer ones as is.

Quoted 6 lines

This is the right approach.

You could consider to do a more general cleanup:
1) replace EXTRA_CFLAGS with ccflags-y (the one you suggest)
2) replace use of <module>-objs with <module>-y
3) break continued lines into several assignments

I have a question when you say this do you mean change something like this:

Quoted 4 lines

r8187se-objs :>>
to

r8187se-y :>

Yes, that is what is meant, but remember to change conditional inclusions to the
kbuild idiom.

Quoted 2 lines

If so, I could start working on that in the staging directory.

That's cool; the staging makefiles need extra attention though, so you really
need to go through and make sure you understand what is and isn't needed. And
check to see what drivers are on their way out so that you don't waste your time.

Now, I do have some of these queued up for other parts of the kernel, so please
let me know before you start sending in patches for other parts that I have already worked on.

Thanks,
mfm

Quoted 37 lines

Quoted 20 lines

People very often uses '\' to break long lines, where a simple += would be much more readable.
But this topic may be personal - I never uses "\" in my .c code
unless in
macros,
and I have applied the same rule for Makefiles.
An ugly example is drivers/media/Makefile
4) In general use ":=" instead of "=".
Add using "+=" as first assignment is OK - but it just looks plain
wrong
5) some files has a mixture of spaces/tabs (are red in my vim) dvb-core/Makefile is one such example
6) remove useless stuff
siano/Makefile has some strange assignments to EXTRA_CFLAGS
7) Likely a few more items to look after...

This is more work - but then you finish a Makefile rather than doing a simple
conversion.

Quoted 8 lines

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Thanks,

Tracey D
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 18 lines · Sam Ravnborg

Quoted 5 lines · matt mooney

I have been doing cleanup of makefiles, namely replacing the older style compilation flag variables with the newer style. While doing this, I noticed that the majority of drivers in the media subsystem seem to rely on a few core header files:

Quoted 7 lines

-Idrivers/media/video
-Idrivers/media/common/tuners
-Idrivers/media/dvb/dvb-core
-Idrivers/media/dvb/frontends

This patch removes them from the individual makefiles and puts them in the main makefile under media.

Using subdir-ccflags-y has one drawback you need to be aware of. The variable is _not_ picked up if you build individual drivers like this:

Quoted 5 lines

make drivers/media/dvb/b2c2/

So with this patch applied it is no longer possible to do so. It is better to accept the duplication rather than breaking the build of individual drivers.

Ah, I was not aware of that, and I forgot to test for that case.

Quoted 23 lines

Quoted 3 lines

If neither idea is considered beneficial, I will go ahead and replace the older variables with the newer ones as is.

This is the right approach.

You could consider to do a more general cleanup:
1) replace EXTRA_CFLAGS with ccflags-y (the one you suggest)
2) replace use of <module>-objs with <module>-y
3) break continued lines into several assignments
People very often uses '\' to break long lines, where a
simple += would be much more readable.
But this topic may be personal - I never uses "\" in my .c code unless in macros, and I have applied the same rule for Makefiles.
An ugly example is drivers/media/Makefile
4) In general use ":=" instead of "=".
Add using "+=" as first assignment is OK - but it just looks plain wrong
5) some files has a mixture of spaces/tabs (are red in my vim) dvb-core/Makefile is one such example
6) remove useless stuff
siano/Makefile has some strange assignments to EXTRA_CFLAGS
7) Likely a few more items to look after...

Quoted 2 lines

This is more work - but then you finish a Makefile rather than doing a simple conversion.

I agree with all your points above; however, I was unsure of whether a wholesale cleanup would be welcomed because I would then end up touching numerous lines (and in some cases, possibly all lines). I did notice, though, the need for quite a bit of cleanup like you have mentioned, and I have a few patches queued up that make a second pass on some files changing <module>-objs to <module>-y. You know better than I do, so if you feel I should cleanup the whole file in one patch, then that is what I will do although this will take some time.

Is the use of <module>-objs deprecated? Some people might wonder why I am changing that when they are not building a multisource object.

Ah, I was not aware of that, and I forgot to test for that case.

Quoted 23 lines

Quoted 3 lines

If neither idea is considered beneficial, I will go ahead and replace the older variables with the newer ones as is.

This is the right approach.

You could consider to do a more general cleanup:
1) replace EXTRA_CFLAGS with ccflags-y (the one you suggest)
2) replace use of <module>-objs with <module>-y
3) break continued lines into several assignments
People very often uses '\' to break long lines, where a
simple += would be much more readable.
But this topic may be personal - I never uses "\" in my .c code unless in macros, and I have applied the same rule for Makefiles.
An ugly example is drivers/media/Makefile
4) In general use ":=" instead of "=".
Add using "+=" as first assignment is OK - but it just looks plain wrong
5) some files has a mixture of spaces/tabs (are red in my vim) dvb-core/Makefile is one such example
6) remove useless stuff
siano/Makefile has some strange assignments to EXTRA_CFLAGS
7) Likely a few more items to look after...

Quoted 2 lines

This is more work - but then you finish a Makefile rather than doing a simple conversion.

I agree with all your points above; however, I was unsure of whether a wholesale cleanup would be welcomed because I would then end up touching numerous lines (and in some cases, possibly all lines).

Is the use of <module>-objs deprecated? Some people might wonder why I am changing that when they are not building a multisource object.