board_init_r: Removed unused cmdtp variable
Subsystems (2)
PATCH 1/1 board_init_r: Removed unused cmdtp variable
From 38c6ceb464f63d3705d30d6603624e7d0933f428 Mon Sep 17 00:00:00 2001
From: Richard Retanubun <[email protected]>
Date: Fri, 1 Oct 2010 10:17:26 -0400
Subject: [PATCH] board_init_r: Removed unused cmdtp variable
Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02 removed compiler warning for (now) unused cmd_tbl_t* cmdtp
---
Hi Heiko,
Not sure if you caught this one already, just a simple unused variable cleanup
- Richard
arch/avr32/lib/board.c | 1 - arch/m68k/lib/board.c | 1 - arch/mips/lib/board.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-)
arch/avr32/lib/board.c +0 -1
@@ -257,7 +257,6 @@ void board_init_r(gd_t *new_gd, ulong dest_addr)extern char * env_name_spec;#endif char *s; -cmd_tbl_t *cmdtp;bd_t *bd; gd = new_gd;
arch/m68k/lib/board.c +0 -1
@@ -405,7 +405,6 @@ board_init_f (ulong bootflag)*/ void board_init_r (gd_t *id,ulong dest_addr) { -cmd_tbl_t *cmdtp;char *s;bd_t *bd;extern void malloc_bin_reloc (void );
arch/mips/lib/board.c +0 -1
@@ -284,7 +284,6 @@ void board_init_f(ulong bootflag)void board_init_r (gd_t *id,ulong dest_addr) { -cmd_tbl_t *cmdtp;#ifndef CONFIG_SYS_NO_FLASH ulong size;#endif
Signature · 1 line
1.7.1
PATCH 1/1 board_init_r: Removed unused cmdtp variable
Hello Richard,
Quoted 5 lines · Richard Retanubun
From
38c6ceb464f63d3705d30d6603624e7d0933f428Mon Sep 17 00:00:00 2001
From: Richard Retanubun <[email protected]>
Date: Fri, 1 Oct 2010 10:17:26 -0400
Subject: [PATCH]board_init_r: Removed unused cmdtp variable
Quoted 8 lines
Follow up to commit
620f1f6a64095ed558e68d37f1965d015cd49b02removed compiler warning for (now) unused cmd_tbl_t* cmdtp
---Hi Heiko,
Not sure if you caught this one already, just a simple unused variable cleanup
Thanks, but already fixed in arch/arm/lib/board.c
bye,
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH 1/1 board_init_r: Removed unused cmdtp variable
Quoted 6 lines
Quoted 6 lines
Follow up to commit
620f1f6a64095ed558e68d37f1965d015cd49b02removed compiler warning for (now) unused cmd_tbl_t* cmdtp
---Hi Heiko,
Quoted 7 lines
Quoted 2 lines
Not sure if you caught this one already, just a simple unused variable cleanup
Thanks, but already fixed in
arch/arm/lib/board.cbye,
Heiko
Hi Heiko,
Does this mean I should cc the respective maintainers for
avr32, m68k, and mips arch (the ones I found in my patch) to have them applied it? or was that a typo and you mean the patch is already applied
on the ARM branch of the git repo?
Thanks,
- Richard
PATCH 1/1 board_init_r: Removed unused cmdtp variable
Hello Richard,
Quoted 10 lines · Richard Retanubun
Quoted 10 lines
Quoted 8 lines
Follow up to commit
620f1f6a64095ed558e68d37f1965d015cd49b02removed compiler warning for (now) unused cmd_tbl_t* cmdtp
---Hi Heiko,
Not sure if you caught this one already, just a simple unused variable cleanup
Thanks, but already fixed in
arch/arm/lib/board.c
Quoted 7 lines
Quoted 2 lines
bye,
HeikoHi Heiko,
Does this mean I should cc the respective maintainers for
avr32, m68k, and mips arch (the ones I found in my patch) to have them applied it?
Yes.
Quoted 2 lines
or was that a typo and you mean the patch is already applied on the ARM branch of the git repo?
I meant with "already fixed in arch/arm/lib/board.c", that in arch/arm/lib/board.c there is no such unused variable in code, so no need for fixing it there.
bye,
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH 1/1 board_init_r: Removed unused cmdtp variable
In reply to Richard RetanubunDear Richard Retanubun,
Quoted 11 lines · In message <[email protected]> you wrote:
From
38c6ceb464f63d3705d30d6603624e7d0933f428Mon Sep 17 00:00:00 2001
From: Richard Retanubun <[email protected]>
Date: Fri, 1 Oct 2010 10:17:26 -0400
Subject: [PATCH]board_init_r: Removed unused cmdtp variableFollow up to commit
620f1f6a64095ed558e68d37f1965d015cd49b02removed compiler warning for (now) unused cmd_tbl_t* cmdtp
---Hi Heiko,
Quoted 8 lines
Not sure if you caught this one already, just a simple unused variable cleanup
- Richard
arch/avr32/lib/board.c | 1 - arch/m68k/lib/board.c | 1 - arch/mips/lib/board.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-)
This patch does not apply (I think it is white-space corrupted):
Applying: board_init_r: Removed unused cmdtp variable Using index info to reconstruct a base tree...
error: patch failed: arch/avr32/lib/board.c:257
error: arch/avr32/lib/board.c: patch does not apply
error: patch failed: arch/m68k/lib/board.c:405
error: arch/m68k/lib/board.c: patch does not apply
error: patch failed: arch/mips/lib/board.c:284
error: arch/mips/lib/board.c: patch does not apply
Did you hand edit your patch?
It does not apply to blobs recorded in its index. Cannot fall back to three-way merge.
Patch failed at 0001 board_init_r: Removed unused cmdtp variable
Please fix and resubmit.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de To understand a program you must become both the machine and the program.
[U-Boot] (no subject)
Hi Wolfgang, sorry for the delay, here is the patch sent using git send-email.
PATCH 2/6 board_init_r: Removed unused cmdtp variable
In reply to Wolfgang DenkFrom: Richard Retanubun <[email protected]>
Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02 removed compiler warning for (now) unused cmd_tbl_t* cmdtp
--- arch/avr32/lib/board.c | 1 - arch/m68k/lib/board.c | 1 - arch/mips/lib/board.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-)
arch/avr32/lib/board.c +0 -1
@@ -257,7 +257,6 @@ void board_init_r(gd_t *new_gd, ulong dest_addr)extern char * env_name_spec;#endif char *s; -cmd_tbl_t *cmdtp;bd_t *bd; gd = new_gd;
arch/m68k/lib/board.c +0 -1
@@ -397,7 +397,6 @@ board_init_f (ulong bootflag)*/ void board_init_r (gd_t *id,ulong dest_addr) { -cmd_tbl_t *cmdtp;char *s;bd_t *bd;extern void malloc_bin_reloc (void );
arch/mips/lib/board.c +0 -1
@@ -276,7 +276,6 @@ void board_init_f(ulong bootflag)void board_init_r (gd_t *id,ulong dest_addr) { -cmd_tbl_t *cmdtp;#ifndef CONFIG_SYS_NO_FLASH ulong size;#endif
Signature · 1 line
1.7.1
Wolfgang Denk
AppliedPATCH 2/6 board_init_r: Removed unused cmdtp variable
Dear Richard Retanubun,
Quoted 9 lines · In message <[email protected]>…
From: Richard Retanubun <[email protected]>
Follow up to commit
620f1f6a64095ed558e68d37f1965d015cd49b02removed compiler warning for (now) unused cmd_tbl_t* cmdtp--- arch/avr32/lib/board.c | 1 - arch/m68k/lib/board.c | 1 - arch/mips/lib/board.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de After a heated argument on some trivial matter Nancy [Astor] . . . shouted, ``If I were your wife I would put poison in your coffee!'' Whereupon Winston Churchill with equal heat and sincerity answered, ``And if I were your husband I would drink it.''