Skip to contentSkip to conversation

net: netif_set_real_num_rx_queues may cap num_rx_queues at init time

PATCH New Jeff Kirsher 1 participant 1 message Oct 7, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: netif_set_real_num_rx_queues may cap num_rx_queues at init time

From: John Fastabend <[email protected]>

Do not set num_rx_queues in netif_set_real_num_rx_queues() some drivers will increase the real_num_rx_queues later due to a feature changes or available interrupts increasing. By setting num_rx_queues here this ends up creating a cap on the number of rx queues available.

For example the ixgbe driver sets the max number of queues it intends to use ever then sets the current number in use with the netif_set_num_{rx|tx}_queues calls. With the current implementation the number of rx queues gets limited so when a feature such as DCB or FCoE is enabled the queues are no longer available.

kobjects will only be allocated for real_num_rx_queues so the waste in memory is minimal.

CC Ben Hutchings <[email protected]>
CC Eric Dumazet <[email protected]>

---

 net/core/dev.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
net/core/dev.c +0 -2
index 7d14955..fd1b75a 100644
@@ -1593,8 +1593,6 @@ int netif_set_real_num_rx_queues(struct net_device *dev, unsigned int rxq)
 						  rxq);
 		if (rc)
 			return rc;
-	} else {
-		dev->num_rx_queues = rxq;
 	}
 
 	dev->real_num_rx_queues = rxq;