V4L/DVB: lirc_igorplugusb: Fix a compilation waring

PATCH In review Mauro Carvalho Chehab 1 participant 2 messages Oct 7, 2010 1 message not in the archive

Subsystems (2)

Share & tools

A message that is not in the archive (sent off-list or not yet received): f3a134520bf3f816b8f7192426af875603a1434e.1286455481.git.mchehab@redhat.com

Mauro Carvalho Chehab

author

2010-10-07 12:46 UTC #1 lore raw

PATCH 2/3 V4L/DVB: lirc_igorplugusb: Fix a compilation waring

drivers/staging/lirc/lirc_igorplugusb.c: In function ‘usb_remote_probe’:
drivers/staging/lirc/lirc_igorplugusb.c:393: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 3 has type ‘unsigned int’

Signed-off-by Mauro Carvalho Chehab <[email protected]>

drivers/staging/lirc/lirc_igorplugusb.c +1 -1

index bce600e..e680d88 100644
@@ -390,7 +390,7 @@ static int usb_remote_probe(struct usb_interface *intf,
 	devnum = dev->devnum;
 	maxp = usb_maxpacket(dev, pipe, usb_pipeout(pipe));
 
-	dprintk(DRIVER_NAME "[%d]: bytes_in_key=%lu maxp=%d\n",
+	dprintk(DRIVER_NAME "[%d]: bytes_in_key=%zu maxp=%d\n",
 		devnum, CODE_LENGTH, maxp);

Signature · 1 line

1.7.1

Mauro Carvalho Chehab

author

2010-10-07 12:47 UTC #2 lore raw

PATCH 3/3 V4L/DVB: staging/tm6000: Fix a warning message

In reply to a message not in the archive

I added a code to the driver to force it to produce a warning. This were intended to remind me about a very bad hack. I never found a way to workaround. So, instead of those warnings:

drivers/staging/tm6000/tm6000-core.c: In function ‘tm6000_init_analog_mode’:
drivers/staging/tm6000/tm6000-core.c:328: warning: ISO C90 forbids mixed declarations and code

Let's document the issue and hope if someone with the support of the vendor might fix it.

Signed-off-by Mauro Carvalho Chehab <[email protected]>

drivers/staging/tm6000/tm6000-core.c +12 -2

index 57cb69e..3d82510 100644
@@ -188,6 +188,8 @@ void tm6000_set_fourcc_format(struct tm6000_core *dev)
 
 int tm6000_init_analog_mode(struct tm6000_core *dev)
 {
+	struct v4l2_frequency f;
+
 	if (dev->dev_type == TM6010) {
 		int val;

@@ -324,8 +326,16 @@ int tm6000_init_analog_mode(struct tm6000_core *dev)
 
 	/* Tuner firmware can now be loaded */
 
-	/*FIXME: Hack!!! */
-	struct v4l2_frequency f;
+	/*
+	 * FIXME: This is a hack! xc3028 "sleeps" when no channel is detected
+	 * for more than a few seconds. Not sure why, as this behavior does
+	 * not happen on other devices with xc3028. So, I suspect that it
+	 * is yet another bug at tm6000. After start sleeping, decoding 
+	 * doesn't start automatically. Instead, it requires some
+	 * I2C commands to wake it up. As we want to have image at the
+	 * beginning, we needed to add this hack. The better would be to
+	 * discover some way to make tm6000 to wake up without this hack.
+	 */
 	mutex_lock(&dev->lock);
 	f.frequency = dev->freq;
 	v4l2_device_call_all(&dev->v4l2_dev, 0, tuner, s_frequency, &f);

Signature · 1 line

1.7.1