Skip to contentSkip to conversation

POST: Add POST_ALWAYS to UART POST test

PATCH New Stefan Roese 2 participants 4 messages Sep 29, 2010 – Oct 7, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 POST: Add POST_ALWAYS to UART POST test

From: Sascha Laue <[email protected]>

Needed to ensure that this UART POST is always excecuted.

---
 post/tests.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
post/tests.c +1 -1
index a4066f9..02bf538 100644
@@ -169,7 +169,7 @@ struct post_test post_list[] =
 	"UART test",
 	"uart",
 	"This test verifies the UART operation.",
-	POST_RAM | POST_SLOWTEST | POST_MANUAL,
+	POST_RAM | POST_SLOWTEST | POST_ALWAYS | POST_MANUAL,
 	&uart_post_test,
 	NULL,
 	NULL,
Signature · 1 line
1.7.3
#1 lore raw

PATCH 1/1 POST: Add POST_ALWAYS to UART POST test

Dear Stefan Roese,

Quoted 15 lines · In message <[email protected]> you wrote:

From: Sascha Laue <[email protected]>

Needed to ensure that this UART POST is always excecuted.

---
 post/tests.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
post/tests.c +0 -0
index a4066f9..02bf538 100644

post/tests.c struct post_test post_list[] = · line 172

Quoted 5 lines
post/tests.c +1 -1
@@ -169,7 +169,7 @@ struct post_test post_list[] =
 	"UART test",
 	"uart",
 	"This test verifies the UART operation.",
-	POST_RAM | POST_SLOWTEST | POST_MANUAL,
+	POST_RAM | POST_SLOWTEST | POST_ALWAYS | POST_MANUAL,

Instead of globally enforcing this for all boards, can this not be done in a board specific way?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Brain off-line, please wait.
#2 lore raw

PATCH 1/1 POST: Add POST_ALWAYS to UART POST test

Hi Wolfgang,

Quoted 10 lines · On Wednesday 06 October 2010 23:04:36 Wolfgang Denk wrote:
Quoted 10 lines
post/tests.c +0 -0
index a4066f9..02bf538 100644
@@ -169,7 +169,7 @@ struct post_test post_list[] =
 
 	"UART test",
 	"uart",
 	"This test verifies the UART operation.",
 
Quoted 5 lines

post/tests.c struct post_test post_list[] = · line 172

Quoted 2 lines
post/tests.c +1 -1
-	POST_RAM | POST_SLOWTEST | POST_MANUAL,
+	POST_RAM | POST_SLOWTEST | POST_ALWAYS | POST_MANUAL,

Instead of globally enforcing this for all boards, can this not be done in a board specific way?

Yes, can be done. I could make it board specific as already done for other POST tests:

#if CONFIG_POST & CONFIG_SYS_POST_UART
#if defined(CONFIG_POST_UART)
CONFIG_POST_UART,

#else
    {
	"UART test",
	"uart",
	"This test verifies the UART operation.",
	POST_RAM | POST_SLOWTEST | POST_MANUAL,
	&uart_post_test,
	NULL,
	NULL,
	CONFIG_SYS_POST_UART
    },

#endif

So the board config header could provide a board specific test by defining CONFIG_POST_UART. Is this what you would prefer?

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

#3 lore raw

PATCH 1/1 POST: Add POST_ALWAYS to UART POST test

Dear Stefan Roese,

Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 3 lines

Instead of globally enforcing this for all boards, can this not be done in a board specific way?

Yes, can be done. I could make it board specific as already done for other POST tests:

...

Quoted 2 lines

So the board config header could provide a board specific test by defining CONFIG_POST_UART. Is this what you would prefer?

Yes, indeed. Thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Here is an Appalachian version of management's answer  to  those  who
are  concerned  with  the fate of the project: "Don't worry about the
mule. Just load the wagon."         - Mike Dennison's hillbilly uncle