Staging: bcm: remove unneeded NULL check

PATCH New Dan Carpenter 1 participant 1 message Oct 8, 2010

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-10-08 12:57 UTC #0 lore raw

PATCH 1/1 Staging: bcm: remove unneeded NULL check

The error handling here is wrong. If psIntfAdapter were NULL then we would have a NULL dereference in the debug output on the error path. But this function is only called from usbbcm_device_probe() when psIntfAdapter is non-NULL.

Since the check isn't needed and I removed it instead of fixing it.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/bcm/InterfaceInit.c +0 -5

index 81523b1..824f9a4 100644
@@ -529,11 +529,6 @@ INT InterfaceAdapterInit(PS_INTERFACE_ADAPTER psIntfAdapter)
 	BOOLEAN bBcm16 = FALSE;
 	UINT uiData = 0;
 
-	if(psIntfAdapter = NULL)
-	{
-		BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_INITEXIT, DRV_ENTRY, DBG_LVL_ALL, "Interface Adapter is NULL");
-		return -EINVAL;
-	}
 	/* Store the usb dev into interface adapter */
 	psIntfAdapter->udev = usb_get_dev(interface_to_usbdev(
 								psIntfAdapter->interface));