Skip to contentSkip to conversation

drm/radeon/kms: Silent spurious error message

PATCH In review Jean Delvare 2 participants 2 messages Oct 8, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/radeon/kms: Silent spurious error message

I see the following error message in my kernel log from time to time:
radeon 0000:07:00.0: ffff88007c334000 reserve failed for wait radeon 0000:07:00.0: ffff88007c334000 reserve failed for wait

After investigation, it turns out that there's nothing to be afraid of and everything works as intended. So remove the spurious log message.

---
 drivers/gpu/drm/radeon/radeon_object.h |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/radeon/radeon_object.h +1 -4
@@ -124,11 +124,8 @@ static inline int radeon_bo_wait(struct
 	int r;
 
 	r = ttm_bo_reserve(&bo->tbo, true, no_wait, false, 0);
-	if (unlikely(r != 0)) {
-		if (r != -ERESTARTSYS)
-			dev_err(bo->rdev->dev, "%p reserve failed for wait\n", bo);
+	if (unlikely(r != 0))
 		return r;
-	}
 	spin_lock(&bo->tbo.lock);
 	if (mem_type)
 		*mem_type = bo->tbo.mem.mem_type;
Signature · 1 line
Jean Delvare
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · ----- "Jean Delvare

I see the following error message in my kernel log from time to time:
radeon 0000:07:00.0: ffff88007c334000 reserve failed for wait radeon 0000:07:00.0: ffff88007c334000 reserve failed for wait

After investigation, it turns out that there's nothing to be afraid of
and everything works as intended. So remove the spurious log message.

Quoted 25 lines
---
 drivers/gpu/drm/radeon/radeon_object.h |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- linux-2.6.36-rc7.orig/drivers/gpu/drm/radeon/radeon_object.h

2010-10-08 13:32:46.000000000 +0200

+++ linux-2.6.36-rc7/drivers/gpu/drm/radeon/radeon_object.h 2010-10-08
13:33:05.000000000 +0200

drivers/gpu/drm/radeon/radeon_object.h +1 -4
@@ -124,11 +124,8 @@ static inline int radeon_bo_wait(struct
 	int r;
 
 	r = ttm_bo_reserve(&bo->tbo, true, no_wait, false, 0);
-	if (unlikely(r != 0)) {
-		if (r != -ERESTARTSYS)
-			dev_err(bo->rdev->dev, "%p reserve failed for wait\n", bo);
+	if (unlikely(r != 0))
 		return r;
-	}
 	spin_lock(&bo->tbo.lock);
 	if (mem_type)
 		*mem_type = bo->tbo.mem.mem_type;
Signature · 2 lines
-- 
Jean Delvare