Skip to contentSkip to conversation

kconfig rc fixes

GIT In review Michal Marek 7 participants 39 messages Oct 9, 2010 – May 2, 2011

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

Hi Linus,

I have three fixes that should ideally go into 2.6.36:

1) Kyle's make oldnoconfig fix: make oldnoconfig was added and later got broken, all in 2.6.36-rc1.
2) Arnaud's fix for a crash in kconfig caused by a use-after-free bug. This fix has the unfortunate side effect that most configurations (e.g. make defconfig on x86) start printing warnings several lines long. These warnings are valid, but were not detected before. To avoid receiving tens of reports about this once 2.6.36 is out, I decided to comment out the warnings completely for the final release, as there is not enough time to fix the root causes.

Please consider for 2.6.36. Or if you are only willing to take either 1) or 2), let me know and I'll prepare such branch.

Thanks,
Michal

The following changes since commit cb655d0f3d57c23db51b981648e452988c0223f9:

Linux 2.6.36-rc7 (2010-10-06 13:39:52 -0700)

are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6.git rc-fixes

Arnaud Lacombe (1):
kconfig: delay symbol direct dependency initialization

Kyle McMartin (1):
kbuild: fix oldnoconfig to do the right thing

Michal Marek (1):
kconfig: Temporarily disable dependency warnings

 scripts/kconfig/conf.c   |    2 +-
 scripts/kconfig/expr.h   |    1 -
 scripts/kconfig/menu.c   |    7 ++-----
 scripts/kconfig/symbol.c |    2 ++
 4 files changed, 5 insertions(+), 7 deletions(-)
#1 lore raw

REGRESSION: Re: [GIT] kconfig rc fixes

Hi Michal,

Em 09-10-2010 18:40, Michal Marek escreveu:

Quoted 23 lines

Hi Linus,

I have three fixes that should ideally go into 2.6.36:

1) Kyle's make oldnoconfig fix: make oldnoconfig was added and later got broken, all in 2.6.36-rc1.
2) Arnaud's fix for a crash in kconfig caused by a use-after-free bug. This fix has the unfortunate side effect that most configurations (e.g. make defconfig on x86) start printing warnings several lines long. These warnings are valid, but were not detected before. To avoid receiving tens of reports about this once 2.6.36 is out, I decided to comment out the warnings completely for the final release, as there is not enough time to fix the root causes.

Please consider for 2.6.36. Or if you are only willing to take either 1) or 2), let me know and I'll prepare such branch.

Thanks,
Michal

The following changes since commit cb655d0f3d57c23db51b981648e452988c0223f9:

Quoted 7 lines

Linux 2.6.36-rc7 (2010-10-06 13:39:52 -0700)

are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6.git rc-fixes

Arnaud Lacombe (1):
kconfig: delay symbol direct dependency initialization

This patch generated a regression with V4L build. After applying it, some Kconfig dependencies that used to work with V4L Kconfig broke.

Basically, we have things there like:

config VIDEO_HELPER_CHIPS_AUTO
bool "Autoselect pertinent encoders/decoders and other helper chips"

config VIDEO_IVTV
select VIDEO_WM8739 if VIDEO_HELPER_CHIPS_AUTO

menu "Encoders/decoders and other helper chips"
depends on !VIDEO_HELPER_CHIPS_AUTO

config VIDEO_WM8739
tristate "Wolfson Microelectronics WM8739 stereo audio ADC"

The hole idea is that, by default, all I2C drivers that might be used by an IVTV variant are compiled by default, but user can opt to un-select the drivers that he didn't actually need, in order to create a kernel with a smaller footprint.

This works fine on up to 2.6.35. However, with changeset ff5ff6060bf880aac233e68dd666cbe9e39ec620, this behavior is now broken (see the enclosed logs).

Please take a look on it and provide us some fix.

Thanks!
Mauro.

---

warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_WM8739 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_SAA7127 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_VP27SMPX which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_CX18 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && DVB_CORE && PCI && I2C && EXPERIMENTAL && INPUT && VIDEO_IR) selects VIDEO_CS5345 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_M52790 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_CX88 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_DEV && PCI && I2C && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO || VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR || VIDEO_PVRUSB2 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && VIDEO_V4L2 && I2C && VIDEO_MEDIA) selects VIDEO_WM8775 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_MXB && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && VIDEO_V4L2 && I2C && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_TDA9840 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && !VIDEO_HELPER_CHIPS_AUTO && I2C)
warning: (VIDEO_ZORAN_BUZ && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO || VIDEO_ZORAN_LML33R10 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO || VIDEO_MXB && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && VIDEO_V4L2 && I2C && VIDEO_HELPER_CHIPS_AUTO || VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR || VIDEO_PVRUSB2 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && VIDEO_V4L2 && I2C && VIDEO_MEDIA || VIDEO_EM28XX && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && V4L_USB_DRIVERS && USB && VIDEO_DEV && I2C && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO || VIDEO_USBVISION && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && I2C && VIDEO_V4L2 && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_SAA711X which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_ DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_EM28XX && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && V4L_USB_DRIVERS && USB && VIDEO_DEV && I2C && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_TVP5150 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_UPD64083 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_MXB && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && VIDEO_V4L2 && I2C && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_TEA6420 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && !VIDEO_HELPER_CHIPS_AUTO && I2C)
warning: (VIDEO_ZORAN_AVS6EYES && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && EXPERIMENTAL && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_KS0127 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR || VIDEO_PVRUSB2 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && VIDEO_V4L2 && I2C && VIDEO_MEDIA) selects VIDEO_CS53L32A which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_SAA717X which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_UPD64031A which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_CX23885 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && DVB_CORE && VIDEO_DEV && PCI && I2C && INPUT && IR_CORE || VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR || VIDEO_PVRUSB2 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && VIDEO_V4L2 && I2C && VIDEO_MEDIA || VIDEO_CX231XX && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && V4L_USB_DRIVERS && USB && VIDEO_DEV && I2C && INPUT && VIDEO_IR || VIDEO_CX25821 && STAGING && !STAGING_EXCLUDE_BUILD && DVB_CORE && VIDEO_DEV && PCI && I2C && INPUT && BKL && VIDEO_IR) selects VIDEO_CX25840 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_ZORAN_DC30 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN && VIDEO_HELPER_CHIPS_AUTO || VIDEO_ZORAN_DC10 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_ADV7175 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (OLPC && X86_32) selects OLPC_OPENFIRMWARE which has unmet direct dependencies (X86_32 && !X86_64 && !X86_PAE)
warning: (VIDEO_ZORAN_LML33R10 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_ADV7170 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_ZORAN_DC30 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_VPX3220 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_ZORAN_LML33 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_BT819 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_CX88_BLACKBIRD && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_CX88 || VIDEO_CX23885 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && DVB_CORE && VIDEO_DEV && PCI && I2C && INPUT && IR_CORE || VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR || VIDEO_CX18 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && DVB_CORE && PCI && I2C && EXPERIMENTAL && INPUT && VIDEO_IR || VIDEO_PVRUSB2 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && VIDEO_V4L2 && I2C && VIDEO_MEDIA || VIDEO_CX231XX && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && V4L_USB_DRIVERS && USB && VIDEO_DEV && I2C && INPUT && VIDEO_IR || VIDEO_CX25821 && STAGING && !STAGING_EXCLUDE_BUILD && DVB_CORE && VIDEO_DEV && PCI && I2C && INPUT && BKL && VIDEO_IR) selects VIDEO_CX2341X which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V 4L2 && VIDEO_V4L2_COMMON)
warning: (VIDEO_MXB && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && VIDEO_V4L2 && I2C && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_TEA6415C which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && !VIDEO_HELPER_CHIPS_AUTO && I2C)
warning: (VIDEO_ZORAN_BUZ && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_SAA7185 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_EM28XX && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && V4L_USB_DRIVERS && USB && VIDEO_DEV && I2C && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_MT9V011 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && I2C && VIDEO_V4L2)
warning: (VIDEO_BT848 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_DEV && PCI && I2C && VIDEO_V4L2 && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO || VIDEO_SAA7134 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_DEV && PCI && I2C && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_SAA6588 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_BT848 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_DEV && PCI && I2C && VIDEO_V4L2 && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_TDA7432 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_CAFE_CCIC && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && I2C && VIDEO_V4L2 || VIDEO_VIA_CAMERA && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && FB_VIA) selects VIDEO_OV7670 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && I2C && VIDEO_V4L2)
warning: (VIDEO_BT848 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_DEV && PCI && I2C && VIDEO_V4L2 && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO || VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR || VIDEO_PVRUSB2 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && VIDEO_V4L2 && I2C && VIDEO_MEDIA || VIDEO_EM28XX && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && V4L_USB_DRIVERS && USB && VIDEO_DEV && I2C && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_MSP3400 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_ZORAN_LML33 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO || VIDEO_ZORAN_AVS6EYES && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && EXPERIMENTAL && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_BT856 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_BT848 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_DEV && PCI && I2C && VIDEO_V4L2 && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_TVAUDIO which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_ZORAN_DC10 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_SAA7110 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_ZORAN_AVS6EYES && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && EXPERIMENTAL && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_BT866 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_WM8739 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_SAA7127 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_VP27SMPX which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_CX18 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && DVB_CORE && PCI && I2C && EXPERIMENTAL && INPUT && VIDEO_IR) selects VIDEO_CS5345 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_M52790 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_CX88 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_DEV && PCI && I2C && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO || VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR || VIDEO_PVRUSB2 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && VIDEO_V4L2 && I2C && VIDEO_MEDIA) selects VIDEO_WM8775 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_MXB && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && VIDEO_V4L2 && I2C && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_TDA9840 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && !VIDEO_HELPER_CHIPS_AUTO && I2C)
warning: (VIDEO_ZORAN_BUZ && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO || VIDEO_ZORAN_LML33R10 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO || VIDEO_MXB && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && VIDEO_V4L2 && I2C && VIDEO_HELPER_CHIPS_AUTO || VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR || VIDEO_PVRUSB2 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && VIDEO_V4L2 && I2C && VIDEO_MEDIA || VIDEO_EM28XX && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && V4L_USB_DRIVERS && USB && VIDEO_DEV && I2C && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO || VIDEO_USBVISION && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && I2C && VIDEO_V4L2 && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_SAA711X which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_ DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_EM28XX && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && V4L_USB_DRIVERS && USB && VIDEO_DEV && I2C && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_TVP5150 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_UPD64083 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_MXB && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && VIDEO_V4L2 && I2C && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_TEA6420 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && !VIDEO_HELPER_CHIPS_AUTO && I2C)
warning: (VIDEO_ZORAN_AVS6EYES && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && EXPERIMENTAL && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_KS0127 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR || VIDEO_PVRUSB2 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && VIDEO_V4L2 && I2C && VIDEO_MEDIA) selects VIDEO_CS53L32A which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_SAA717X which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR) selects VIDEO_UPD64031A which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_CX23885 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && DVB_CORE && VIDEO_DEV && PCI && I2C && INPUT && IR_CORE || VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR || VIDEO_PVRUSB2 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && VIDEO_V4L2 && I2C && VIDEO_MEDIA || VIDEO_CX231XX && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && V4L_USB_DRIVERS && USB && VIDEO_DEV && I2C && INPUT && VIDEO_IR || VIDEO_CX25821 && STAGING && !STAGING_EXCLUDE_BUILD && DVB_CORE && VIDEO_DEV && PCI && I2C && INPUT && BKL && VIDEO_IR) selects VIDEO_CX25840 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_ZORAN_DC30 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN && VIDEO_HELPER_CHIPS_AUTO || VIDEO_ZORAN_DC10 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_ADV7175 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (OLPC && X86_32) selects OLPC_OPENFIRMWARE which has unmet direct dependencies (X86_32 && !X86_64 && !X86_PAE)
warning: (VIDEO_ZORAN_LML33R10 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_ADV7170 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_ZORAN_DC30 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_VPX3220 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_ZORAN_LML33 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_BT819 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_CX88_BLACKBIRD && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_CX88 || VIDEO_CX23885 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && DVB_CORE && VIDEO_DEV && PCI && I2C && INPUT && IR_CORE || VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR || VIDEO_CX18 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && DVB_CORE && PCI && I2C && EXPERIMENTAL && INPUT && VIDEO_IR || VIDEO_PVRUSB2 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && VIDEO_V4L2 && I2C && VIDEO_MEDIA || VIDEO_CX231XX && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && V4L_USB_DRIVERS && USB && VIDEO_DEV && I2C && INPUT && VIDEO_IR || VIDEO_CX25821 && STAGING && !STAGING_EXCLUDE_BUILD && DVB_CORE && VIDEO_DEV && PCI && I2C && INPUT && BKL && VIDEO_IR) selects VIDEO_CX2341X which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V 4L2 && VIDEO_V4L2_COMMON)
warning: (VIDEO_MXB && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && VIDEO_V4L2 && I2C && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_TEA6415C which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && !VIDEO_HELPER_CHIPS_AUTO && I2C)
warning: (VIDEO_ZORAN_BUZ && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_SAA7185 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_EM28XX && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && V4L_USB_DRIVERS && USB && VIDEO_DEV && I2C && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_MT9V011 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && I2C && VIDEO_V4L2)
warning: (VIDEO_BT848 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_DEV && PCI && I2C && VIDEO_V4L2 && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO || VIDEO_SAA7134 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_DEV && PCI && I2C && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_SAA6588 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_BT848 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_DEV && PCI && I2C && VIDEO_V4L2 && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_TDA7432 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_CAFE_CCIC && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && I2C && VIDEO_V4L2 || VIDEO_VIA_CAMERA && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && FB_VIA) selects VIDEO_OV7670 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && I2C && VIDEO_V4L2)
warning: (VIDEO_BT848 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_DEV && PCI && I2C && VIDEO_V4L2 && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO || VIDEO_IVTV && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && PCI && I2C && INPUT && VIDEO_IR || VIDEO_PVRUSB2 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && V4L_USB_DRIVERS && USB && VIDEO_V4L2 && I2C && VIDEO_MEDIA || VIDEO_EM28XX && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && V4L_USB_DRIVERS && USB && VIDEO_DEV && I2C && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_MSP3400 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_ZORAN_LML33 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO || VIDEO_ZORAN_AVS6EYES && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && EXPERIMENTAL && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_BT856 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_BT848 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_DEV && PCI && I2C && VIDEO_V4L2 && INPUT && VIDEO_IR && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_TVAUDIO which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_ZORAN_DC10 && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_SAA7110 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)
warning: (VIDEO_ZORAN_AVS6EYES && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && VIDEO_ZORAN_ZR36060 && EXPERIMENTAL && VIDEO_HELPER_CHIPS_AUTO) selects VIDEO_BT866 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && VIDEO_V4L2 && I2C)

#2 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

Quoted 5 lines · Mauro Carvalho Chehab

Em 09-10-2010 18:40, Michal Marek escreveu:

Quoted 4 lines

The following changes since commit cb655d0f3d57c23db51b981648e452988c0223f9:

Linux 2.6.36-rc7 (2010-10-06 13:39:52 -0700)

Quoted 8 lines
Quoted 5 lines

are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6.git rc-fixes

Arnaud Lacombe (1):
kconfig: delay symbol direct dependency initialization

This patch generated a regression with V4L build. After applying it, some Kconfig dependencies that used to work with V4L Kconfig broke.

You mean, the dependencies trigger a warning now, right? Also, you are replying to my pull request for 2.6.36-rc8, but that pull request also included "kconfig: Temporarily disable dependency warnings", so 2.6.36 final is NOT affected by this, just to clarify. 2.6.37-rc1 reverted this workaround and I hope we come to some solution now. BTW,
http://www.kerneltrap.com/mailarchive/linux-kernel/2010/10/7/4629122/thread
is how a very similar issue was fixed in the i2c Kconfig (commit 0a57274 in 2.6.37-rc1 now).

Michal

#3 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

Em 03-11-2010 18:47, Michal Marek escreveu:

Quoted 15 lines · Mauro Carvalho Chehab
Quoted 5 lines

Em 09-10-2010 18:40, Michal Marek escreveu:

Quoted 4 lines

The following changes since commit cb655d0f3d57c23db51b981648e452988c0223f9:

Linux 2.6.36-rc7 (2010-10-06 13:39:52 -0700)

Quoted 8 lines
Quoted 5 lines

are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6.git rc-fixes

Arnaud Lacombe (1):
kconfig: delay symbol direct dependency initialization

This patch generated a regression with V4L build. After applying it, some Kconfig dependencies that used to work with V4L Kconfig broke.

Quoted 8 lines

You mean, the dependencies trigger a warning now, right? Also, you are replying to my pull request for 2.6.36-rc8, but that pull request also included "kconfig: Temporarily disable dependency warnings", so 2.6.36 final is NOT affected by this, just to clarify. 2.6.37-rc1 reverted this workaround and I hope we come to some solution now. BTW,
http://www.kerneltrap.com/mailarchive/linux-kernel/2010/10/7/4629122/thread
is how a very similar issue was fixed in the i2c Kconfig (commit 0a57274 in 2.6.37-rc1 now).

Well, I'm seeing those warnings on 2.6.37-rc1, after the patch that re-enable the warnings. Just reverting the delay symbol direct dependency init changeset makes the warnings stop.

I didn't really try to run lots of tests to be sure that they actually break anything, or if they are just unwanted warnings, but, in any case, we need a fix before the end of .37 cycle.

A solution like what was done on i2c doesn't seem nice, as it will require lots of artificial changes at kconfig stuff. Maybe it would be better to just add some logic at Kconfig file to specify those kind of menus without producing warnings, of course assuming that actually won't break symbols dependency solve.

Thanks,
Mauro
anything.

#4 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

In reply to Mauro Carvalho Chehab

Hi,

Quoted 8 lines · Mauro Carvalho Chehab

Em 09-10-2010 18:40, Michal Marek escreveu:

Quoted 3 lines

Arnaud Lacombe (1):
      kconfig: delay symbol direct dependency initialization

This patch generated a regression with V4L build. After applying it, some Kconfig dependencies that used to work with V4L Kconfig broke.

of course, but they were all-likely buggy. If a compiler version N outputs a new legitimate warning because of a bug in the code, you do not switch back to the previous version because the warning wasn't there, you fix the code.

That said, please point me to a false positive, eventually with a minimal testcase, and I'll be happy to fix the issue.

- Arnaud

Quoted 5 lines

Basically, we have things there like:

config VIDEO_HELPER_CHIPS_AUTO
       bool "Autoselect pertinent encoders/decoders and other helper chips"

Quoted 9 lines

config VIDEO_IVTV
       select VIDEO_WM8739 if VIDEO_HELPER_CHIPS_AUTO

menu "Encoders/decoders and other helper chips"
       depends on !VIDEO_HELPER_CHIPS_AUTO

config VIDEO_WM8739
       tristate "Wolfson Microelectronics WM8739 stereo audio ADC"

this is broken.

#5 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

Em 03-11-2010 22:31, Arnaud Lacombe escreveu:

Quoted 12 lines

Hi,

Quoted 8 lines · Mauro Carvalho Chehab

Em 09-10-2010 18:40, Michal Marek escreveu:

Quoted 3 lines

Arnaud Lacombe (1):
kconfig: delay symbol direct dependency initialization

This patch generated a regression with V4L build. After applying it, some Kconfig dependencies that used to work with V4L Kconfig broke.

Quoted 7 lines

of course, but they were all-likely buggy. If a compiler version N outputs a new legitimate warning because of a bug in the code, you do not switch back to the previous version because the warning wasn't there, you fix the code.

That said, please point me to a false positive, eventually with a minimal testcase, and I'll be happy to fix the issue.

Arnaud,

In the case of V4L and DVB drivers, what happens is that the same USB (or PCI) bridge driver can be attached to lots of different chipsets that do analog/digital/audio decoding/encoding.

A normal user won't need to open his USB TV stick just to see TV on it. It just needs to select a bridge driver, and all possible options for encoders and decoders are auto-selected.

If you're an advanced user (or are developing an embedded hardware), you know exactly what are the components inside the board/stick. So, the Kconfig allows to disable the automatic auto-selection, doing manual selection.

The logic basically implements it, using Kconfig way, on a logic like:

	auto = ask_user_if_ancillary_drivers_should_be_auto_selected();
	driver_foo = ask_user_if_driver_foo_should_be_selected();
	if (driver_foo && auto) {
		select(bar1);
		select(bar2);
		select(bar3);
		select(bar4);
	}
...
	if (!auto) {
		open_menu()
		ask_user_if_bar1_should_be_selected();
		ask_user_if_bar2_should_be_selected();
		ask_user_if_bar3_should_be_selected();
		ask_user_if_bar4_should_be_selected();
...
		close_menu()
	}

Or, on Kconfig language:

Quoted 6 lines
Quoted 6 lines

config VIDEO_HELPER_CHIPS_AUTO
bool "Autoselect pertinent encoders/decoders and other helper chips"

config VIDEO_IVTV
select VIDEO_WM8739 if VIDEO_HELPER_CHIPS_AUTO

Quoted 6 lines
Quoted 6 lines

menu "Encoders/decoders and other helper chips"
depends on !VIDEO_HELPER_CHIPS_AUTO

config VIDEO_WM8739
tristate "Wolfson Microelectronics WM8739 stereo audio ADC"

I don't see anything wrong on such logic. It is valid in C, and it is also valid (and works properly) at Kconfig language.

So, the warning is a false positive.

If you want to see the real logic, just look at drivers/media/.../Kconfig stuff. You'll see it at almost all Kconfig files. There are hundreds of dependencies using this kind of logic. This is used by all tuners (21 Kconfig items, at drivers/media/common/Kconfig), by several I2C devices (40+ Kconfig items at drivers/media/video/Kconfig), and by almost all bridge drivers.

Mauro.

#6 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

Hi,

Quoted 9 lines · Mauro Carvalho Chehab
Quoted 9 lines
Quoted 9 lines

config VIDEO_HELPER_CHIPS_AUTO
       bool "Autoselect pertinent encoders/decoders and other helper chips"

config VIDEO_IVTV
       select VIDEO_WM8739 if VIDEO_HELPER_CHIPS_AUTO

menu "Encoders/decoders and other helper chips"
       depends on !VIDEO_HELPER_CHIPS_AUTO

Quoted 6 lines
Quoted 3 lines
Quoted 3 lines

config VIDEO_WM8739
       tristate "Wolfson Microelectronics WM8739 stereo audio ADC"

I don't see anything wrong on such logic. It is valid in C, and it is also valid (and works properly) at Kconfig language.

no, it is not a valid Kconfig language, or at least, you create an ambiguity in the dependency tree.

Quoted 2 lines

So, the warning is a false positive.

no it is not. By saying:

menu "Encoders/decoders and other helper chips"
depends on !VIDEO_HELPER_CHIPS_AUTO

you create on all the menu's children an implicit dependency, !VIDEO_HELPER_CHIPS_AUTO. This is something that has ever been there; from `Documentation/kbuild/kconfig-language.txt':

"
[...]
menu "Network device support"
depends on NET

config NETDEVICES

        ...

endmenu

All entries within the "menu" ... "endmenu" block become a submenu of "Network device support". All subentries inherit the dependencies from the menu entry, e.g. this means the dependency "NET" is added to the dependency list of the config option NETDEVICES.
"

Thus the warning as you also have:

config VIDEO_IVTV
select VIDEO_WM8739 if VIDEO_HELPER_CHIPS_AUTO

ie. VIDEO_IVTV selects VIDEO_WM8739 if VIDEO_HELPER_CHIPS_AUTO, but VIDEO_WM8739 has inherited the !VIDEO_HELPER_CHIPS_AUTO dependency.

Now, if you want my true feeling, this warning should be fatal.

- Arnaud

#7 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

In reply to Mauro Carvalho Chehab

Hi,

Quoted 48 lines · Mauro Carvalho Chehab

Em 03-11-2010 22:31, Arnaud Lacombe escreveu:

Quoted 12 lines

Hi,

Quoted 8 lines · Mauro Carvalho Chehab

Em 09-10-2010 18:40, Michal Marek escreveu:

Quoted 3 lines

Arnaud Lacombe (1):
      kconfig: delay symbol direct dependency initialization

This patch generated a regression with V4L build. After applying it, some Kconfig dependencies that used to work with V4L Kconfig broke.

Quoted 7 lines

of course, but they were all-likely buggy. If a compiler version N outputs a new legitimate warning because of a bug in the code, you do not switch back to the previous version because the warning wasn't there, you fix the code.

That said, please point me to a false positive, eventually with a minimal testcase, and I'll be happy to fix the issue.

Arnaud,

In the case of V4L and DVB drivers, what happens is that the same USB (or PCI) bridge driver can be attached to lots of different chipsets that do analog/digital/audio decoding/encoding.

A normal user won't need to open his USB TV stick just to see TV on it. It just needs to select a bridge driver, and all possible options for encoders and decoders are auto-selected.

If you're an advanced user (or are developing an embedded hardware), you know exactly what are the components inside the board/stick. So, the Kconfig allows to disable the automatic auto-selection, doing manual selection.

The logic basically implements it, using Kconfig way, on a logic like:

       auto = ask_user_if_ancillary_drivers_should_be_auto_selected(); driver_foo = ask_user_if_driver_foo_should_be_selected(); if (driver_foo && auto) {
               select(bar1);
               select(bar2);
               select(bar3);
               select(bar4);
       }
...
       if (!auto) {

Quoted 9 lines

               open_menu() ask_user_if_bar1_should_be_selected(); ask_user_if_bar2_should_be_selected(); ask_user_if_bar3_should_be_selected(); ask_user_if_bar4_should_be_selected();
...
               close_menu()
       }

no, you are hijacking Kconfig for something "illegal". Note that this last word is not mine, it is the word used in the language description:

Note:
select should be used with care. select will force a symbol to a value without visiting the dependencies. By abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set.
In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies. That will limit the usefulness but on the other hand avoid the illegal configurations all over.
kconfig should one day warn about such things.

I guess the last line will need to be dropped, as this day has come.

- Arnaud

#8 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

Em 04-11-2010 00:15, Arnaud Lacombe escreveu:

Quoted 61 lines

Hi,

Quoted 48 lines · Mauro Carvalho Chehab

Em 03-11-2010 22:31, Arnaud Lacombe escreveu:

Quoted 12 lines

Hi,

Quoted 8 lines · Mauro Carvalho Chehab

Em 09-10-2010 18:40, Michal Marek escreveu:

Quoted 3 lines

Arnaud Lacombe (1):
kconfig: delay symbol direct dependency initialization

This patch generated a regression with V4L build. After applying it, some Kconfig dependencies that used to work with V4L Kconfig broke.

Quoted 7 lines

of course, but they were all-likely buggy. If a compiler version N outputs a new legitimate warning because of a bug in the code, you do not switch back to the previous version because the warning wasn't there, you fix the code.

That said, please point me to a false positive, eventually with a minimal testcase, and I'll be happy to fix the issue.

Arnaud,

In the case of V4L and DVB drivers, what happens is that the same USB (or PCI) bridge driver can be attached to lots of different chipsets that do analog/digital/audio decoding/encoding.

A normal user won't need to open his USB TV stick just to see TV on it. It just needs to select a bridge driver, and all possible options for encoders and decoders are auto-selected.

If you're an advanced user (or are developing an embedded hardware), you know exactly what are the components inside the board/stick. So, the Kconfig allows to disable the automatic auto-selection, doing manual selection.

The logic basically implements it, using Kconfig way, on a logic like:

       auto = ask_user_if_ancillary_drivers_should_be_auto_selected();
       driver_foo = ask_user_if_driver_foo_should_be_selected();
       if (driver_foo && auto) {
               select(bar1);
               select(bar2);
               select(bar3);
               select(bar4);
       }
...
       if (!auto) {
Quoted 9 lines
               open_menu()
               ask_user_if_bar1_should_be_selected();
               ask_user_if_bar2_should_be_selected();
               ask_user_if_bar3_should_be_selected();
               ask_user_if_bar4_should_be_selected();
...
               close_menu()
       }
Quoted 1 line

no, you are hijacking Kconfig for something "illegal".

It is not a new code that added this logic. The code is there at least since 2006. It were added on this commit:

commit 1450e6bedc58c731617d99b4670070ed3ccc91b4

Author: Mauro Carvalho Chehab <[email protected]>
Date:   Wed Aug 23 10:08:41 2006 -0300
Quoted 15 lines

Note that this
last word is not mine, it is the word used in the language description:

Note:
select should be used with care. select will force a symbol to a value without visiting the dependencies. By abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set.
In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies. That will limit the usefulness but on the other hand avoid the illegal configurations all over.
kconfig should one day warn about such things.

Quoted 1 line

I guess the last line will need to be dropped, as this day has come.

All dependencies required by the selected symbols are satisfied. For example, the simplest case is likely cafe_ccic, as, currently, there's just one possible driver that can be attached dynamically at runtime to cafe_ccic. We have:

menu "Encoders/decoders and other helper chips"
depends on !VIDEO_HELPER_CHIPS_AUTO

...
config VIDEO_OV7670
tristate "OmniVision OV7670 sensor support" depends on I2C && VIDEO_V4L2
...
endmenu

config VIDEO_CAFE_CCIC

        tristate "Marvell 88ALP01 (Cafe) CMOS Camera Controller support"
        depends on PCI && I2C && VIDEO_V4L2
        select VIDEO_OV7670

The dependencies needed by ov7670 (I2C and VIDEO_V4L2) are also dependencies of cafe_ccic. So, it shouldn't have any problem for it to work (and it doesn't have, really. This is working as-is during the last 4 years).

It should be noticed that, even if we replace the menu dependencies by an If, won't solve. I tried the enclosed patch, to see if it would produce something that the new Kconfig behavior accepts. The same errors apply.

It is fine for me if you want/need to change the way Kconfig works, provided that it won't break (or produce those annoying warnings) the existing logic, and won't open the manual select menu, if the user selects the auto mode. Just send us a patch changing it to some other way of doing it.

Thanks,
Mauro

---
Test patch, replacing depends on by if's. It doesn't really work, as Kconfig seems to be internally converting if's into depends. So, no warning is removed.

drivers/media/video/Kconfig +2 -1
@@ -111,8 +111,8 @@ config VIDEO_IR_I2C
 # Encoder / Decoder module configuration
 #
 
+if !VIDEO_HELPER_CHIPS_AUTO
 menu "Encoders/decoders and other helper chips"
-	depends on !VIDEO_HELPER_CHIPS_AUTO
 
 comment "Audio decoders"
 
@@ -516,6 +516,7 @@ config VIDEO_UPD64083
 	  module will be called upd64083.
 
 endmenu # encoder / decoder chips
+endif
 
 config VIDEO_SH_VOU
 	tristate "SuperH VOU video output driver"
#9 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

Quoted 14 lines · On Thu, 04 Nov 2010 07:10:11 -0400 Mauro Carvalho Chehab wrote:

All dependencies required by the selected symbols are satisfied. For example, the simplest case is likely cafe_ccic, as, currently, there's just one possible driver that can be attached dynamically at runtime to cafe_ccic. We have:

menu "Encoders/decoders and other helper chips"
depends on !VIDEO_HELPER_CHIPS_AUTO

...
config VIDEO_OV7670
tristate "OmniVision OV7670 sensor support" depends on I2C && VIDEO_V4L2
...
endmenu

Quoted 8 lines

config VIDEO_CAFE_CCIC

        tristate "Marvell 88ALP01 (Cafe) CMOS Camera Controller support"
        depends on PCI && I2C && VIDEO_V4L2
        select VIDEO_OV7670

The dependencies needed by ov7670 (I2C and VIDEO_V4L2) are also dependencies of cafe_ccic. So, it shouldn't have any problem for it to work (and it doesn't have, really. This is working as-is during the last 4 years).

This warning line:

warning: (VIDEO_CAFE_CCIC && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && I2C && VIDEO_V4L2 || VIDEO_VIA_CAMERA && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && FB_VIA) selects VIDEO_OV7670 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && I2C && VIDEO_V4L2)

is not caused by CAFE_CCIC -- it's caused by VIDEO_VIA_CAMERA, because VIDEO_HELPER_CHIPS_AUTO=y, so !VIDEO_HELPER_CHIPS_AUTO is false, so VIDEO_OV7670 should not be available since it depends on !VIDEO_HELPER_CHIPS_AUTO.

Below is a simple patch that reduces the kconfig warning count in 2.6.37-rc1 from 240 down to only 88. :)

Quoted 3 lines

It should be noticed that, even if we replace the menu dependencies by an If, won't solve. I tried the enclosed patch, to see if it would produce something that the new Kconfig behavior accepts. The same errors apply.

That does not change any kconfig symbol logic/truth values.

Quoted 8 lines

It is fine for me if you want/need to change the way Kconfig works, provided that it won't break (or produce those annoying warnings) the existing logic, and won't open the manual select menu, if the user selects the auto mode. Just send us a patch changing it to some other way of doing it.

Thanks,
Mauro
---

From: Randy Dunlap <[email protected]>

Clean up some video driver dependencies.
Reduces the kconfig warning for unmet dependencies from 240 down to only 88 in 2.6.37-rc1.

This makes the drivers in the VIDEO_HELPER_CHIPS_AUTO menu not be dependent on that symbol. Just splash a comment there instead. config tools will display the comment when VIDEO_HELPER_CHIPS_AUTO is false.

---
 drivers/media/video/Kconfig |    4 ++++
 1 file changed, 4 insertions(+)
drivers/media/video/Kconfig +4 -0
@@ -112,6 +112,10 @@ config VIDEO_IR_I2C
 #
 
 menu "Encoders/decoders and other helper chips"
+
+comment "Only change these kconfig Helper/Auto settings if you are sure"
+	depends on !VIDEO_HELPER_CHIPS_AUTO
+comment "that you know what you are doing"
 	depends on !VIDEO_HELPER_CHIPS_AUTO
 
 comment "Audio decoders"
#10 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

Em 04-11-2010 13:19, Randy Dunlap escreveu:

Quoted 29 lines · On Thu, 04 Nov 2010 07:10:11 -0400 Mauro Carvalho Chehab wrote:
Quoted 15 lines

All dependencies required by the selected symbols are satisfied. For example, the simplest case is likely cafe_ccic, as, currently, there's just one possible driver that can be attached dynamically at runtime to cafe_ccic. We have:

menu "Encoders/decoders and other helper chips"
depends on !VIDEO_HELPER_CHIPS_AUTO

...
config VIDEO_OV7670
tristate "OmniVision OV7670 sensor support" depends on I2C && VIDEO_V4L2
...
endmenu

Quoted 8 lines

config VIDEO_CAFE_CCIC

        tristate "Marvell 88ALP01 (Cafe) CMOS Camera Controller support"
        depends on PCI && I2C && VIDEO_V4L2
        select VIDEO_OV7670

The dependencies needed by ov7670 (I2C and VIDEO_V4L2) are also dependencies of cafe_ccic. So, it shouldn't have any problem for it to work (and it doesn't have, really. This is working as-is during the last 4 years).

This warning line:

warning: (VIDEO_CAFE_CCIC && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && I2C && VIDEO_V4L2 || VIDEO_VIA_CAMERA && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && FB_VIA) selects VIDEO_OV7670 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && I2C && VIDEO_V4L2)

Quoted 7 lines

is not caused by CAFE_CCIC -- it's caused by VIDEO_VIA_CAMERA, because VIDEO_HELPER_CHIPS_AUTO=y, so !VIDEO_HELPER_CHIPS_AUTO is false, so VIDEO_OV7670 should not be available since it depends on !VIDEO_HELPER_CHIPS_AUTO.

Below is a simple patch that reduces the kconfig warning count in 2.6.37-rc1 from 240 down to only 88. :)

Yes, but this makes things worse: it will allow compiling drivers that Kernel will never use, as they won't work without an I2C adapter, and the I2C adapter is not compiled.

Worse than that: if you go into all V4L bridge drivers, that implements the I2C adapters and disable them, the I2C ancillary adapters will still be compiled (as they won't return to 'n'), but they will never ever be used...

So, no, this is not a solution.

What we need is to prompt the menu only if the user wants to do some manual configuration. Otherwise, just use the selects done by the drivers that implement the I2C bus adapters, and have some code to use those selected I2C devices.

Cheers,
Mauro.

#11 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

Hi,

Quoted 9 lines · Mauro Carvalho Chehab

[...]
Yes, but this makes things worse: it will allow compiling drivers that Kernel will never use, as they won't work without an I2C adapter, and the I2C adapter is not compiled.

Worse than that: if you go into all V4L bridge drivers, that implements the I2C adapters and disable them, the I2C ancillary adapters will still be compiled (as they won't return to 'n'), but they will never ever be used...

Quoted 6 lines

So, no, this is not a solution.

What we need is to prompt the menu only if the user wants to do some manual configuration. Otherwise, just use the selects done by the drivers that implement the I2C bus adapters, and have some code to use those selected I2C devices.

These is an easy solution: doing as `Documentation/kbuild/kconfig-language.txt' say it should be done:

config MODULES
bool "modules ?"
default y

config AUTO
bool "AUTO"

config IVTV
tristate "IVTV"
select WM42 if AUTO

menu "TV"
depends on !AUTO

config WM42_USER

        tristate "WM42"
        select WM42

endmenu

config WM42
tristate
default n

- Arnaud

#12 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

Em 04-11-2010 14:32, Arnaud Lacombe escreveu:

Quoted 40 lines

Hi,

Quoted 9 lines · Mauro Carvalho Chehab

[...]
Yes, but this makes things worse: it will allow compiling drivers that Kernel will never use, as they won't work without an I2C adapter, and the I2C adapter is not compiled.

Worse than that: if you go into all V4L bridge drivers, that implements the I2C adapters and disable them, the I2C ancillary adapters will still be compiled (as they won't return to 'n'), but they will never ever be used...

Quoted 6 lines

So, no, this is not a solution.

What we need is to prompt the menu only if the user wants to do some manual configuration. Otherwise, just use the selects done by the drivers that implement the I2C bus adapters, and have some code to use those selected I2C devices.

These is an easy solution: doing as `Documentation/kbuild/kconfig-language.txt' say it should be done:

config MODULES
bool "modules ?"
default y

config AUTO
bool "AUTO"

config IVTV
tristate "IVTV"
select WM42 if AUTO

menu "TV"
depends on !AUTO

config WM42_USER

        tristate "WM42"
        select WM42
Quoted 7 lines

endmenu

config WM42
tristate
default n

- Arnaud

This may work, but it means that every single I2C/frontend/tuner will require two entries for each driver. This means to create and manage around 100+ new symbols. The drivers/media Kconfig files are complex enough as-is, without adding those 100+ new artificial symbols. We should work to make things simple and improve users experience, and not to create artificial complexity that will make Kconfig almost unreadable.

I still think that the easiest way to solve this is to add some logic that will hide the menu if a condition doesn't happen. Something like:
menu FOO
prompt if BAR

or
menu FOO
show if BAR

Mauro.

#13 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

Quoted 55 lines · Mauro Carvalho Chehab

Em 04-11-2010 14:32, Arnaud Lacombe escreveu:

Quoted 40 lines

Hi,

Quoted 9 lines · Mauro Carvalho Chehab

[...]
Yes, but this makes things worse: it will allow compiling drivers that Kernel will never use, as they won't work without an I2C adapter, and the I2C adapter is not compiled.

Worse than that: if you go into all V4L bridge drivers, that implements the I2C adapters and disable them, the I2C ancillary adapters will still be compiled (as they won't return to 'n'), but they will never ever be used...

Quoted 6 lines

So, no, this is not a solution.

What we need is to prompt the menu only if the user wants to do some manual configuration. Otherwise, just use the selects done by the drivers that implement the I2C bus adapters, and have some code to use those selected I2C devices.

These is an easy solution: doing as `Documentation/kbuild/kconfig-language.txt' say it should be done:

config MODULES
bool "modules ?"
default y

config AUTO
bool "AUTO"

config IVTV
tristate "IVTV"
select WM42 if AUTO

menu "TV"
depends on !AUTO

config WM42_USER

        tristate "WM42"
        select WM42
Quoted 7 lines

endmenu

config WM42
tristate
default n

- Arnaud

This may work, but it means that every single I2C/frontend/tuner will require two entries for each driver. This means to create and manage around 100+ new symbols. The drivers/media Kconfig files are complex enough as-is, without adding those 100+ new artificial symbols. We should work to make things simple and improve users experience, and not to create artificial complexity that will make Kconfig almost unreadable.

Quoted 8 lines

I still think that the easiest way to solve this is to add some logic that will hide the menu if a condition doesn't happen. Something like:
menu FOO
prompt if BAR

or
menu FOO
show if BAR

I totally second Mauro's concerns and proposal. My own proposal was along the lines of:

menu FOO
hide if BAR

but obviously the idea is the same, so it doesn't matter which of the 3 proposals gets implemented. The basic idea is to have a weak form of "depends" for menus, which hides the menu from the user but preserves all the symbols defines under that menu.

Michal, is the above something you would be able to implement in Kconfig?

Thanks,

Signature · 1 line
Jean Delvare
#14 lore raw

[PATCH 0/5] Re: REGRESSION: Re: [GIT] kconfig rc fixes

In reply to Mauro Carvalho Chehab

Hi,

This should do the job.

A.

Arnaud Lacombe (5):
kconfig: add an option to determine a menu's visibility
kconfig: regen parser
Revert "i2c: Fix Kconfig dependencies"
media/video: convert Kconfig to use the menu's visible' keyword i2c/algos: convert Kconfig to use the menu's visible' keyword

 drivers/i2c/Kconfig                  |    3 +-
 drivers/i2c/algos/Kconfig            |   14 +-
 drivers/media/video/Kconfig          |    2 +-
 scripts/kconfig/expr.h               |    1 +
 scripts/kconfig/lkc.h                |    1 +
 scripts/kconfig/menu.c               |   11 +
 scripts/kconfig/zconf.gperf          |    1 +
 scripts/kconfig/zconf.hash.c_shipped |  122 ++++----
 scripts/kconfig/zconf.tab.c_shipped  |  570 +++++++++++++++++----------------
 scripts/kconfig/zconf.y              |   21 +-
 10 files changed, 393 insertions(+), 353 deletions(-)
Signature · 1 line
1.7.2.30.gc37d7.dirty
#15 lore raw

Re: [PATCH 0/5] Re: REGRESSION: Re: [GIT] kconfig rc fixes

Em 06-11-2010 17:30, Arnaud Lacombe escreveu:

Quoted 4 lines

Hi,

This should do the job.

Thank you, Arnaud! Good job!

I'm currently at the airport preparing to take an international flight to return back home from LPC. I'll test your patch series tomorrow or more likely during the beginning of the next week. There are probably few more drivers/media Kconfig files that need to use "visible if" option to remove all warnings, but it will be a trivial fix.

Thanks!
Mauro

Quoted 21 lines

A.

Arnaud Lacombe (5):
kconfig: add an option to determine a menu's visibility
kconfig: regen parser
Revert "i2c: Fix Kconfig dependencies"
media/video: convert Kconfig to use the menu's visible' keyword i2c/algos: convert Kconfig to use the menu's visible' keyword

 drivers/i2c/Kconfig                  |    3 +-
 drivers/i2c/algos/Kconfig            |   14 +-
 drivers/media/video/Kconfig          |    2 +-
 scripts/kconfig/expr.h               |    1 +
 scripts/kconfig/lkc.h                |    1 +
 scripts/kconfig/menu.c               |   11 +
 scripts/kconfig/zconf.gperf          |    1 +
 scripts/kconfig/zconf.hash.c_shipped |  122 ++++----
 scripts/kconfig/zconf.tab.c_shipped  |  570 +++++++++++++++++----------------
 scripts/kconfig/zconf.y              |   21 +-
 10 files changed, 393 insertions(+), 353 deletions(-)
#16 lore raw

Re: [PATCH 0/5] Re: REGRESSION: Re: [GIT] kconfig rc fixes

In reply to Arnaud Lacombe

Hi Arnaud,

Em 06-11-2010 19:30, Arnaud Lacombe escreveu:

Quoted 13 lines

Hi,

This should do the job.

A.

Arnaud Lacombe (5):
kconfig: add an option to determine a menu's visibility
kconfig: regen parser
Revert "i2c: Fix Kconfig dependencies"
media/video: convert Kconfig to use the menu's visible' keyword i2c/algos: convert Kconfig to use the menu's visible' keyword

Quoted 11 lines
 drivers/i2c/Kconfig                  |    3 +-
 drivers/i2c/algos/Kconfig            |   14 +-
 drivers/media/video/Kconfig          |    2 +-
 scripts/kconfig/expr.h               |    1 +
 scripts/kconfig/lkc.h                |    1 +
 scripts/kconfig/menu.c               |   11 +
 scripts/kconfig/zconf.gperf          |    1 +
 scripts/kconfig/zconf.hash.c_shipped |  122 ++++----
 scripts/kconfig/zconf.tab.c_shipped  |  570 +++++++++++++++++----------------
 scripts/kconfig/zconf.y              |   21 +-
 10 files changed, 393 insertions(+), 353 deletions(-)

Patches look OK to my eyes. One more patch is needed, in order to fix build warnings when customise is enabled for tuners and/or for DVB frontends. I'm enclosing the fix.

For this patch series:

Michal,

Would you apply those fixes to your tree, or do you prefer if I send them via my tree?

Thanks,
Mauro

---

commit f53404d53c026548e03444f7ed33e8027716425d

Author: Mauro Carvalho Chehab <[email protected]>
Date:   Tue Nov 9 15:29:05 2010 -0200

[media] Fix Kconfig errors due to two visible menus

Use the new visible Kconfig keyword to avoid producing error for two menus that are visible only if Tuner/frontend customise options are enabled.

drivers/media/common/tuners/Kconfig +4 -4
index 2385e6c..78b0895 100644
@@ -31,7 +31,7 @@ config MEDIA_TUNER
 	select MEDIA_TUNER_TDA9887 if !MEDIA_TUNER_CUSTOMISE
 	select MEDIA_TUNER_MC44S803 if !MEDIA_TUNER_CUSTOMISE
 
-menuconfig MEDIA_TUNER_CUSTOMISE
+config MEDIA_TUNER_CUSTOMISE
 	bool "Customize analog and hybrid tuner modules to build"
 	depends on MEDIA_TUNER
 	default y if EMBEDDED
@@ -44,7 +44,8 @@ menuconfig MEDIA_TUNER_CUSTOMISE
 
 	  If unsure say N.
 
-if MEDIA_TUNER_CUSTOMISE
+menu "Customize TV tuners"
+	visible if MEDIA_TUNER_CUSTOMISE
 
 config MEDIA_TUNER_SIMPLE
 	tristate "Simple tuner support"
@@ -185,5 +186,4 @@ config MEDIA_TUNER_TDA18218
 	default m if MEDIA_TUNER_CUSTOMISE
 	help
 	  NXP TDA18218 silicon tuner driver.
-
-endif # MEDIA_TUNER_CUSTOMISE
+endmenu
drivers/media/dvb/frontends/Kconfig +1 -4
index e9062b0..96b2701 100644
@@ -12,9 +12,8 @@ config DVB_FE_CUSTOMISE
 
 	  If unsure say N.
 
-if DVB_FE_CUSTOMISE
-
 menu "Customise DVB Frontends"
+	visible if DVB_FE_CUSTOMISE
 
 comment "Multistandard (satellite) frontends"
 	depends on DVB_CORE
@@ -619,5 +618,3 @@ config DVB_DUMMY_FE
 	tristate "Dummy frontend driver"
 	default n
 endmenu
-
-endif
#17 lore raw

PATCH 1/5 kconfig: add an option to determine a menu's visibility

In reply to Mauro Carvalho Chehab

This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

---
 scripts/kconfig/expr.h      |    1 +
 scripts/kconfig/lkc.h       |    1 +
 scripts/kconfig/menu.c      |   11 +++++++++++
 scripts/kconfig/zconf.gperf |    1 +
 scripts/kconfig/zconf.y     |   21 ++++++++++++++++++---
 5 files changed, 32 insertions(+), 3 deletions(-)
scripts/kconfig/expr.h +1 -0
index 184eb6a..e57826c 100644
@@ -164,6 +164,7 @@ struct menu {
 	struct menu *list;
 	struct symbol *sym;
 	struct property *prompt;
+	struct expr *visibility;
 	struct expr *dep;
 	unsigned int flags;
 	char *help;
scripts/kconfig/lkc.h +1 -0
index 753cdbd..3f7240d 100644
@@ -107,6 +107,7 @@ void menu_end_menu(void);
 void menu_add_entry(struct symbol *sym);
 void menu_end_entry(void);
 void menu_add_dep(struct expr *dep);
+void menu_add_visibility(struct expr *dep);
 struct property *menu_add_prop(enum prop_type type, char *prompt, struct expr *expr, struct expr *dep);
 struct property *menu_add_prompt(enum prop_type type, char *prompt, struct expr *dep);
 void menu_add_expr(enum prop_type type, struct expr *expr, struct expr *dep);
scripts/kconfig/menu.c +11 -0
index 7e83aef..b9d9aa1 100644
@@ -152,6 +152,12 @@ struct property *menu_add_prompt(enum prop_type type, char *prompt, struct expr
 	return menu_add_prop(type, prompt, NULL, dep);
 }
 
+void menu_add_visibility(struct expr *expr)
+{
+	current_entry->visibility = expr_alloc_and(current_entry->visibility,
+	    expr);
+}
+
 void menu_add_expr(enum prop_type type, struct expr *expr, struct expr *dep)
 {
 	menu_add_prop(type, NULL, expr, dep);
@@ -410,6 +416,11 @@ bool menu_is_visible(struct menu *menu)
 	if (!menu->prompt)
 		return false;
 
+	if (menu->visibility) {
+		if (expr_calc_value(menu->visibility) == no)
+			return no;
+	}
+
 	sym = menu->sym;
 	if (sym) {
 		sym_calc_value(sym);
scripts/kconfig/zconf.gperf +1 -0
index d8bc742..c9e690e 100644
@@ -38,6 +38,7 @@ hex,		T_TYPE,		TF_COMMAND, S_HEX
 string,		T_TYPE,		TF_COMMAND, S_STRING
 select,		T_SELECT,	TF_COMMAND
 range,		T_RANGE,	TF_COMMAND
+visible,	T_VISIBLE,	TF_COMMAND
 option,		T_OPTION,	TF_COMMAND
 on,		T_ON,		TF_PARAM
 modules,	T_OPT_MODULES,	TF_OPTION
scripts/kconfig/zconf.y +18 -3
index 2abd3c7..49fb4ab 100644
@@ -36,7 +36,7 @@ static struct menu *current_menu, *current_entry;
 #define YYERROR_VERBOSE
 #endif
 %}
-%expect 28
+%expect 30
 
 %union
 {
@@ -68,6 +68,7 @@ static struct menu *current_menu, *current_entry;
 %token <id>T_DEFAULT
 %token <id>T_SELECT
 %token <id>T_RANGE
+%token <id>T_VISIBLE
 %token <id>T_OPTION
 %token <id>T_ON
 %token <string> T_WORD
@@ -123,7 +124,7 @@ stmt_list:
 ;
 
 option_name:
-	T_DEPENDS | T_PROMPT | T_TYPE | T_SELECT | T_OPTIONAL | T_RANGE | T_DEFAULT
+	T_DEPENDS | T_PROMPT | T_TYPE | T_SELECT | T_OPTIONAL | T_RANGE | T_DEFAULT | T_VISIBLE
 ;
 
 common_stmt:
@@ -359,7 +360,7 @@ menu: T_MENU prompt T_EOL
 	printd(DEBUG_PARSE, "%s:%d:menu\n", zconf_curname(), zconf_lineno());
 };
 
-menu_entry: menu depends_list
+menu_entry: menu visibility_list depends_list
 {
 	$$ = menu_add_menu();
 };
@@ -430,6 +431,19 @@ depends: T_DEPENDS T_ON expr T_EOL
 	printd(DEBUG_PARSE, "%s:%d:depends on\n", zconf_curname(), zconf_lineno());
 };
 
+/* visibility option */
+
+visibility_list:
+	  /* empty */
+	| visibility_list visible
+	| visibility_list T_EOL
+;
+
+visible: T_VISIBLE if_expr
+{
+	menu_add_visibility($2);
+};
+
 /* prompt statement */
 
 prompt_stmt_opt:
@@ -526,6 +540,7 @@ static const char *zconf_tokenname(int token)
 	case T_IF:		return "if";
 	case T_ENDIF:		return "endif";
 	case T_DEPENDS:		return "depends";
+	case T_VISIBLE:		return "visible";
 	}
 	return "<token>";
 }
Signature · 1 line
1.7.2.30.gc37d7.dirty
#18 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

Hi all

Quoted 12 lines · Arnaud Lacombe

This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

---

 scripts/kconfig/expr.h      |    1 +
 scripts/kconfig/lkc.h       |    1 +
 scripts/kconfig/menu.c      |   11 +++++++++++
 scripts/kconfig/zconf.gperf |    1 +
 scripts/kconfig/zconf.y     |   21 ++++++++++++++++++---
 5 files changed, 32 insertions(+), 3 deletions(-)

Michal, I don't think you commented on this ? Mauro, has it been worked around differently ?

Thanks,
- Arnaud

Acked-by Tested-by
#19 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

Em 15-11-2010 14:57, Arnaud Lacombe escreveu:

Quoted 15 lines

Hi all

Quoted 12 lines · Arnaud Lacombe

This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

---
 scripts/kconfig/expr.h      |    1 +
 scripts/kconfig/lkc.h       |    1 +
 scripts/kconfig/menu.c      |   11 +++++++++++
 scripts/kconfig/zconf.gperf |    1 +
 scripts/kconfig/zconf.y     |   21 ++++++++++++++++++---
 5 files changed, 32 insertions(+), 3 deletions(-)
Quoted 2 lines

Michal, I don't think you commented on this ? Mauro, has it been worked around differently ?

Those patches worked fine, and solved all problems we had (I just had to touch on two other menus that are used, as I answered upstream).

I prefer if Michal could forward those patches upstream, so, there's my ack:

Cheers,
Mauro

#20 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

Hi,

Quoted 19 lines · Mauro Carvalho Chehab

Em 15-11-2010 14:57, Arnaud Lacombe escreveu:

Quoted 15 lines

Hi all

Quoted 12 lines · Arnaud Lacombe

This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

---

 scripts/kconfig/expr.h      |    1 +
 scripts/kconfig/lkc.h       |    1 +
 scripts/kconfig/menu.c      |   11 +++++++++++
 scripts/kconfig/zconf.gperf |    1 +
 scripts/kconfig/zconf.y     |   21 ++++++++++++++++++---
 5 files changed, 32 insertions(+), 3 deletions(-)
Quoted 2 lines

Michal, I don't think you commented on this ? Mauro, has it been worked around differently ?

Quoted 8 lines

Those patches worked fine, and solved all problems we had (I just had to touch on two other menus that are used, as I answered upstream).

I prefer if Michal could forward those patches upstream, so, there's my ack:

It would seem Michal is not around lately, his only passage on linux-kbuild@ is nearly a week old.

Sam, by any chance, could you comment on these patches so that we could keep moving forward ?

Thanks,
- Arnaud

ps: yes, I know, I did not upgrade the documentation.

#21 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

Quoted 28 lines · Arnaud Lacombe

Hi,

Quoted 24 lines · Mauro Carvalho Chehab

Em 15-11-2010 14:57, Arnaud Lacombe escreveu:

Quoted 15 lines

Hi all

Quoted 12 lines · Arnaud Lacombe

This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

---

 scripts/kconfig/expr.h      |    1 +
 scripts/kconfig/lkc.h       |    1 +
 scripts/kconfig/menu.c      |   11 +++++++++++
 scripts/kconfig/zconf.gperf |    1 +
 scripts/kconfig/zconf.y     |   21 ++++++++++++++++++---
 5 files changed, 32 insertions(+), 3 deletions(-)
Quoted 2 lines

Michal, I don't think you commented on this ? Mauro, has it been worked around differently ?

Those patches worked fine, and solved all problems we had (I just had to touch on two other menus that are used, as I answered upstream).

I prefer if Michal could forward those patches upstream, so, there's my ack:

Quoted 8 lines
Quoted 3 lines

It would seem Michal is not around lately, his only passage on linux-kbuild@ is nearly a week old.

Sam, by any chance, could you comment on these patches so that we could keep moving forward ?

I will try to take a look in the weekend - daytime job keeps me busy as usual.

Quoted 5 lines

Thanks,
- Arnaud

ps: yes, I know, I did not upgrade the documentation.

And I will toast you for that when I look at the patches :-)

Sam

#22 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

In reply to Arnaud Lacombe

Hi folks,

Quoted 12 lines · Arnaud Lacombe

This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

---

 scripts/kconfig/expr.h      |    1 +
 scripts/kconfig/lkc.h       |    1 +
 scripts/kconfig/menu.c      |   11 +++++++++++
 scripts/kconfig/zconf.gperf |    1 +
 scripts/kconfig/zconf.y     |   21 ++++++++++++++++++---
 5 files changed, 32 insertions(+), 3 deletions(-)

As there seem to be no interested from Michal to either, ACK, NACK, or even comment this series, please let me withdraw these patches. If this mail is not enough to void the patch, I hope to still be able to withdraw my Signed-off-by from this particular series, and thus no longer be able to certify the origin of the patches to prevent their merge.

I guess lot of people will keep being pissed by these warnings.

I hope another solution will be found or someone will have fun wasting time re-writting the patch.

Thanks,
- Arnaud

ps: as we all live a world of consensus, I can still be convinced to change my mind if interest arise.

Quoted 136 lines
scripts/kconfig/expr.h +1 -0
index 184eb6a..e57826c 100644
@@ -164,6 +164,7 @@ struct menu {
        struct menu *list;
        struct symbol *sym;
        struct property *prompt;
+       struct expr *visibility;
        struct expr *dep;
        unsigned int flags;
        char *help;
scripts/kconfig/lkc.h +1 -0
index 753cdbd..3f7240d 100644
@@ -107,6 +107,7 @@ void menu_end_menu(void);
  void menu_add_entry(struct symbol *sym);
  void menu_end_entry(void);
  void menu_add_dep(struct expr *dep);
+void menu_add_visibility(struct expr *dep);
  struct property *menu_add_prop(enum prop_type type, char *prompt, struct expr *expr, struct expr *dep);
  struct property *menu_add_prompt(enum prop_type type, char *prompt, struct expr *dep);
  void menu_add_expr(enum prop_type type, struct expr *expr, struct expr *dep);
scripts/kconfig/menu.c +11 -0
index 7e83aef..b9d9aa1 100644
@@ -152,6 +152,12 @@ struct property *menu_add_prompt(enum prop_type type, char *prompt, struct expr
        return menu_add_prop(type, prompt, NULL, dep);
  }
 
+void menu_add_visibility(struct expr *expr)
+{
+       current_entry->visibility = expr_alloc_and(current_entry->visibility,
+           expr);
+}
+
  void menu_add_expr(enum prop_type type, struct expr *expr, struct expr *dep)
  {
        menu_add_prop(type, NULL, expr, dep);
@@ -410,6 +416,11 @@ bool menu_is_visible(struct menu *menu)
        if (!menu->prompt)
                return false;
 
+       if (menu->visibility) {
+               if (expr_calc_value(menu->visibility) == no)
+                       return no;
+       }
+
        sym = menu->sym;
        if (sym) {
                sym_calc_value(sym);
scripts/kconfig/zconf.gperf +0 -0
index d8bc742..c9e690e 100644
@@ -38,6 +38,7 @@ hex,          T_TYPE,         TF_COMMAND, S_HEX

 string,                T_TYPE,         TF_COMMAND, S_STRING select,                T_SELECT,       TF_COMMAND range,         T_RANGE,        TF_COMMAND +visible,       T_VISIBLE,      TF_COMMAND
 option,                T_OPTION,       TF_COMMAND on,            T_ON,           TF_PARAM
 modules,       T_OPT_MODULES,  TF_OPTION

scripts/kconfig/zconf.y +1 -1
index 2abd3c7..49fb4ab 100644
@@ -36,7 +36,7 @@ static struct menu *current_menu, *current_entry;
  #define YYERROR_VERBOSE
  #endif
  %}
-%expect 28
+%expect 30
 

 %union
 {

scripts/kconfig/zconf.y +0 -0
@@ -68,6 +68,7 @@ static struct menu *current_menu, *current_entry;

 %token <id>T_DEFAULT
 %token <id>T_SELECT
 %token <id>T_RANGE
+%token <id>T_VISIBLE
 %token <id>T_OPTION
 %token <id>T_ON
 %token <string> T_WORD

scripts/kconfig/zconf.y +0 -0
@@ -123,7 +124,7 @@ stmt_list:
  ;
 

 option_name:

-       T_DEPENDS | T_PROMPT | T_TYPE | T_SELECT | T_OPTIONAL | T_RANGE | T_DEFAULT
+       T_DEPENDS | T_PROMPT | T_TYPE | T_SELECT | T_OPTIONAL | T_RANGE | T_DEFAULT | T_VISIBLE

 ;

 common_stmt:

scripts/kconfig/zconf.y +14 -1
@@ -359,7 +360,7 @@ menu: T_MENU prompt T_EOL
        printd(DEBUG_PARSE, "%s:%d:menu\n", zconf_curname(), zconf_lineno());
  };
 
-menu_entry: menu depends_list
+menu_entry: menu visibility_list depends_list
  {
        $$ = menu_add_menu();
  };
@@ -430,6 +431,19 @@ depends: T_DEPENDS T_ON expr T_EOL
        printd(DEBUG_PARSE, "%s:%d:depends on\n", zconf_curname(), zconf_lineno());
  };
 
+/* visibility option */
+
+visibility_list:
+         /* empty */
+       | visibility_list visible
+       | visibility_list T_EOL
+;
+
+visible: T_VISIBLE if_expr
+{
+       menu_add_visibility($2);
+};
+
  /* prompt statement */
 

 prompt_stmt_opt:

scripts/kconfig/zconf.y +1 -1
@@ -526,6 +540,7 @@ static const char *zconf_tokenname(int token)
        case T_IF:              return "if";
        case T_ENDIF:           return "endif";
        case T_DEPENDS:         return "depends";
+       case T_VISIBLE:         return "visible";
        }
        return "<token>";
  }
--

1.7.2.30.gc37d7.dirty

#23 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

Quoted 15 lines · Arnaud Lacombe

Hi folks,

Quoted 12 lines · Arnaud Lacombe

This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

---

 scripts/kconfig/expr.h      |    1 +
 scripts/kconfig/lkc.h       |    1 +
 scripts/kconfig/menu.c      |   11 +++++++++++
 scripts/kconfig/zconf.gperf |    1 +
 scripts/kconfig/zconf.y     |   21 ++++++++++++++++++---
 5 files changed, 32 insertions(+), 3 deletions(-)
Quoted 1 line

As there seem to be no interested from Michal to either, ACK, NACK, or

Hi Arnaud.
I have these sitting in my TODO pile.
But I have other things that I need to do first and I expect these other things to take a couple of weeks.
[Not Linux related - just busy at my day-job/night-job]

Sam

#24 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

In reply to Arnaud Lacombe
Quoted 15 lines · Arnaud Lacombe

Hi folks,

Quoted 12 lines · Arnaud Lacombe

This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

---
 scripts/kconfig/expr.h      |    1 +
 scripts/kconfig/lkc.h       |    1 +
 scripts/kconfig/menu.c      |   11 +++++++++++
 scripts/kconfig/zconf.gperf |    1 +
 scripts/kconfig/zconf.y     |   21 ++++++++++++++++++---
 5 files changed, 32 insertions(+), 3 deletions(-)
Quoted 6 lines

As there seem to be no interested from Michal to either, ACK, NACK, or even comment this series, please let me withdraw these patches. If this mail is not enough to void the patch, I hope to still be able to withdraw my Signed-off-by from this particular series, and thus no longer be able to certify the origin of the patches to prevent their merge.

Hi Arnaud,

I'm sorry, I was sick for longer time and am now going through the patches that accumulated during that time. I understand your frustration, but the fact that I commented / applied some other patches yesterday and not this one does not mean that I'm ignoring it. Please accept my apologies, I'm looking at your patch right now...

Michal

#25 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

Quoted 23 lines · Michal Marek
Quoted 15 lines · Arnaud Lacombe

Hi folks,

Quoted 12 lines · Arnaud Lacombe

This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

---
 scripts/kconfig/expr.h      |    1 +
 scripts/kconfig/lkc.h       |    1 +
 scripts/kconfig/menu.c      |   11 +++++++++++
 scripts/kconfig/zconf.gperf |    1 +
 scripts/kconfig/zconf.y     |   21 ++++++++++++++++++---
 5 files changed, 32 insertions(+), 3 deletions(-)
Quoted 6 lines

As there seem to be no interested from Michal to either, ACK, NACK, or even comment this series, please let me withdraw these patches. If this mail is not enough to void the patch, I hope to still be able to withdraw my Signed-off-by from this particular series, and thus no longer be able to certify the origin of the patches to prevent their merge.

Quoted 7 lines

Hi Arnaud,

I'm sorry, I was sick for longer time and am now going through the patches that accumulated during that time. I understand your frustration, but the fact that I commented / applied some other patches yesterday and not this one does not mean that I'm ignoring it. Please accept my apologies, I'm looking at your patch right now...

So the patches look OK to me, I added your patches to kbuild-2.6.git#menu-visibility and merged the branch to for-next. The new syntax should be documented in Documentation/kbuild/kconfig-language.txt, below is a first attempt at it. If the patches work fine in linux-next _and_ you give me permission to push them to Linus, I'll move them to rc-fixes and send a pull request.

Michal

Subject: [PATCH] kconfig: Document the new "visible if" syntax

Documentation/kbuild/kconfig-language.txt +9 -1
index 2fe93ca..2522cca 100644
@@ -114,6 +114,13 @@ applicable everywhere (see syntax).
 	the illegal configurations all over.
 	kconfig should one day warn about such things.
 
+- limiting menu display: "visible if" <expr>
+  This attribute is only applicable to menu blocks, if the condition is
+  false, the menu block is not displayed to the user (the symbols
+  contained there can still be selected by other symbols, though). It is
+  similar to a conditional "prompt" attribude for individual menu
+  entries.
+
 - numerical ranges: "range" <symbol> <symbol> ["if" <expr>]
   This allows to limit the range of possible input values for int
   and hex symbols. The user can only input a value which is larger than
@@ -300,7 +307,8 @@ menu:
 	"endmenu"
 
 This defines a menu block, see "Menu structure" above for more
-information. The only possible options are dependencies.
+information. The only possible options are dependencies and "visible"
+attributes.
 
 if:
 
#26 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

Quoted 52 lines · On Fri, 26 Nov 2010 17:15:11 +0100 Michal Marek wrote:
Quoted 23 lines · Michal Marek
Quoted 15 lines · Arnaud Lacombe

Hi folks,

Quoted 12 lines · Arnaud Lacombe

This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

---
 scripts/kconfig/expr.h      |    1 +
 scripts/kconfig/lkc.h       |    1 +
 scripts/kconfig/menu.c      |   11 +++++++++++
 scripts/kconfig/zconf.gperf |    1 +
 scripts/kconfig/zconf.y     |   21 ++++++++++++++++++---
 5 files changed, 32 insertions(+), 3 deletions(-)
Quoted 6 lines

As there seem to be no interested from Michal to either, ACK, NACK, or even comment this series, please let me withdraw these patches. If this mail is not enough to void the patch, I hope to still be able to withdraw my Signed-off-by from this particular series, and thus no longer be able to certify the origin of the patches to prevent their merge.

Quoted 7 lines

Hi Arnaud,

I'm sorry, I was sick for longer time and am now going through the patches that accumulated during that time. I understand your frustration, but the fact that I commented / applied some other patches yesterday and not this one does not mean that I'm ignoring it. Please accept my apologies, I'm looking at your patch right now...

So the patches look OK to me, I added your patches to kbuild-2.6.git#menu-visibility and merged the branch to for-next. The new syntax should be documented in Documentation/kbuild/kconfig-language.txt, below is a first attempt at it. If the patches work fine in linux-next _and_ you give me permission to push them to Linus, I'll move them to rc-fixes and send a pull request.

Michal

Subject: [PATCH] kconfig: Document the new "visible if" syntax

Documentation/kbuild/kconfig-language.txt +0 -0
index 2fe93ca..2522cca 100644

Documentation/kbuild/kconfig-language.txt applicable everywhere (see syntax). · line 123

Quoted 10 lines
Documentation/kbuild/kconfig-language.txt +7 -0
@@ -114,6 +114,13 @@ applicable everywhere (see syntax).
 	the illegal configurations all over.
 	kconfig should one day warn about such things.
 
+- limiting menu display: "visible if" <expr>
+  This attribute is only applicable to menu blocks, if the condition is
+  false, the menu block is not displayed to the user (the symbols
+  contained there can still be selected by other symbols, though). It is
+  similar to a conditional "prompt" attribude for individual menu
+  entries.
+

Default value of "visible" is true ??

Quoted 4 lines
Documentation/kbuild/kconfig-language.txt +0 -0
 - numerical ranges: "range" <symbol> <symbol> ["if" <expr>]
   This allows to limit the range of possible input values for int
   and hex symbols. The user can only input a value which is larger than

Documentation/kbuild/kconfig-language.txt menu:

Quoted 10 lines
Documentation/kbuild/kconfig-language.txt +2 -2
@@ -300,7 +307,8 @@ menu:
 	"endmenu"
 
 This defines a menu block, see "Menu structure" above for more
-information. The only possible options are dependencies.
+information. The only possible options are dependencies and "visible"
+attributes.
 
 if:
 
--

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#27 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

Hi,

Quoted 2 lines · Randy Dunlap

Default value of "visible" is true ??

yes, but implicitly... I think I should made this explicit.

- Arnaud

#28 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

In reply to Randy Dunlap
Quoted 42 lines · On Fri, 26 Nov 2010 08:17:36 -0800 Randy Dunlap wrote:
Quoted 40 lines · On Fri, 26 Nov 2010 17:15:11 +0100 Michal Marek wrote:
Quoted 23 lines · Michal Marek
Quoted 15 lines · Arnaud Lacombe

Hi folks,

Quoted 12 lines · Arnaud Lacombe

This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

---
 scripts/kconfig/expr.h      |    1 +
 scripts/kconfig/lkc.h       |    1 +
 scripts/kconfig/menu.c      |   11 +++++++++++
 scripts/kconfig/zconf.gperf |    1 +
 scripts/kconfig/zconf.y     |   21 ++++++++++++++++++---
 5 files changed, 32 insertions(+), 3 deletions(-)
Quoted 6 lines

As there seem to be no interested from Michal to either, ACK, NACK, or even comment this series, please let me withdraw these patches. If this mail is not enough to void the patch, I hope to still be able to withdraw my Signed-off-by from this particular series, and thus no longer be able to certify the origin of the patches to prevent their merge.

Quoted 7 lines

Hi Arnaud,

I'm sorry, I was sick for longer time and am now going through the patches that accumulated during that time. I understand your frustration, but the fact that I commented / applied some other patches yesterday and not this one does not mean that I'm ignoring it. Please accept my apologies, I'm looking at your patch right now...

So the patches look OK to me, I added your patches to kbuild-2.6.git#menu-visibility and merged the branch to for-next. The new syntax should be documented in Documentation/kbuild/kconfig-language.txt, below is a first attempt at it. If the patches work fine in linux-next _and_ you give me permission to push them to Linus, I'll move them to rc-fixes and send a pull request.

Quoted 4 lines
Quoted 4 lines

Michal

Subject: [PATCH] kconfig: Document the new "visible if" syntax

Hi,

Can we get this kconfig-language.txt patch added to the kernel source tree, please?

Quoted 26 lines
Quoted 7 lines
Documentation/kbuild/kconfig-language.txt +0 -0
index 2fe93ca..2522cca 100644

Documentation/kbuild/kconfig-language.txt applicable everywhere (see syntax). · line 123

Quoted 10 lines
Documentation/kbuild/kconfig-language.txt +7 -0
@@ -114,6 +114,13 @@ applicable everywhere (see syntax).
 	the illegal configurations all over.
 	kconfig should one day warn about such things.
 
+- limiting menu display: "visible if" <expr>
+  This attribute is only applicable to menu blocks, if the condition is
+  false, the menu block is not displayed to the user (the symbols
+  contained there can still be selected by other symbols, though). It is
+  similar to a conditional "prompt" attribude for individual menu
+  entries.
+

Default value of "visible" is true ??

Quoted 6 lines
Documentation/kbuild/kconfig-language.txt +0 -0
 - numerical ranges: "range" <symbol> <symbol> ["if" <expr>]
   This allows to limit the range of possible input values for int
   and hex symbols. The user can only input a value which is larger than
@@ -300,7 +307,8 @@ menu:
 	"endmenu"
 
Quoted 8 lines

Documentation/kbuild/kconfig-language.txt menu:

Quoted 8 lines
Documentation/kbuild/kconfig-language.txt +2 -2
 This defines a menu block, see "Menu structure" above for more
-information. The only possible options are dependencies.
+information. The only possible options are dependencies and "visible"
+attributes.
 
 if:
 
--

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#29 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

Quoted 8 lines · Randy Dunlap
Quoted 2 lines · On Fri, 26 Nov 2010 08:17:36 -0800 Randy Dunlap wrote:
Quoted 1 line · On Fri, 26 Nov 2010 17:15:11 +0100 Michal Marek wrote:

Subject: [PATCH] kconfig: Document the new "visible if" syntax

Hi,

Can we get this kconfig-language.txt patch added to the kernel source tree, please?

Thanks for the reminder, I pushed it to kbuild-2.6.git#kconfig now.

Michal

Quoted 36 lines
Quoted 36 lines
Quoted 9 lines
Documentation/kbuild/kconfig-language.txt +0 -0
index 2fe93ca..2522cca 100644

Documentation/kbuild/kconfig-language.txt applicable everywhere (see syntax). · line 123

Quoted 10 lines
Documentation/kbuild/kconfig-language.txt +7 -0
@@ -114,6 +114,13 @@ applicable everywhere (see syntax).
 	the illegal configurations all over.
 	kconfig should one day warn about such things.
 
+- limiting menu display: "visible if" <expr>
+  This attribute is only applicable to menu blocks, if the condition is
+  false, the menu block is not displayed to the user (the symbols
+  contained there can still be selected by other symbols, though). It is
+  similar to a conditional "prompt" attribude for individual menu
+  entries.
+

Default value of "visible" is true ??

Quoted 14 lines
Documentation/kbuild/kconfig-language.txt +2 -2
 - numerical ranges: "range" <symbol> <symbol> ["if" <expr>]
   This allows to limit the range of possible input values for int
   and hex symbols. The user can only input a value which is larger than
@@ -300,7 +307,8 @@ menu:
 	"endmenu"
 
 This defines a menu block, see "Menu structure" above for more
-information. The only possible options are dependencies.
+information. The only possible options are dependencies and "visible"
+attributes.
 
 if:
 
--
#30 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

In reply to Michal Marek

Hi,

Quoted 7 lines · Michal Marek

So the patches look OK to me, I added your patches to kbuild-2.6.git#menu-visibility and merged the branch to for-next. The new syntax should be documented in Documentation/kbuild/kconfig-language.txt, below is a first attempt at it. If the patches work fine in linux-next _and_ you give me permission to push them to Linus, I'll move them to rc-fixes and send a pull request.

you've got it :).

Thanks,
- Arnaud

#31 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

In reply to Michal Marek

Hi,

Quoted 8 lines · Michal Marek

So the patches look OK to me, I added your patches to kbuild-2.6.git#menu-visibility and merged the branch to for-next. The new syntax should be documented in Documentation/kbuild/kconfig-language.txt, below is a first attempt at it. If the patches work fine in linux-next _and_ you give me permission to push them to Linus, I'll move them to rc-fixes and send a pull request.

last nits, could you maybe use commits from Mauro's branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-next.git
kconfig_fixes

They contains one more menu fix and his "Acked" tag.

Quoted 27 lines

Subject: [PATCH] kconfig: Document the new "visible if" syntax

Documentation/kbuild/kconfig-language.txt +0 -0
index 2fe93ca..2522cca 100644
@@ -114,6 +114,13 @@ applicable everywhere (see syntax).

       the illegal configurations all over. kconfig should one day warn about such things.

+- limiting menu display: "visible if" <expr>
+  This attribute is only applicable to menu blocks, if the condition is
+  false, the menu block is not displayed to the user (the symbols
+  contained there can still be selected by other symbols, though). It is
+  similar to a conditional "prompt" attribude for individual menu
+  entries.
+
 - numerical ranges: "range" <symbol> <symbol> ["if" <expr>] This allows to limit the range of possible input values for int and hex symbols. The user can only input a value which is larger than

Documentation/kbuild/kconfig-language.txt +0 -0
@@ -300,7 +307,8 @@ menu:

       "endmenu"

 This defines a menu block, see "Menu structure" above for more

Documentation/kbuild/kconfig-language.txt menu: · line 311

Quoted 3 lines
Documentation/kbuild/kconfig-language.txt +2 -1
-information. The only possible options are dependencies.
+information. The only possible options are dependencies and "visible"
+attributes.

Thanks for having done that part!

regards,
- Arnaud

#32 lore raw

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

In reply to Michal Marek

Em 26-11-2010 14:15, Michal Marek escreveu:

Quoted 40 lines · Michal Marek
Quoted 23 lines · Arnaud Lacombe
Quoted 15 lines

Hi folks,

Quoted 12 lines · Arnaud Lacombe

This option is aimed to add the possibility to control a menu's visibility without adding dependency to the expression to all the submenu.

---
 scripts/kconfig/expr.h      |    1 +
 scripts/kconfig/lkc.h       |    1 +
 scripts/kconfig/menu.c      |   11 +++++++++++
 scripts/kconfig/zconf.gperf |    1 +
 scripts/kconfig/zconf.y     |   21 ++++++++++++++++++---
 5 files changed, 32 insertions(+), 3 deletions(-)
Quoted 6 lines

As there seem to be no interested from Michal to either, ACK, NACK, or even comment this series, please let me withdraw these patches. If this mail is not enough to void the patch, I hope to still be able to withdraw my Signed-off-by from this particular series, and thus no longer be able to certify the origin of the patches to prevent their merge.

Quoted 7 lines

Hi Arnaud,

I'm sorry, I was sick for longer time and am now going through the patches that accumulated during that time. I understand your frustration, but the fact that I commented / applied some other patches yesterday and not this one does not mean that I'm ignoring it. Please accept my apologies, I'm looking at your patch right now...

So the patches look OK to me, I added your patches to kbuild-2.6.git#menu-visibility and merged the branch to for-next. The new syntax should be documented in Documentation/kbuild/kconfig-language.txt, below is a first attempt at it. If the patches work fine in linux-next _and_ you give me permission to push them to Linus, I'll move them to rc-fixes and send a pull request.

Quoted 6 lines

Michal

Subject: [PATCH] kconfig: Document the new "visible if" syntax

Seems ok to me. I would just add a note, as reminded by Randy, that visible is the default. Anyway,

Quoted 29 lines
Documentation/kbuild/kconfig-language.txt +9 -1
index 2fe93ca..2522cca 100644
@@ -114,6 +114,13 @@ applicable everywhere (see syntax).
 	the illegal configurations all over.
 	kconfig should one day warn about such things.
 
+- limiting menu display: "visible if" <expr>
+  This attribute is only applicable to menu blocks, if the condition is
+  false, the menu block is not displayed to the user (the symbols
+  contained there can still be selected by other symbols, though). It is
+  similar to a conditional "prompt" attribude for individual menu
+  entries.
+
 - numerical ranges: "range" <symbol> <symbol> ["if" <expr>]
   This allows to limit the range of possible input values for int
   and hex symbols. The user can only input a value which is larger than
@@ -300,7 +307,8 @@ menu:
 	"endmenu"
 
 This defines a menu block, see "Menu structure" above for more
-information. The only possible options are dependencies.
+information. The only possible options are dependencies and "visible"
+attributes.
 
 if:
 
#33 lore raw

PATCH 2/5 kconfig: regen parser

In reply to Mauro Carvalho Chehab
---
 scripts/kconfig/zconf.hash.c_shipped |  122 ++++----
 scripts/kconfig/zconf.tab.c_shipped  |  570 +++++++++++++++++----------------
 2 files changed, 358 insertions(+), 334 deletions(-)
scripts/kconfig/zconf.hash.c_shipped +64 -58
index c1748fa..4055d5d 100644
@@ -32,7 +32,7 @@
 struct kconf_id;
 
 static struct kconf_id *kconf_id_lookup(register const char *str, register unsigned int len);
-/* maximum key range = 47, duplicates = 0 */
+/* maximum key range = 50, duplicates = 0 */
 
 #ifdef __GNUC__
 __inline
@@ -46,32 +46,32 @@ kconf_id_hash (register const char *str, register unsigned int len)
 {
   static unsigned char asso_values[] =
     {
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 11,  5,
-       0,  0,  5, 49,  5, 20, 49, 49,  5, 20,
-       5,  0, 30, 49,  0, 15,  0, 10,  0, 49,
-      25, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49, 49, 49, 49, 49,
-      49, 49, 49, 49, 49, 49
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 40,  5,
+       0,  0,  5, 52,  0, 20, 52, 52, 10, 20,
+       5,  0, 35, 52,  0, 30,  0, 15,  0, 52,
+      15, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52, 52, 52, 52, 52,
+      52, 52, 52, 52, 52, 52
     };
   register int hval = len;
 
@@ -102,25 +102,26 @@ struct kconf_id_strings_t
     char kconf_id_strings_str12[sizeof("default")];
     char kconf_id_strings_str13[sizeof("def_bool")];
     char kconf_id_strings_str14[sizeof("help")];
-    char kconf_id_strings_str15[sizeof("bool")];
     char kconf_id_strings_str16[sizeof("config")];
     char kconf_id_strings_str17[sizeof("def_tristate")];
-    char kconf_id_strings_str18[sizeof("boolean")];
+    char kconf_id_strings_str18[sizeof("hex")];
     char kconf_id_strings_str19[sizeof("defconfig_list")];
-    char kconf_id_strings_str21[sizeof("string")];
     char kconf_id_strings_str22[sizeof("if")];
     char kconf_id_strings_str23[sizeof("int")];
-    char kconf_id_strings_str26[sizeof("select")];
     char kconf_id_strings_str27[sizeof("modules")];
     char kconf_id_strings_str28[sizeof("tristate")];
     char kconf_id_strings_str29[sizeof("menu")];
-    char kconf_id_strings_str31[sizeof("source")];
     char kconf_id_strings_str32[sizeof("comment")];
-    char kconf_id_strings_str33[sizeof("hex")];
     char kconf_id_strings_str35[sizeof("menuconfig")];
-    char kconf_id_strings_str36[sizeof("prompt")];
-    char kconf_id_strings_str37[sizeof("depends")];
+    char kconf_id_strings_str36[sizeof("string")];
+    char kconf_id_strings_str37[sizeof("visible")];
+    char kconf_id_strings_str41[sizeof("prompt")];
+    char kconf_id_strings_str42[sizeof("depends")];
+    char kconf_id_strings_str44[sizeof("bool")];
+    char kconf_id_strings_str46[sizeof("select")];
+    char kconf_id_strings_str47[sizeof("boolean")];
     char kconf_id_strings_str48[sizeof("mainmenu")];
+    char kconf_id_strings_str51[sizeof("source")];
   };
 static struct kconf_id_strings_t kconf_id_strings_contents =
   {
@@ -136,25 +137,26 @@ static struct kconf_id_strings_t kconf_id_strings_contents =
     "default",
     "def_bool",
     "help",
-    "bool",
     "config",
     "def_tristate",
-    "boolean",
+    "hex",
     "defconfig_list",
-    "string",
     "if",
     "int",
-    "select",
     "modules",
     "tristate",
     "menu",
-    "source",
     "comment",
-    "hex",
     "menuconfig",
+    "string",
+    "visible",
     "prompt",
     "depends",
-    "mainmenu"
+    "bool",
+    "select",
+    "boolean",
+    "mainmenu",
+    "source"
   };
 #define kconf_id_strings ((const char *) &kconf_id_strings_contents)
 #ifdef __GNUC__
@@ -168,11 +170,11 @@ kconf_id_lookup (register const char *str, register unsigned int len)
 {
   enum
     {
-      TOTAL_KEYWORDS = 31,
+      TOTAL_KEYWORDS = 32,
       MIN_WORD_LENGTH = 2,
       MAX_WORD_LENGTH = 14,
       MIN_HASH_VALUE = 2,
-      MAX_HASH_VALUE = 48
+      MAX_HASH_VALUE = 51
     };
 
   static struct kconf_id wordlist[] =
@@ -191,31 +193,35 @@ kconf_id_lookup (register const char *str, register unsigned int len)
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str12,	T_DEFAULT,	TF_COMMAND, S_UNKNOWN},
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str13,	T_DEFAULT,	TF_COMMAND, S_BOOLEAN},
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str14,		T_HELP,		TF_COMMAND},
-      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str15,		T_TYPE,		TF_COMMAND, S_BOOLEAN},
+      {-1},
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str16,		T_CONFIG,	TF_COMMAND},
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str17,	T_DEFAULT,	TF_COMMAND, S_TRISTATE},
-      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str18,	T_TYPE,		TF_COMMAND, S_BOOLEAN},
+      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str18,		T_TYPE,		TF_COMMAND, S_HEX},
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str19,	T_OPT_DEFCONFIG_LIST,TF_OPTION},
-      {-1},
-      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str21,		T_TYPE,		TF_COMMAND, S_STRING},
+      {-1}, {-1},
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str22,		T_IF,		TF_COMMAND|TF_PARAM},
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str23,		T_TYPE,		TF_COMMAND, S_INT},
-      {-1}, {-1},
-      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str26,		T_SELECT,	TF_COMMAND},
+      {-1}, {-1}, {-1},
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str27,	T_OPT_MODULES,	TF_OPTION},
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str28,	T_TYPE,		TF_COMMAND, S_TRISTATE},
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str29,		T_MENU,		TF_COMMAND},
-      {-1},
-      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str31,		T_SOURCE,	TF_COMMAND},
+      {-1}, {-1},
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str32,	T_COMMENT,	TF_COMMAND},
-      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str33,		T_TYPE,		TF_COMMAND, S_HEX},
-      {-1},
+      {-1}, {-1},
       {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str35,	T_MENUCONFIG,	TF_COMMAND},
-      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str36,		T_PROMPT,	TF_COMMAND},
-      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str37,	T_DEPENDS,	TF_COMMAND},
-      {-1}, {-1}, {-1}, {-1}, {-1}, {-1}, {-1}, {-1}, {-1},
+      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str36,		T_TYPE,		TF_COMMAND, S_STRING},
+      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str37,	T_VISIBLE,	TF_COMMAND},
+      {-1}, {-1}, {-1},
+      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str41,		T_PROMPT,	TF_COMMAND},
+      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str42,	T_DEPENDS,	TF_COMMAND},
       {-1},
-      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str48,	T_MAINMENU,	TF_COMMAND}
+      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str44,		T_TYPE,		TF_COMMAND, S_BOOLEAN},
+      {-1},
+      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str46,		T_SELECT,	TF_COMMAND},
+      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str47,	T_TYPE,		TF_COMMAND, S_BOOLEAN},
+      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str48,	T_MAINMENU,	TF_COMMAND},
+      {-1}, {-1},
+      {(int)(long)&((struct kconf_id_strings_t *)0)->kconf_id_strings_str51,		T_SOURCE,	TF_COMMAND}
     };
 
   if (len <= MAX_WORD_LENGTH && len >= MIN_WORD_LENGTH)
scripts/kconfig/zconf.tab.c_shipped +294 -276

966 lines not on this page · raw message

Signature · 1 line
1.7.2.30.gc37d7.dirty
#34 lore raw

PATCH 3/5 Revert "i2c: Fix Kconfig dependencies"

In reply to Mauro Carvalho Chehab

This reverts commit 0a57274ea026c2b7670683947b6cc08b195148cf.

---
 drivers/i2c/Kconfig       |    3 +--
 drivers/i2c/algos/Kconfig |   12 ------------
 2 files changed, 1 insertions(+), 14 deletions(-)
drivers/i2c/Kconfig +1 -2
index b923074..30f06e9 100644
@@ -75,8 +75,7 @@ config I2C_HELPER_AUTO
 	  In doubt, say Y.
 
 config I2C_SMBUS
-	tristate
-	prompt "SMBus-specific protocols" if !I2C_HELPER_AUTO
+	tristate "SMBus-specific protocols" if !I2C_HELPER_AUTO
 	help
 	  Say Y here if you want support for SMBus extensions to the I2C
 	  specification. At the moment, the only supported extension is
drivers/i2c/algos/Kconfig +0 -12
index 3998dd6..7b2ce4a 100644
@@ -15,15 +15,3 @@ config I2C_ALGOPCA
 	tristate "I2C PCA 9564 interfaces"
 
 endmenu
-
-# In automatic configuration mode, we still have to define the
-# symbols to avoid unmet dependencies.
-
-if I2C_HELPER_AUTO
-config I2C_ALGOBIT
-	tristate
-config I2C_ALGOPCF
-	tristate
-config I2C_ALGOPCA
-	tristate
-endif
Signature · 1 line
1.7.2.30.gc37d7.dirty
#35 lore raw

PATCH 4/5 media/video: convert Kconfig to use the menu's `visible' keyword

In reply to Mauro Carvalho Chehab
---
 drivers/media/video/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/video/Kconfig +1 -1
index ac16e81..6830d28 100644
@@ -112,7 +112,7 @@ config VIDEO_IR_I2C
 #
 
 menu "Encoders/decoders and other helper chips"
-	depends on !VIDEO_HELPER_CHIPS_AUTO
+	visible if !VIDEO_HELPER_CHIPS_AUTO
 
 comment "Audio decoders"
 
Signature · 1 line
1.7.2.30.gc37d7.dirty
#36 lore raw

PATCH 5/5 i2c/algos: convert Kconfig to use the menu's `visible' keyword

In reply to Mauro Carvalho Chehab
---
 drivers/i2c/algos/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/i2c/algos/Kconfig +1 -1
index 7b2ce4a..f1cfe7e 100644
@@ -3,7 +3,7 @@
 #
 
 menu "I2C Algorithms"
-	depends on !I2C_HELPER_AUTO
+	visible if !I2C_HELPER_AUTO
 
 config I2C_ALGOBIT
 	tristate "I2C bit-banging interfaces"
Signature · 1 line
1.7.2.30.gc37d7.dirty
#37 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

In reply to Mauro Carvalho Chehab

Hi,

Quoted 5 lines · Mauro Carvalho Chehab

Basically, we have things there like:

config VIDEO_HELPER_CHIPS_AUTO
       bool "Autoselect pertinent encoders/decoders and other helper chips"

Quoted 9 lines

config VIDEO_IVTV
       select VIDEO_WM8739 if VIDEO_HELPER_CHIPS_AUTO

menu "Encoders/decoders and other helper chips"
       depends on !VIDEO_HELPER_CHIPS_AUTO

config VIDEO_WM8739
       tristate "Wolfson Microelectronics WM8739 stereo audio ADC"

Where do you get that code from ? this particular one is not in 2.6.37-rc1:

% git describe
v2.6.37-rc1-27-gff8b16d

% head -20 drivers/media/video/ivtv/Kconfig
config VIDEO_IVTV

        tristate "Conexant cx23416/cx23415 MPEG encoder/decoder support"
        depends on VIDEO_V4L2 && PCI && I2C
        depends on INPUT   # due to VIDEO_IR
        select I2C_ALGOBIT
        depends on VIDEO_IR
        select VIDEO_TUNER
        select VIDEO_TVEEPROM
        select VIDEO_CX2341X
        select VIDEO_CX25840
        select VIDEO_MSP3400
        select VIDEO_SAA711X
        select VIDEO_SAA717X
        select VIDEO_SAA7127
        select VIDEO_CS53L32A
        select VIDEO_M52790
        select VIDEO_WM8775
        select VIDEO_WM8739
        select VIDEO_VP27SMPX
        select VIDEO_UPD64031A

- Arnaud

#38 lore raw

Re: REGRESSION: Re: [GIT] kconfig rc fixes

Em 04-11-2010 14:34, Arnaud Lacombe escreveu:

Quoted 12 lines

Hi,

Quoted 8 lines · Mauro Carvalho Chehab

Basically, we have things there like:

config VIDEO_HELPER_CHIPS_AUTO
bool "Autoselect pertinent encoders/decoders and other helper chips"

config VIDEO_IVTV
select VIDEO_WM8739 if VIDEO_HELPER_CHIPS_AUTO

Quoted 7 lines
Quoted 6 lines

menu "Encoders/decoders and other helper chips"
depends on !VIDEO_HELPER_CHIPS_AUTO

config VIDEO_WM8739
tristate "Wolfson Microelectronics WM8739 stereo audio ADC"

Where do you get that code from ? this particular one is not in 2.6.37-rc1:

The I2C drivers can/are used by other drivers, so they are not at ivtv/Kconfig. They are at drivers/media/video/Kconfig.

I'm using here just v2.6.37-rc1 (c8ddb2713c624f432fa5fe3c7ecffcdda46ea0d4):

$ grep VIDEO_WM8739 drivers/media/video/Kconfig -A2
config VIDEO_WM8739
	tristate "Wolfson Microelectronics WM8739 stereo audio ADC"
	depends on VIDEO_V4L2 && I2C
$ grep VIDEO_HELPER_CHIPS_AUTO drivers/media/video/Kconfig -A2|head -3
config VIDEO_HELPER_CHIPS_AUTO
	bool "Autoselect pertinent encoders/decoders and other helper chips"
	default y if !EMBEDDED
Quoted 27 lines

% git describe
v2.6.37-rc1-27-gff8b16d

% head -20 drivers/media/video/ivtv/Kconfig
config VIDEO_IVTV

        tristate "Conexant cx23416/cx23415 MPEG encoder/decoder support"
        depends on VIDEO_V4L2 && PCI && I2C
        depends on INPUT   # due to VIDEO_IR
        select I2C_ALGOBIT
        depends on VIDEO_IR
        select VIDEO_TUNER
        select VIDEO_TVEEPROM
        select VIDEO_CX2341X
        select VIDEO_CX25840
        select VIDEO_MSP3400
        select VIDEO_SAA711X
        select VIDEO_SAA717X
        select VIDEO_SAA7127
        select VIDEO_CS53L32A
        select VIDEO_M52790
        select VIDEO_WM8775
        select VIDEO_WM8739
        select VIDEO_VP27SMPX
        select VIDEO_UPD64031A

- Arnaud