Skip to contentSkip to conversation

b44: fix carrier detection on bind

PATCH Applied Paul Fertser 2 participants 2 messages Oct 11, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b44: fix carrier detection on bind

For carrier detection to work properly when binding the driver with a cable unplugged, netif_carrier_off() should be called after register_netdev(), not before.

---

Without this it's quite annoying to boot a laptop without ethernet connection as the userspace is getting confused and can even add a default route through a non-functional interface (when it's configured to use static ip).

 drivers/net/b44.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/b44.c +2 -2
index 37617ab..d711eb6 100644
@@ -2161,8 +2161,6 @@ static int __devinit b44_init_one(struct ssb_device *sdev,
 	dev->irq = sdev->irq;
 	SET_ETHTOOL_OPS(dev, &b44_ethtool_ops);
 
-	netif_carrier_off(dev);
-
 	err = ssb_bus_powerup(sdev->bus, 0);
 	if (err) {
 		dev_err(sdev->dev,
@@ -2204,6 +2202,8 @@ static int __devinit b44_init_one(struct ssb_device *sdev,
 		goto err_out_powerdown;
 	}
 
+	netif_carrier_off(dev);
+
 	ssb_set_drvdata(sdev, dev);
 
 	/* Chip reset provides power to the b44 MAC & PCI cores, which
Signature · 1 line
1.7.2.2
maintainer Applied
#1 lore raw

From: Paul Fertser <[email protected]>
Date: Tue, 12 Oct 2010 02:42:30 +0400

Quoted 5 lines

For carrier detection to work properly when binding the driver with a cable unplugged, netif_carrier_off() should be called after register_netdev(), not before.

Applied, thanks.